Re: [PATCH 3/5] ARM: dts: sun5i: Add new sun5i-a13-olinuxino-micro board

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3345 bytes --]

On Sat, Dec 14, 2013 at 10:58:13PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Commit log :)

Please detail what the board is, what features it has, etc.

Other than that, I'm mostly ok with this patch (except that you can
also probably add your copyright, but that's your call :))

Could you send it as a single patch, separate from this serie (since
it's not really related in the end).

Thanks!
Maxime

> ---
>  arch/arm/boot/dts/Makefile                      |  1 +
>  arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 66 +++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d57c1a6..b663ed7 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -255,6 +255,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += \
>  	sun4i-a10-hackberry.dtb \
>  	sun5i-a10s-olinuxino-micro.dtb \
>  	sun5i-a13-olinuxino.dtb \
> +	sun5i-a13-olinuxino-micro.dtb \
>  	sun6i-a31-colombus.dtb \
>  	sun7i-a20-cubieboard2.dtb \
>  	sun7i-a20-cubietruck.dtb \
> diff --git a/arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts
> new file mode 100644
> index 0000000..26df7e8
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts
> @@ -0,0 +1,66 @@
> +/*
> + * Copyright 2012 Maxime Ripard
> + *
> + * Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +/include/ "sun5i-a13.dtsi"
> +
> +/ {
> +	model = "Olimex A13-Olinuxino Micro";
> +	compatible = "olimex,a13-olinuxino-micro", "allwinner,sun5i-a13";
> +
> +	soc@01c00000 {
> +		pinctrl@01c20800 {
> +			led_pins_olinuxinom: led_pins@0 {
> +				allwinner,pins = "PG9";
> +				allwinner,function = "gpio_out";
> +				allwinner,drive = <1>;
> +				allwinner,pull = <0>;
> +			};
> +		};
> +
> +		uart1: serial@01c28400 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&uart1_pins_b>;
> +			status = "okay";
> +		};
> +
> +		i2c0: i2c@01c2ac00 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c0_pins_a>;
> +			status = "okay";
> +		};
> +
> +		i2c1: i2c@01c2b000 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c1_pins_a>;
> +			status = "okay";
> +		};
> +
> +		i2c2: i2c@01c2b400 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c2_pins_a>;
> +			status = "okay";
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pins_olinuxinom>;
> +
> +		power {

Could you add a label here?

Something like a13-olinuxino-micro:green:power ?

> +			gpios = <&pio 6 9 0>;
> +			default-state = "on";
> +		};
> +	};
> +};

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]