* [PATCH 2/3] SubmittingPatches: Add recommendation for mailing list references
@ 2013-12-15 20:59 Josh Triplett
2013-12-15 21:17 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Josh Triplett @ 2013-12-15 20:59 UTC (permalink / raw)
To: linux-kernel, linux-doc; +Cc: Rob Landley
SubmittingPatches already mentions referencing bugs fixed by a commit,
but doesn't mention citing relevant mailing list discussions. Add a
note to that effect, along with a recommendation to use the
https://lkml.kernel.org/ redirector.
Portions based on text from git's SubmittingPatches.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
Documentation/SubmittingPatches | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c74e73c..53e6590 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -112,7 +112,15 @@ to do frotz", as if you are giving orders to the codebase to change
its behaviour.
If the patch fixes a logged bug entry, refer to that bug entry by
-number and URL.
+number and URL. If the patch follows from a mailing list discussion,
+give a URL to the mailing list archive; use the https://lkml.kernel.org/
+redirector with a Message-Id, to ensure that the links cannot become
+stale.
+
+However, try to make your explanation understandable without external
+resources. In addition to giving a URL to a mailing list archive or
+bug, summarize the relevant points of the discussion that led to the
+patch as submitted.
If you want to refer to a specific commit, don't just refer to the
SHA-1 ID of the commit. Please also include the oneline summary of
--
1.8.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] SubmittingPatches: Add recommendation for mailing list references
2013-12-15 20:59 [PATCH 2/3] SubmittingPatches: Add recommendation for mailing list references Josh Triplett
@ 2013-12-15 21:17 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2013-12-15 21:17 UTC (permalink / raw)
To: Josh Triplett; +Cc: linux-kernel, linux-doc, Rob Landley
On Sun, Dec 15, 2013 at 12:59:40PM -0800, Josh Triplett wrote:
> SubmittingPatches already mentions referencing bugs fixed by a commit,
> but doesn't mention citing relevant mailing list discussions. Add a
> note to that effect, along with a recommendation to use the
> https://lkml.kernel.org/ redirector.
>
> Portions based on text from git's SubmittingPatches.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Yep.
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-15 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-15 20:59 [PATCH 2/3] SubmittingPatches: Add recommendation for mailing list references Josh Triplett
2013-12-15 21:17 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.