From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: mjg59@srcf.ucam.org, msalter@redhat.com,
linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, leif.lindholm@linaro.org,
James.Bottomley@HansenPartnership.com, horms@verge.net.au,
bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com,
akpm@linux-foundation.org, mingo@kernel.org, vgoyal@redhat.com
Subject: Re: [PATCH v6 08/14] efi: export efi runtime memory mapping to sysfs
Date: Mon, 16 Dec 2013 15:09:29 +0000 [thread overview]
Message-ID: <20131216150929.GA3873@console-pimps.org> (raw)
In-Reply-To: <1387186235-15972-9-git-send-email-dyoung@redhat.com>
On Mon, 16 Dec, at 05:30:29PM, Dave Young wrote:
> @@ -899,6 +928,11 @@ void __init efi_enter_virtual_mode(void)
> return;
> }
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> + efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
> + boot_params.efi_info.efi_memdesc_size);
> +#endif
[...]
> @@ -167,6 +167,12 @@ static int __init efisubsys_init(void)
> goto err_unregister;
> }
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> + error = efi_runtime_map_init(efi_kobj);
> + if (error)
> + goto err_remove_group;
> +#endif
[...]
> @@ -876,4 +876,9 @@ int efivars_sysfs_init(void);
>
> #endif /* CONFIG_EFI_VARS */
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> +int efi_runtime_map_init(struct kobject *);
> +void efi_runtime_map_setup(void *, int, u32);
> +#endif
I was thinking more along the lines of...
---
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 120086820654..fd5a0aad1fff 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -928,10 +928,8 @@ void __init efi_enter_virtual_mode(void)
return;
}
-#ifdef CONFIG_EFI_RUNTIME_MAP
efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
boot_params.efi_info.efi_memdesc_size);
-#endif
BUG_ON(!efi.systab);
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 4109dca787dc..4753bac65279 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -167,11 +167,9 @@ static int __init efisubsys_init(void)
goto err_unregister;
}
-#ifdef CONFIG_EFI_RUNTIME_MAP
error = efi_runtime_map_init(efi_kobj);
if (error)
goto err_remove_group;
-#endif
/* and the standard mountpoint for efivarfs */
efivars_kobj = kobject_create_and_add("efivars", efi_kobj);
diff --git a/include/linux/efi.h b/include/linux/efi.h
index a98eb0621583..e64540746c63 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -875,6 +875,14 @@ int efivars_sysfs_init(void);
#ifdef CONFIG_EFI_RUNTIME_MAP
int efi_runtime_map_init(struct kobject *);
void efi_runtime_map_setup(void *, int, u32);
+#else
+static inline int efi_runtime_map_init(struct kobject *kobj)
+{
+ return 0;
+}
+
+static inline void
+efi_runtime_map_setup(void *map, int nr_entries, u32 desc_size) {}
#endif
#endif /* _LINUX_EFI_H */
--
Matt Fleming, Intel Open Source Technology Center
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
toshi.kani-VXdhtT5mjnY@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v6 08/14] efi: export efi runtime memory mapping to sysfs
Date: Mon, 16 Dec 2013 15:09:29 +0000 [thread overview]
Message-ID: <20131216150929.GA3873@console-pimps.org> (raw)
In-Reply-To: <1387186235-15972-9-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, 16 Dec, at 05:30:29PM, Dave Young wrote:
> @@ -899,6 +928,11 @@ void __init efi_enter_virtual_mode(void)
> return;
> }
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> + efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
> + boot_params.efi_info.efi_memdesc_size);
> +#endif
[...]
> @@ -167,6 +167,12 @@ static int __init efisubsys_init(void)
> goto err_unregister;
> }
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> + error = efi_runtime_map_init(efi_kobj);
> + if (error)
> + goto err_remove_group;
> +#endif
[...]
> @@ -876,4 +876,9 @@ int efivars_sysfs_init(void);
>
> #endif /* CONFIG_EFI_VARS */
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> +int efi_runtime_map_init(struct kobject *);
> +void efi_runtime_map_setup(void *, int, u32);
> +#endif
I was thinking more along the lines of...
---
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 120086820654..fd5a0aad1fff 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -928,10 +928,8 @@ void __init efi_enter_virtual_mode(void)
return;
}
-#ifdef CONFIG_EFI_RUNTIME_MAP
efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
boot_params.efi_info.efi_memdesc_size);
-#endif
BUG_ON(!efi.systab);
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 4109dca787dc..4753bac65279 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -167,11 +167,9 @@ static int __init efisubsys_init(void)
goto err_unregister;
}
-#ifdef CONFIG_EFI_RUNTIME_MAP
error = efi_runtime_map_init(efi_kobj);
if (error)
goto err_remove_group;
-#endif
/* and the standard mountpoint for efivarfs */
efivars_kobj = kobject_create_and_add("efivars", efi_kobj);
diff --git a/include/linux/efi.h b/include/linux/efi.h
index a98eb0621583..e64540746c63 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -875,6 +875,14 @@ int efivars_sysfs_init(void);
#ifdef CONFIG_EFI_RUNTIME_MAP
int efi_runtime_map_init(struct kobject *);
void efi_runtime_map_setup(void *, int, u32);
+#else
+static inline int efi_runtime_map_init(struct kobject *kobj)
+{
+ return 0;
+}
+
+static inline void
+efi_runtime_map_setup(void *map, int nr_entries, u32 desc_size) {}
#endif
#endif /* _LINUX_EFI_H */
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com,
toshi.kani@hp.com, akpm@linux-foundation.org, mingo@kernel.org,
msalter@redhat.com, leif.lindholm@linaro.org
Subject: Re: [PATCH v6 08/14] efi: export efi runtime memory mapping to sysfs
Date: Mon, 16 Dec 2013 15:09:29 +0000 [thread overview]
Message-ID: <20131216150929.GA3873@console-pimps.org> (raw)
In-Reply-To: <1387186235-15972-9-git-send-email-dyoung@redhat.com>
On Mon, 16 Dec, at 05:30:29PM, Dave Young wrote:
> @@ -899,6 +928,11 @@ void __init efi_enter_virtual_mode(void)
> return;
> }
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> + efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
> + boot_params.efi_info.efi_memdesc_size);
> +#endif
[...]
> @@ -167,6 +167,12 @@ static int __init efisubsys_init(void)
> goto err_unregister;
> }
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> + error = efi_runtime_map_init(efi_kobj);
> + if (error)
> + goto err_remove_group;
> +#endif
[...]
> @@ -876,4 +876,9 @@ int efivars_sysfs_init(void);
>
> #endif /* CONFIG_EFI_VARS */
>
> +#ifdef CONFIG_EFI_RUNTIME_MAP
> +int efi_runtime_map_init(struct kobject *);
> +void efi_runtime_map_setup(void *, int, u32);
> +#endif
I was thinking more along the lines of...
---
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 120086820654..fd5a0aad1fff 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -928,10 +928,8 @@ void __init efi_enter_virtual_mode(void)
return;
}
-#ifdef CONFIG_EFI_RUNTIME_MAP
efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
boot_params.efi_info.efi_memdesc_size);
-#endif
BUG_ON(!efi.systab);
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 4109dca787dc..4753bac65279 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -167,11 +167,9 @@ static int __init efisubsys_init(void)
goto err_unregister;
}
-#ifdef CONFIG_EFI_RUNTIME_MAP
error = efi_runtime_map_init(efi_kobj);
if (error)
goto err_remove_group;
-#endif
/* and the standard mountpoint for efivarfs */
efivars_kobj = kobject_create_and_add("efivars", efi_kobj);
diff --git a/include/linux/efi.h b/include/linux/efi.h
index a98eb0621583..e64540746c63 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -875,6 +875,14 @@ int efivars_sysfs_init(void);
#ifdef CONFIG_EFI_RUNTIME_MAP
int efi_runtime_map_init(struct kobject *);
void efi_runtime_map_setup(void *, int, u32);
+#else
+static inline int efi_runtime_map_init(struct kobject *kobj)
+{
+ return 0;
+}
+
+static inline void
+efi_runtime_map_setup(void *map, int nr_entries, u32 desc_size) {}
#endif
#endif /* _LINUX_EFI_H */
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-12-16 15:09 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 9:30 [PATCH v6 00/14] kexec kernel efi runtime support Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 01/14] x86/mm: sparse warning fix for early_memremap Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 02/14] efi: Use early_memremap and early_memunmap to fix sparse warnings Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 03/14] efi: remove unused variables in __map_region Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 04/14] efi: add a wrapper function efi_map_region_fixed Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 05/14] efi: reserve boot service fix Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 06/14] efi: cleanup efi_enter_virtual_mode function Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 07/14] efi: export more efi table variable to sysfs Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 08/14] efi: export efi runtime memory mapping " Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 15:09 ` Matt Fleming [this message]
2013-12-16 15:09 ` Matt Fleming
2013-12-16 15:09 ` Matt Fleming
2013-12-17 6:13 ` Dave Young
2013-12-17 6:13 ` Dave Young
2013-12-17 6:13 ` Dave Young
2013-12-17 8:00 ` [PATCH v7 " Dave Young
2013-12-17 8:00 ` Dave Young
2013-12-17 8:00 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 09/14] efi: passing kexec necessary efi data via setup_data Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-17 8:01 ` [PATCH v7 " Dave Young
2013-12-17 8:01 ` Dave Young
2013-12-17 8:01 ` Dave Young
2013-12-17 8:08 ` Dave Young
2013-12-17 8:08 ` Dave Young
2013-12-17 8:08 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-19 16:41 ` Matt Fleming
2013-12-19 16:41 ` Matt Fleming
2013-12-19 16:41 ` Matt Fleming
2013-12-20 1:35 ` Dave Young
2013-12-20 1:35 ` Dave Young
2013-12-20 1:35 ` Dave Young
2013-12-20 1:57 ` Dave Young
2013-12-20 1:57 ` Dave Young
2013-12-20 1:57 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 11/14] x86: add xloadflags bit for efi runtime support on kexec Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 12/14] x86: export x86 boot_params to sysfs Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 13/14] x86: reserve setup_data ranges late after parsing memmap cmdline Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` [PATCH v6 14/14] x86: kdebugfs do not use __va for getting setup_data virt addr Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 9:30 ` Dave Young
2013-12-16 16:35 ` Matt Fleming
2013-12-16 16:35 ` Matt Fleming
2013-12-16 16:35 ` Matt Fleming
2013-12-17 6:24 ` Dave Young
2013-12-17 6:24 ` Dave Young
2013-12-17 6:24 ` Dave Young
2013-12-17 6:53 ` Dave Young
2013-12-17 6:53 ` Dave Young
2013-12-17 6:53 ` Dave Young
2013-12-17 11:24 ` Matt Fleming
2013-12-17 11:24 ` Matt Fleming
2013-12-17 11:24 ` Matt Fleming
2013-12-18 9:29 ` Dave Young
2013-12-18 9:29 ` Dave Young
2013-12-18 9:29 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216150929.GA3873@console-pimps.org \
--to=matt@console-pimps.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=msalter@redhat.com \
--cc=toshi.kani@hp.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.