From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
Date: Mon, 16 Dec 2013 16:26:44 -0500 [thread overview]
Message-ID: <20131216212644.GA15814@beef> (raw)
In-Reply-To: <20131216212001.GD12896@saruman.home>
On Mon, Dec 16, 2013 at 03:20:01PM -0600, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 11:51:19AM -0500, Matt Porter wrote:
> > If a generic phy is present, call phy_init()/phy_exit(). This supports
> > generic phys that must be soft reset before power on.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> > drivers/usb/gadget/s3c-hsotg.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> > index 7c5d8bd..e9683c2 100644
> > --- a/drivers/usb/gadget/s3c-hsotg.c
> > +++ b/drivers/usb/gadget/s3c-hsotg.c
> > @@ -3621,6 +3621,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
> > goto err_supplies;
> > }
> >
> > + if (hsotg->phy)
> > + phy_init(hsotg->phy);
>
> doesn't build. you need to include <linux/phy/phy.h>
It depends on https://lkml.org/lkml/2013/12/5/172 which I noted in the
cover letter. At this point, I don't know if Kamil's whole series will
make it to 3.14 so that patch may have to be taken separately. He has a
trivial update to make on the binding example is all for this patch.
I was wondering today if we might just want to separate that out now. I
originally had a similar patch in my series but his was posted first so
I rebased on that.
-Matt
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@linaro.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Christian Daudt <bcm@fixthebug.org>,
Paul Zimmerman <paulz@synopsys.com>,
Tomasz Figa <t.figa@samsung.com>,
Kamil Debski <k.debski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Dinh Nguyen <dinh.linux@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Linux USB List <linux-usb@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
Date: Mon, 16 Dec 2013 16:26:44 -0500 [thread overview]
Message-ID: <20131216212644.GA15814@beef> (raw)
In-Reply-To: <20131216212001.GD12896@saruman.home>
On Mon, Dec 16, 2013 at 03:20:01PM -0600, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 11:51:19AM -0500, Matt Porter wrote:
> > If a generic phy is present, call phy_init()/phy_exit(). This supports
> > generic phys that must be soft reset before power on.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> > drivers/usb/gadget/s3c-hsotg.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> > index 7c5d8bd..e9683c2 100644
> > --- a/drivers/usb/gadget/s3c-hsotg.c
> > +++ b/drivers/usb/gadget/s3c-hsotg.c
> > @@ -3621,6 +3621,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
> > goto err_supplies;
> > }
> >
> > + if (hsotg->phy)
> > + phy_init(hsotg->phy);
>
> doesn't build. you need to include <linux/phy/phy.h>
It depends on https://lkml.org/lkml/2013/12/5/172 which I noted in the
cover letter. At this point, I don't know if Kamil's whole series will
make it to 3.14 so that patch may have to be taken separately. He has a
trivial update to make on the binding example is all for this patch.
I was wondering today if we might just want to separate that out now. I
originally had a similar patch in my series but his was posted first so
I rebased on that.
-Matt
next prev parent reply other threads:[~2013-12-16 21:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 16:51 [PATCH v6 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-12-13 16:51 ` [PATCH v6 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 " Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-16 21:20 ` Felipe Balbi
2013-12-16 21:20 ` Felipe Balbi
2013-12-16 21:20 ` Felipe Balbi
2013-12-16 21:26 ` Matt Porter [this message]
2013-12-16 21:26 ` Matt Porter
2013-12-16 21:30 ` Felipe Balbi
2013-12-16 21:30 ` Felipe Balbi
2013-12-16 21:30 ` Felipe Balbi
2013-12-13 16:51 ` [PATCH v6 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` [PATCH v6 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-12-13 16:51 ` Matt Porter
2013-12-13 16:51 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216212644.GA15814@beef \
--to=mporter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.