From: Seth Forshee <seth.forshee@canonical.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
brcm80211-dev-list@broadcom.com,
"John W. Linville" <linville@tuxdriver.com>,
Stefano Brivio <stefano.brivio@polimi.it>,
Arend van Spriel <arend@broadcom.com>
Subject: [RFC PATCH 1/8] mac80211: Move dynamic PS data out of common code
Date: Tue, 17 Dec 2013 06:37:34 -0600 [thread overview]
Message-ID: <20131217123734.GA8557@thinkpad-t410> (raw)
In-Reply-To: <1387267730.4749.2.camel@jlt4.sipsolutions.net>
On Tue, Dec 17, 2013 at 09:08:50AM +0100, Johannes Berg wrote:
> On Mon, 2013-12-16 at 16:00 -0600, Seth Forshee wrote:
>
> > +void ieee80211_notify_rx(struct ieee80211_rx_data *rx)
> > +{
> > + switch(rx->sdata->vif.type) {
> > + case NL80211_IFTYPE_MONITOR:
> > + ieee80211_mgd_notify_rx(rx);
>
> This ... seems wrong.
Yeah, it is. I guess there's always been enough tx while I was testing
to keep the dynamic ps timer updated.
> Also, we already have ieee80211_sta_rx_notify() which you want, I think?
I'm not sure, that's called earlier in the rx handlers. I guess that
probably only matters if there's an rx error, and the only penalty is
coming out of PS briefly. So I could probably use that instead.
> With this change, do you even still need local->ps_sdata?
Some of the code still uses ps_sdata, but I do remove it in a later
patch. I might be able to remove it here, but it's easier to do it when
the managed code changes to use the PS module.
WARNING: multiple messages have this Message-ID (diff)
From: Seth Forshee <seth.forshee@canonical.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
brcm80211-dev-list@broadcom.com,
"John W. Linville" <linville@tuxdriver.com>,
Stefano Brivio <stefano.brivio@polimi.it>,
Arend van Spriel <arend@broadcom.com>
Subject: Re: [RFC PATCH 1/8] mac80211: Move dynamic PS data out of common code
Date: Tue, 17 Dec 2013 06:37:34 -0600 [thread overview]
Message-ID: <20131217123734.GA8557@thinkpad-t410> (raw)
In-Reply-To: <1387267730.4749.2.camel@jlt4.sipsolutions.net>
On Tue, Dec 17, 2013 at 09:08:50AM +0100, Johannes Berg wrote:
> On Mon, 2013-12-16 at 16:00 -0600, Seth Forshee wrote:
>
> > +void ieee80211_notify_rx(struct ieee80211_rx_data *rx)
> > +{
> > + switch(rx->sdata->vif.type) {
> > + case NL80211_IFTYPE_MONITOR:
> > + ieee80211_mgd_notify_rx(rx);
>
> This ... seems wrong.
Yeah, it is. I guess there's always been enough tx while I was testing
to keep the dynamic ps timer updated.
> Also, we already have ieee80211_sta_rx_notify() which you want, I think?
I'm not sure, that's called earlier in the rx handlers. I guess that
probably only matters if there's an rx error, and the only penalty is
coming out of PS briefly. So I could probably use that instead.
> With this change, do you even still need local->ps_sdata?
Some of the code still uses ps_sdata, but I do remove it in a later
patch. I might be able to remove it here, but it's easier to do it when
the managed code changes to use the PS module.
next prev parent reply other threads:[~2013-12-17 12:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 22:00 [RFC/RFT] mac80211 powersave rework Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 1/8] mac80211: Move dynamic PS data out of common code Seth Forshee
2013-12-17 8:08 ` Johannes Berg
2013-12-17 8:08 ` Johannes Berg
2013-12-17 12:37 ` Seth Forshee [this message]
2013-12-17 12:37 ` Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 2/8] mac80211: Add per-interface powersave states and parameters Seth Forshee
2013-12-17 8:11 ` Johannes Berg
2013-12-17 8:11 ` Johannes Berg
2013-12-17 13:12 ` Seth Forshee
2013-12-17 13:12 ` Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 3/8] mac80211: Add powersave module Seth Forshee
2013-12-17 8:16 ` Johannes Berg
2013-12-17 8:16 ` Johannes Berg
2013-12-17 13:31 ` Seth Forshee
2013-12-17 13:31 ` Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 4/8] mac80211: Use PS module for managed mode powersave Seth Forshee
2013-12-17 8:25 ` Johannes Berg
2013-12-17 8:25 ` Johannes Berg
2013-12-17 14:09 ` Seth Forshee
2013-12-17 14:09 ` Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 5/8] mac80211: Don't start dynamic PS timer when leaving off-channel if still scanning Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 6/8] brcmsmac: Set MCTL_HPS when PM should be set Seth Forshee
2013-12-16 22:00 ` [RFC PATCH 7/8] b43: Allow HWPS state to be changed Seth Forshee
2013-12-16 22:01 ` [RFC PATCH 8/8] b43: Set B43_MACCTL_HWPS when PM should be set Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217123734.GA8557@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.