Re: [PATCH 02/05 v2] pinctrl: sh-pfc: r7s72100 base support

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Wolfram Sang <wsa@the-dreams.de>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	linux-sh@vger.kernel.org, horms@verge.net.au,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 02/05 v2] pinctrl: sh-pfc: r7s72100 base support
Date: Tue, 17 Dec 2013 21:04:03 +0000	[thread overview]
Message-ID: <20131217210403.GA1196@katana> (raw)
In-Reply-To: <20131217023804.24573.82351.sendpatchset@w520>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Hi,

> +#define _P_DATA(bank, pin, name, sfx)					\
> +	PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0,		\
> +		    name##_PIBC_1, name##_PBDC_1)
> +
> +#define _P_FN(n, fn, pfcae, pfce, pfc)					\
> +	PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1,	n##_PIPC_1,		\
> +		    n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc)

I need to apply this patch, otherwise my i2c pinmuxing fails?

diff --git a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
index 4acdaae..2b716d1 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
@@ -68,11 +68,11 @@ enum {
 #define _P_GPIO(bank, _pin, _name, sfx) _GP_GPIO(16, bank, _pin, _name, sfx)
 
 #define _P_DATA(bank, pin, name, sfx)					\
-	PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0,		\
+	PINMUX_DATA(name##_DATA, name##_PMC_0,		\
 		    name##_PIBC_1, name##_PBDC_1)
 
 #define _P_FN(n, fn, pfcae, pfce, pfc)					\
-	PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1,	n##_PIPC_1,		\
+	PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1,		\
 		    n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc)
 
 #define _P_MARK_FN1(bank, pin, name, sfx) _P_FN(name, 1, 0, 0, 0)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)

From: Wolfram Sang <wsa@the-dreams.de>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	linux-sh@vger.kernel.org, horms@verge.net.au,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 02/05 v2] pinctrl: sh-pfc: r7s72100 base support
Date: Tue, 17 Dec 2013 22:04:03 +0100	[thread overview]
Message-ID: <20131217210403.GA1196@katana> (raw)
In-Reply-To: <20131217023804.24573.82351.sendpatchset@w520>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Hi,

> +#define _P_DATA(bank, pin, name, sfx)					\
> +	PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0,		\
> +		    name##_PIBC_1, name##_PBDC_1)
> +
> +#define _P_FN(n, fn, pfcae, pfce, pfc)					\
> +	PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1,	n##_PIPC_1,		\
> +		    n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc)

I need to apply this patch, otherwise my i2c pinmuxing fails?

diff --git a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
index 4acdaae..2b716d1 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
@@ -68,11 +68,11 @@ enum {
 #define _P_GPIO(bank, _pin, _name, sfx) _GP_GPIO(16, bank, _pin, _name, sfx)
 
 #define _P_DATA(bank, pin, name, sfx)					\
-	PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0,		\
+	PINMUX_DATA(name##_DATA, name##_PMC_0,		\
 		    name##_PIBC_1, name##_PBDC_1)
 
 #define _P_FN(n, fn, pfcae, pfce, pfc)					\
-	PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1,	n##_PIPC_1,		\
+	PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1,		\
 		    n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc)
 
 #define _P_MARK_FN1(bank, pin, name, sfx) _P_FN(name, 1, 0, 0, 0)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

next prev parent reply	other threads:[~2013-12-17 21:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  2:37 [PATCH 00/05 v2] pinctrl: sh-pfc: r7s72100 support V2 Magnus Damm
2013-12-17  2:37 ` Magnus Damm
2013-12-17  2:37 ` [PATCH 01/05 v2] pinctrl: sh-pfc: Rework _GP_GPIO, introduce _GP_GPIO32 Magnus Damm
2013-12-17  2:37   ` Magnus Damm
2013-12-17  2:38 ` [PATCH 02/05 v2] pinctrl: sh-pfc: r7s72100 base support Magnus Damm
2013-12-17  2:38   ` Magnus Damm
2013-12-17 16:17   ` Laurent Pinchart
2013-12-17 16:17     ` Laurent Pinchart
2013-12-17 21:04   ` Wolfram Sang [this message]
2013-12-17 21:04     ` Wolfram Sang
2013-12-17 22:29     ` Magnus Damm
2013-12-17 22:29       ` Magnus Damm
2013-12-18 10:05       ` Wolfram Sang
2013-12-18 10:05         ` Wolfram Sang
2013-12-18 10:35         ` Magnus Damm
2013-12-18 10:35           ` Magnus Damm
2013-12-17  2:38 ` [PATCH 03/05 v2] pinctrl: sh-pfc: r7s72100 single pin macros Magnus Damm
2013-12-17  2:38   ` Magnus Damm
2013-12-17 16:01   ` Laurent Pinchart
2013-12-17 16:01     ` Laurent Pinchart
2013-12-17 22:34     ` Magnus Damm
2013-12-17 22:34       ` Magnus Damm
2013-12-17  2:38 ` [PATCH 04/05 v2] pinctrl: sh-pfc: r7s72100 SCIF support Magnus Damm
2013-12-17  2:38   ` Magnus Damm
2013-12-17 16:08   ` Laurent Pinchart
2013-12-17 16:08     ` Laurent Pinchart
2013-12-17 22:26     ` Magnus Damm
2013-12-17 22:26       ` Magnus Damm
2013-12-31 17:29       ` Laurent Pinchart
2013-12-31 17:29         ` Laurent Pinchart
2013-12-17  2:38 ` [PATCH 05/05 v2] pinctrl: sh-pfc: r8a7791 and r7s72100 binding docs Magnus Damm
2013-12-17  2:38   ` Magnus Damm
2013-12-29 23:35 ` [PATCH 00/05 v2] pinctrl: sh-pfc: r7s72100 support V2 Laurent Pinchart
2013-12-29 23:35   ` Laurent Pinchart

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:4acdaae dfblob:2b716d1 dfblob:4acdaae dfblob:2b716d1 )
 OR (
bs:"Re: [PATCH 02/05 v2] pinctrl: sh-pfc: r7s72100 base support" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217210403.GA1196@katana \
    --to=wsa@the-dreams.de \
    --cc=horms@verge.net.au \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.