From: Kent Overstreet <kmo@daterainc.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] closures: move to lib/
Date: Wed, 18 Dec 2013 17:37:04 -0800 [thread overview]
Message-ID: <20131219013704.GE4054@kmo> (raw)
In-Reply-To: <CAPcyv4gBN4M312WRmAvwHbTjMspiSTPuFyir_fc3nH6akpgosw@mail.gmail.com>
On Wed, Dec 18, 2013 at 05:34:31PM -0800, Dan Williams wrote:
> On Wed, Dec 18, 2013 at 5:29 PM, Kent Overstreet <kmo@daterainc.com> wrote:
> > the closure code was never intended to be bcache specific - hopefully it can be
> > useful elsewhere in the kernel.
> >
> > Signed-off-by: Kent Overstreet <kmo@daterainc.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Arjan van de Ven <arjan@linux.intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > ---
> > drivers/md/bcache/Kconfig | 9 -
> > drivers/md/bcache/Makefile | 2 +-
> > drivers/md/bcache/bcache.h | 2 +-
> > drivers/md/bcache/closure.c | 222 ----------------------
> > drivers/md/bcache/closure.h | 453 --------------------------------------------
> > drivers/md/bcache/util.h | 3 +-
> > include/linux/closure.h | 451 +++++++++++++++++++++++++++++++++++++++++++
> > lib/Kconfig.debug | 8 +
> > lib/Makefile | 2 +-
> > lib/closure.c | 218 +++++++++++++++++++++
> > 10 files changed, 681 insertions(+), 689 deletions(-)
> > delete mode 100644 drivers/md/bcache/closure.c
> > delete mode 100644 drivers/md/bcache/closure.h
> > create mode 100644 include/linux/closure.h
> > create mode 100644 lib/closure.c
>
> This would be smaller to review with git diff -M
I forgot to mention - this is on top of other stuff I have queued up which
deletes a fair amount of code in closure.[ch] (finally got rid of some stuff
Tejun hated).
next prev parent reply other threads:[~2013-12-19 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 1:29 [PATCH] closures: move to lib/ Kent Overstreet
2013-12-19 1:34 ` Dan Williams
2013-12-19 1:37 ` Kent Overstreet [this message]
2013-12-19 12:05 ` Christoph Hellwig
2013-12-19 12:18 ` Kent Overstreet
2013-12-19 12:19 ` Christoph Hellwig
2013-12-19 12:21 ` Kent Overstreet
2013-12-22 19:30 ` Christoph Hellwig
2013-12-19 15:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219013704.GE4054@kmo \
--to=kmo@daterainc.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.