From: Kent Overstreet <kmo@daterainc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] closures: move to lib/
Date: Thu, 19 Dec 2013 04:18:30 -0800 [thread overview]
Message-ID: <20131219121830.GA25385@kmo-pixel> (raw)
In-Reply-To: <20131219120516.GA26089@infradead.org>
On Thu, Dec 19, 2013 at 04:05:16AM -0800, Christoph Hellwig wrote:
> On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote:
> > the closure code was never intended to be bcache specific - hopefully it can be
> > useful elsewhere in the kernel.
>
> They are not. They aren't closures in the CS sense,
If you consider the key thing behind CS closures to be spaghetti stacks,
then actually these kind of are.
> and they are an
> ugly mess. Please work on removing them instead.
That's not really the kind of technical objection one can respond to. If
you think there's a better way of doing this kind of asynchronous stuff,
or a better mechanism already in the kernel (ha!) - please, by all
means, enlighten us.
next prev parent reply other threads:[~2013-12-19 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 1:29 [PATCH] closures: move to lib/ Kent Overstreet
2013-12-19 1:34 ` Dan Williams
2013-12-19 1:37 ` Kent Overstreet
2013-12-19 12:05 ` Christoph Hellwig
2013-12-19 12:18 ` Kent Overstreet [this message]
2013-12-19 12:19 ` Christoph Hellwig
2013-12-19 12:21 ` Kent Overstreet
2013-12-22 19:30 ` Christoph Hellwig
2013-12-19 15:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219121830.GA25385@kmo-pixel \
--to=kmo@daterainc.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.