From: David Cohen <david.a.cohen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: pavel-+ZI9xUNit7I@public.gmane.org,
rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
santosh.shilimkar-l0cyMroinI0@public.gmane.org
Subject: Re: [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart
Date: Wed, 18 Dec 2013 21:12:29 -0800 [thread overview]
Message-ID: <20131219051229.GA27854@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <1386911905-2366-1-git-send-email-david.a.cohen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Thu, Dec 12, 2013 at 09:18:22PM -0800, David Cohen wrote:
> Hi,
>
> These patches are proposal to extend the lack of #ifdef checks on PM callback
> to its implementation too.
>
> Currently SET_*_PM_OPS() macros make #ifdefs checks not necessary when setting
> the callback to PM ops, but the callbacks implementation don't see same
> benefit.
>
> This RFC Solves a problem reported by Santosh on xhci-plat.c driver due to
> wrong #ifdef checks:
>
> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
>
> But instead of fixing the #ifdefs, we remove the need for it :)
Ping. Comments here? :)
Br, David
>
> Br, David Cohen
>
> ---
> David Cohen (2):
> pm: make PM macros more smart
> usb/xhci: implement proper static inline stubs when !CONFIG_PM
>
> Santosh Shilimkar (1):
> usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP
>
> drivers/usb/host/xhci-plat.c | 7 +------
> drivers/usb/host/xhci.h | 6 ++++--
> include/linux/pm.h | 11 +++++++++--
> 3 files changed, 14 insertions(+), 10 deletions(-)
>
> --
> 1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Cohen <david.a.cohen@linux.intel.com>
To: pavel@ucw.cz, rjw@rjwysocki.net, len.brown@intel.com,
sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, santosh.shilimkar@ti.com
Subject: Re: [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart
Date: Wed, 18 Dec 2013 21:12:29 -0800 [thread overview]
Message-ID: <20131219051229.GA27854@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <1386911905-2366-1-git-send-email-david.a.cohen@linux.intel.com>
On Thu, Dec 12, 2013 at 09:18:22PM -0800, David Cohen wrote:
> Hi,
>
> These patches are proposal to extend the lack of #ifdef checks on PM callback
> to its implementation too.
>
> Currently SET_*_PM_OPS() macros make #ifdefs checks not necessary when setting
> the callback to PM ops, but the callbacks implementation don't see same
> benefit.
>
> This RFC Solves a problem reported by Santosh on xhci-plat.c driver due to
> wrong #ifdef checks:
>
> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
>
> But instead of fixing the #ifdefs, we remove the need for it :)
Ping. Comments here? :)
Br, David
>
> Br, David Cohen
>
> ---
> David Cohen (2):
> pm: make PM macros more smart
> usb/xhci: implement proper static inline stubs when !CONFIG_PM
>
> Santosh Shilimkar (1):
> usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP
>
> drivers/usb/host/xhci-plat.c | 7 +------
> drivers/usb/host/xhci.h | 6 ++++--
> include/linux/pm.h | 11 +++++++++--
> 3 files changed, 14 insertions(+), 10 deletions(-)
>
> --
> 1.8.4.2
next prev parent reply other threads:[~2013-12-19 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 5:18 [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart David Cohen
2013-12-13 5:18 ` [RFC/PATCH 1/3] pm: make PM " David Cohen
2013-12-15 17:51 ` Pavel Machek
2013-12-15 19:25 ` David Cohen
2013-12-20 19:55 ` Pavel Machek
2013-12-20 20:23 ` David Cohen
2014-01-14 22:42 ` David Cohen
2014-01-22 21:21 ` David Cohen
2013-12-13 5:18 ` [RFC/PATCH 2/3] usb/xhci: implement proper static inline stubs when !CONFIG_PM David Cohen
2013-12-13 5:18 ` [RFC/PATCH 3/3] usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP David Cohen
2013-12-13 8:19 ` Ulf Hansson
2013-12-13 15:46 ` David Cohen
[not found] ` <1386911905-2366-1-git-send-email-david.a.cohen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-12-19 5:12 ` David Cohen [this message]
2013-12-19 5:12 ` [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219051229.GA27854@psi-dev26.jf.intel.com \
--to=david.a.cohen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \
--cc=sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.