From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: tglx@linutronix.de, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH] irq-renesas-irqc: simplify irq_set_type() method
Date: Thu, 19 Dec 2013 08:24:56 +0000 [thread overview]
Message-ID: <20131219082453.GA12239@verge.net.au> (raw)
In-Reply-To: <201312140309.31407.sergei.shtylyov@cogentembedded.com>
On Sat, Dec 14, 2013 at 03:09:31AM +0300, Sergei Shtylyov wrote:
> Value 0 of the sense selection field of CONFIG_n register means "disable event
> detection" and serves in irqc_sense[] for marking the invalid values of the IRQ
> type (by just omitting initializers). There is no need for INTC_IRQ_SENSE_VALID
> and hence INTC_IRQ_SENSE() as all field values matching to the valid IRQ types
> are non-zero anyway.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Magnus, could you review this?
>
> ---
> The patch is against the 'irq/core' branch of the 'tip.git' repo.
>
> drivers/irqchip/irq-renesas-irqc.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> Index: renesas/drivers/irqchip/irq-renesas-irqc.c
> =================================> --- renesas.orig/drivers/irqchip/irq-renesas-irqc.c
> +++ renesas/drivers/irqchip/irq-renesas-irqc.c
> @@ -81,15 +81,12 @@ static void irqc_irq_disable(struct irq_
> iowrite32(BIT(hw_irq), p->cpu_int_base + IRQC_EN_STS);
> }
>
> -#define INTC_IRQ_SENSE_VALID 0x10
> -#define INTC_IRQ_SENSE(x) (x + INTC_IRQ_SENSE_VALID)
> -
> static unsigned char irqc_sense[IRQ_TYPE_SENSE_MASK + 1] = {
> - [IRQ_TYPE_LEVEL_LOW] = INTC_IRQ_SENSE(0x01),
> - [IRQ_TYPE_LEVEL_HIGH] = INTC_IRQ_SENSE(0x02),
> - [IRQ_TYPE_EDGE_FALLING] = INTC_IRQ_SENSE(0x04), /* Synchronous */
> - [IRQ_TYPE_EDGE_RISING] = INTC_IRQ_SENSE(0x08), /* Synchronous */
> - [IRQ_TYPE_EDGE_BOTH] = INTC_IRQ_SENSE(0x0c), /* Synchronous */
> + [IRQ_TYPE_LEVEL_LOW] = 0x01,
> + [IRQ_TYPE_LEVEL_HIGH] = 0x02,
> + [IRQ_TYPE_EDGE_FALLING] = 0x04, /* Synchronous */
> + [IRQ_TYPE_EDGE_RISING] = 0x08, /* Synchronous */
> + [IRQ_TYPE_EDGE_BOTH] = 0x0c, /* Synchronous */
> };
>
> static int irqc_irq_set_type(struct irq_data *d, unsigned int type)
> @@ -101,12 +98,12 @@ static int irqc_irq_set_type(struct irq_
>
> irqc_dbg(&p->irq[hw_irq], "sense");
>
> - if (!(value & INTC_IRQ_SENSE_VALID))
> + if (!value)
> return -EINVAL;
>
> tmp = ioread32(p->iomem + IRQC_CONFIG(hw_irq));
> tmp &= ~0x3f;
> - tmp |= value ^ INTC_IRQ_SENSE_VALID;
> + tmp |= value;
> iowrite32(tmp, p->iomem + IRQC_CONFIG(hw_irq));
> return 0;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: tglx@linutronix.de, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH] irq-renesas-irqc: simplify irq_set_type() method
Date: Thu, 19 Dec 2013 17:24:56 +0900 [thread overview]
Message-ID: <20131219082453.GA12239@verge.net.au> (raw)
In-Reply-To: <201312140309.31407.sergei.shtylyov@cogentembedded.com>
On Sat, Dec 14, 2013 at 03:09:31AM +0300, Sergei Shtylyov wrote:
> Value 0 of the sense selection field of CONFIG_n register means "disable event
> detection" and serves in irqc_sense[] for marking the invalid values of the IRQ
> type (by just omitting initializers). There is no need for INTC_IRQ_SENSE_VALID
> and hence INTC_IRQ_SENSE() as all field values matching to the valid IRQ types
> are non-zero anyway.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Magnus, could you review this?
>
> ---
> The patch is against the 'irq/core' branch of the 'tip.git' repo.
>
> drivers/irqchip/irq-renesas-irqc.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> Index: renesas/drivers/irqchip/irq-renesas-irqc.c
> ===================================================================
> --- renesas.orig/drivers/irqchip/irq-renesas-irqc.c
> +++ renesas/drivers/irqchip/irq-renesas-irqc.c
> @@ -81,15 +81,12 @@ static void irqc_irq_disable(struct irq_
> iowrite32(BIT(hw_irq), p->cpu_int_base + IRQC_EN_STS);
> }
>
> -#define INTC_IRQ_SENSE_VALID 0x10
> -#define INTC_IRQ_SENSE(x) (x + INTC_IRQ_SENSE_VALID)
> -
> static unsigned char irqc_sense[IRQ_TYPE_SENSE_MASK + 1] = {
> - [IRQ_TYPE_LEVEL_LOW] = INTC_IRQ_SENSE(0x01),
> - [IRQ_TYPE_LEVEL_HIGH] = INTC_IRQ_SENSE(0x02),
> - [IRQ_TYPE_EDGE_FALLING] = INTC_IRQ_SENSE(0x04), /* Synchronous */
> - [IRQ_TYPE_EDGE_RISING] = INTC_IRQ_SENSE(0x08), /* Synchronous */
> - [IRQ_TYPE_EDGE_BOTH] = INTC_IRQ_SENSE(0x0c), /* Synchronous */
> + [IRQ_TYPE_LEVEL_LOW] = 0x01,
> + [IRQ_TYPE_LEVEL_HIGH] = 0x02,
> + [IRQ_TYPE_EDGE_FALLING] = 0x04, /* Synchronous */
> + [IRQ_TYPE_EDGE_RISING] = 0x08, /* Synchronous */
> + [IRQ_TYPE_EDGE_BOTH] = 0x0c, /* Synchronous */
> };
>
> static int irqc_irq_set_type(struct irq_data *d, unsigned int type)
> @@ -101,12 +98,12 @@ static int irqc_irq_set_type(struct irq_
>
> irqc_dbg(&p->irq[hw_irq], "sense");
>
> - if (!(value & INTC_IRQ_SENSE_VALID))
> + if (!value)
> return -EINVAL;
>
> tmp = ioread32(p->iomem + IRQC_CONFIG(hw_irq));
> tmp &= ~0x3f;
> - tmp |= value ^ INTC_IRQ_SENSE_VALID;
> + tmp |= value;
> iowrite32(tmp, p->iomem + IRQC_CONFIG(hw_irq));
> return 0;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-12-19 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 23:09 [PATCH] irq-renesas-irqc: simplify irq_set_type() method Sergei Shtylyov
2013-12-14 0:09 ` Sergei Shtylyov
2013-12-19 8:24 ` Simon Horman [this message]
2013-12-19 8:24 ` Simon Horman
2013-12-19 9:53 ` Magnus Damm
2013-12-19 9:53 ` Magnus Damm
2013-12-23 0:27 ` Simon Horman
2013-12-23 0:27 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219082453.GA12239@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.