All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
To: Rob Herring <robherring2@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Dmitry Krivoschekov <dkrivoschokov@dev.rtsoft.ru>,
	Alexey Lugovskoy <lugovskoy@dev.rtsoft.ru>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	linux-kernel@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: commit e38c0a1f breaks powerpc boards with uli1575 chip
Date: Thu, 19 Dec 2013 08:42:00 +0400	[thread overview]
Message-ID: <201312190842.02702@blacky.localdomain> (raw)
In-Reply-To: <52B1EC15.5070606@gmail.com>

> Reverting would break Tegra PCIe, but you should not have to change the
> DT either. So we need a solution.
>
> Is this something like this sufficient to fix it?
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 4b9317b..378aebd 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -74,7 +74,7 @@ static u64 of_bus_default_map(__be32 *addr, const
> __be32 *range,
>          * mapping doesn't specify a physical address. Rather, the
> address * specifies an identifier that must match exactly.
>          */
> -       if (na > 2 && memcmp(range, addr, na * 4) != 0)
> +       if (na > 2 && memcmp(range, addr, (na - 2) * 4) != 0)
>                 return OF_BAD_ADDR;
>
>         if (da < cp || da >= (cp + s))


No, this does not help.

I've dumped the actual content of 'range' and 'addr' at the failure point 
(i.e. ar point that returns error with e38c0a1f but passes without 
e38c0a1f ):

OF: default map, cp=0, s=10000, da=70
range:  01 00 00 00 00 00 00 00 00 00 00 00
 addr:  00 00 00 00 00 00 00 00 00 00 00 70

Nikita

WARNING: multiple messages have this Message-ID (diff)
From: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
To: Rob Herring <robherring2@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Grant Likely <grant.likely@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Kumar Gala <galak@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Alexey Lugovskoy <lugovskoy@dev.rtsoft.ru>,
	Dmitry Krivoschekov <dkrivoschokov@dev.rtsoft.ru>
Subject: Re: commit e38c0a1f breaks powerpc boards with uli1575 chip
Date: Thu, 19 Dec 2013 08:42:00 +0400	[thread overview]
Message-ID: <201312190842.02702@blacky.localdomain> (raw)
In-Reply-To: <52B1EC15.5070606@gmail.com>

> Reverting would break Tegra PCIe, but you should not have to change the
> DT either. So we need a solution.
>
> Is this something like this sufficient to fix it?
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 4b9317b..378aebd 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -74,7 +74,7 @@ static u64 of_bus_default_map(__be32 *addr, const
> __be32 *range,
>          * mapping doesn't specify a physical address. Rather, the
> address * specifies an identifier that must match exactly.
>          */
> -       if (na > 2 && memcmp(range, addr, na * 4) != 0)
> +       if (na > 2 && memcmp(range, addr, (na - 2) * 4) != 0)
>                 return OF_BAD_ADDR;
>
>         if (da < cp || da >= (cp + s))


No, this does not help.

I've dumped the actual content of 'range' and 'addr' at the failure point 
(i.e. ar point that returns error with e38c0a1f but passes without 
e38c0a1f ):

OF: default map, cp=0, s=10000, da=70
range:  01 00 00 00 00 00 00 00 00 00 00 00
 addr:  00 00 00 00 00 00 00 00 00 00 00 70

Nikita

  reply	other threads:[~2013-12-19  4:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  7:35 commit e38c0a1f breaks powerpc boards with uli1575 chip Nikita Yushchenko
2013-12-17  7:35 ` Nikita Yushchenko
2013-12-18 18:40 ` Rob Herring
2013-12-18 18:40   ` Rob Herring
2013-12-19  4:42   ` Nikita Yushchenko [this message]
2013-12-19  4:42     ` Nikita Yushchenko
2013-12-30  3:13     ` Benjamin Herrenschmidt
2013-12-30  3:13       ` Benjamin Herrenschmidt
2013-12-30  3:13       ` Benjamin Herrenschmidt
2014-01-03  0:04       ` Scott Wood
2014-01-03  0:04         ` Scott Wood
2014-01-03  0:04         ` Scott Wood
2013-12-19 14:24   ` Thierry Reding
2013-12-19 14:24     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312190842.02702@blacky.localdomain \
    --to=nyushchenko@dev.rtsoft.ru \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dkrivoschokov@dev.rtsoft.ru \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lugovskoy@dev.rtsoft.ru \
    --cc=robherring2@gmail.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.