All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: David Chen <tuxoko@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf config: ignore generated files in feature-checks
Date: Thu, 19 Dec 2013 16:46:42 +0100	[thread overview]
Message-ID: <20131219154642.GA24658@gmail.com> (raw)
In-Reply-To: <CAK1sfuYn1iLUHWwUTdm755D0YpuAcROsj5rp=4-Vg5qc57bFfw@mail.gmail.com>


* David Chen <tuxoko@gmail.com> wrote:

> Why not? They're generated files aren't they?

Yes, indeed, you are right, they should be included in the .gitignore.

> By the way, I just found out that test-* will be built depend on the
> detected features.
> Should I include them all?

Yes, that would have been my next observation :-)

I'd suggest that instead of enumerating them all in the .gitignore 
file we should change the naming of the feature check binaries to 
something like test-<xyz>.bin or so, so that a simple test-*.bin 
pattern will ignore all these generated binaries.

Thanks,

	Ingo

  reply	other threads:[~2013-12-19 15:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  8:29 [PATCH] perf config: ignore generated files in feature-checks Chunwei Chen
2013-12-19 11:58 ` Ingo Molnar
2013-12-19 13:37   ` David Chen
2013-12-19 15:46     ` Ingo Molnar [this message]
2013-12-19 17:02       ` David Chen
2013-12-19 17:10         ` Ingo Molnar
2013-12-20  4:16           ` Chunwei Chen
2013-12-20  8:40             ` Ingo Molnar
2013-12-20 16:34             ` Arnaldo Carvalho de Melo
2013-12-21  5:48               ` Chunwei Chen
2013-12-23 12:11                 ` Jiri Olsa
2014-01-12 18:37                 ` [tip:perf/core] perf config: Ignore " tip-bot for Chunwei Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131219154642.GA24658@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@infradead.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tuxoko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.