Re: [PATCH 04/10] ARM: tegra: Add Tegra124 eDP support

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On Thu, Dec 19, 2013 at 01:46:13PM -0700, Stephen Warren wrote:
> On 12/19/2013 09:06 AM, Thierry Reding wrote:
> 
> > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> 
> > +		sor@54540000 {
> > +			compatible = "nvidia,tegra124-sor";
> 
> I don't see a binding document for that compatible value anywhere in
> next-20131219, nor in your drm/for-next branch. Still, the DT
> content/schema is essentially identical to many others that already
> exist, so I won't block applying the series because of that. Please do
> write a binding document though!
> 
> > +		dpaux@545c0000 {
> > +			compatible = "nvidia,tegra124-dpaux";
> 
> Same comment.

The binding documentation for those nodes is part of the eDP patch
that's still awaiting internal review, that's why it hasn't appeared yet
in linux-next or my drm/for-next branch. I'm hoping that will happen any
day now, though.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]