From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: mjg59@srcf.ucam.org, msalter@redhat.com,
linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, leif.lindholm@linaro.org,
James.Bottomley@HansenPartnership.com, horms@verge.net.au,
bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com,
akpm@linux-foundation.org, mingo@kernel.org, vgoyal@redhat.com
Subject: Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data
Date: Sat, 21 Dec 2013 16:06:01 +0000 [thread overview]
Message-ID: <20131221160416.GD29501@console-pimps.org> (raw)
In-Reply-To: <1387533742-18018-10-git-send-email-dyoung@redhat.com>
On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote:
> @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void);
> extern void efi_setup_page_tables(void);
> extern void __init old_map_region(efi_memory_desc_t *md);
>
> +struct efi_setup_data {
> + u64 fw_vendor;
> + u64 runtime;
> + u64 tables;
> + u64 smbios;
> + u64 reserved[8];
> + efi_memory_desc_t map[0];
> +};
[...]
> +static void get_nr_runtime_map(void)
> +{
> + if (!efi_setup)
> + return;
> +
> + nr_efi_runtime_map = (efi_data_len - sizeof(struct efi_setup_data)) /
> + sizeof(efi_memory_desc_t);
> +}
Do we actually need the 'map' entry in efi_setup_data now that you're
passing it via efi_info (which is much better approach!)? Also, we don't
need the global nr_efi_runtime_map or efi_runtime_map variables now,
right?
--
Matt Fleming, Intel Open Source Technology Center
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com,
toshi.kani@hp.com, akpm@linux-foundation.org, mingo@kernel.org,
msalter@redhat.com, leif.lindholm@linaro.org
Subject: Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data
Date: Sat, 21 Dec 2013 16:06:01 +0000 [thread overview]
Message-ID: <20131221160416.GD29501@console-pimps.org> (raw)
In-Reply-To: <1387533742-18018-10-git-send-email-dyoung@redhat.com>
On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote:
> @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void);
> extern void efi_setup_page_tables(void);
> extern void __init old_map_region(efi_memory_desc_t *md);
>
> +struct efi_setup_data {
> + u64 fw_vendor;
> + u64 runtime;
> + u64 tables;
> + u64 smbios;
> + u64 reserved[8];
> + efi_memory_desc_t map[0];
> +};
[...]
> +static void get_nr_runtime_map(void)
> +{
> + if (!efi_setup)
> + return;
> +
> + nr_efi_runtime_map = (efi_data_len - sizeof(struct efi_setup_data)) /
> + sizeof(efi_memory_desc_t);
> +}
Do we actually need the 'map' entry in efi_setup_data now that you're
passing it via efi_info (which is much better approach!)? Also, we don't
need the global nr_efi_runtime_map or efi_runtime_map variables now,
right?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-12-21 16:06 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 10:02 [PATCH v7 00/12] kexec kernel efi runtime support Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 01/12] x86/mm: sparse warning fix for early_memremap Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 02/12] efi: Use early_memremap and early_memunmap to fix sparse warnings Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 03/12] efi: remove unused variables in __map_region Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 04/12] efi: add a wrapper function efi_map_region_fixed Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 05/12] efi: reserve boot service fix Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 06/12] efi: cleanup efi_enter_virtual_mode function Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 07/12] efi: export more efi table variable to sysfs Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 08/12] efi: export efi runtime memory mapping " Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-21 14:53 ` Matt Fleming
2013-12-21 14:53 ` Matt Fleming
2013-12-21 14:53 ` Matt Fleming
2013-12-23 2:06 ` Dave Young
2013-12-23 2:06 ` Dave Young
2013-12-23 2:06 ` Dave Young
2013-12-21 16:06 ` Matt Fleming [this message]
2013-12-21 16:06 ` Matt Fleming
2013-12-23 2:09 ` Dave Young
2013-12-23 2:09 ` Dave Young
2013-12-23 2:09 ` Dave Young
2013-12-23 6:09 ` Dave Young
2013-12-23 6:09 ` Dave Young
2013-12-23 6:09 ` Dave Young
2013-12-23 8:07 ` Matt Fleming
2013-12-23 8:07 ` Matt Fleming
2013-12-23 8:07 ` Matt Fleming
2013-12-25 3:12 ` Dave Young
2013-12-25 3:12 ` Dave Young
2013-12-25 3:12 ` Dave Young
2013-12-25 3:32 ` Dave Young
2013-12-25 3:32 ` Dave Young
2013-12-25 3:32 ` Dave Young
2013-12-29 13:05 ` Matt Fleming
2013-12-29 13:05 ` Matt Fleming
2013-12-29 13:05 ` Matt Fleming
2013-12-30 1:38 ` Dave Young
2013-12-30 1:38 ` Dave Young
2013-12-30 1:38 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 10/12] x86: add xloadflags bit for efi runtime support on kexec Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 11/12] x86: export x86 boot_params to sysfs Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` [PATCH v7 12/12] x86: reserve setup_data ranges late after parsing memmap cmdline Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 10:02 ` Dave Young
2013-12-20 18:01 ` [PATCH v7 00/12] kexec kernel efi runtime support Toshi Kani
2013-12-20 18:01 ` Toshi Kani
2013-12-20 18:01 ` Toshi Kani
2013-12-21 17:35 ` Matt Fleming
2013-12-21 17:35 ` Matt Fleming
2013-12-21 17:35 ` Matt Fleming
2013-12-22 21:27 ` Toshi Kani
2013-12-22 21:27 ` Toshi Kani
2013-12-22 21:27 ` Toshi Kani
2013-12-23 7:36 ` Matt Fleming
2013-12-23 7:36 ` Matt Fleming
2013-12-23 7:36 ` Matt Fleming
2013-12-24 20:31 ` Toshi Kani
2013-12-24 20:31 ` Toshi Kani
2013-12-24 20:31 ` Toshi Kani
2013-12-25 3:09 ` Dave Young
2013-12-25 3:09 ` Dave Young
2013-12-25 3:09 ` Dave Young
2013-12-23 2:32 ` Dave Young
2013-12-23 2:32 ` Dave Young
2013-12-23 2:32 ` Dave Young
2014-01-02 2:42 ` Dave Young
2014-01-02 2:42 ` Dave Young
2014-01-02 2:42 ` Dave Young
2014-01-02 10:35 ` Matt Fleming
2014-01-02 10:35 ` Matt Fleming
2014-01-02 10:35 ` Matt Fleming
2014-01-03 4:12 ` Dave Young
2014-01-03 4:12 ` Dave Young
2014-01-03 4:12 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131221160416.GD29501@console-pimps.org \
--to=matt@console-pimps.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=msalter@redhat.com \
--cc=toshi.kani@hp.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.