* [libnftables PATCH] build: properly handle --without-{xml,json}-parsing
@ 2013-12-23 9:14 Douglas Freed
2013-12-23 12:51 ` Pablo Neira Ayuso
2013-12-23 13:53 ` Arturo Borrero Gonzalez
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Freed @ 2013-12-23 9:14 UTC (permalink / raw)
To: netfilter-devel; +Cc: Douglas Freed
This patch fixes how --without-{xml,json}-parsing (and subsequently
--with-{xml,json}-parsing=no) is handled. Prior to this,
--without-{xml,json}-parsing actually resulted in libnftables being
built with that parsing enabled.
Signed-off-by: Douglas Freed <dwfreed@mtu.edu>
---
configure.ac | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index b023755..6219737 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,11 +16,9 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
dnl Dependencies
PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.0])
AC_ARG_WITH([xml-parsing],
- AS_HELP_STRING([--with-xml-parsing], [XML parsing support]),
- [with_xml_parsing="yes"], [with_xml_parsing="no"])
+ AS_HELP_STRING([--with-xml-parsing], [XML parsing support]))
AC_ARG_WITH([json-parsing],
- AS_HELP_STRING([--with-json-parsing], [JSON parsing support]),
- [with_json_parsing="yes"], [with_json_parsing="no"])
+ AS_HELP_STRING([--with-json-parsing], [JSON parsing support]))
AS_IF([test "x$with_xml_parsing" = "xyes"], [
PKG_CHECK_MODULES([LIBXML], [mxml >= 2.6])
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [libnftables PATCH] build: properly handle --without-{xml,json}-parsing
2013-12-23 9:14 [libnftables PATCH] build: properly handle --without-{xml,json}-parsing Douglas Freed
@ 2013-12-23 12:51 ` Pablo Neira Ayuso
2013-12-23 13:53 ` Arturo Borrero Gonzalez
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2013-12-23 12:51 UTC (permalink / raw)
To: Douglas Freed; +Cc: netfilter-devel
On Mon, Dec 23, 2013 at 09:14:57AM +0000, Douglas Freed wrote:
> This patch fixes how --without-{xml,json}-parsing (and subsequently
> --with-{xml,json}-parsing=no) is handled. Prior to this,
> --without-{xml,json}-parsing actually resulted in libnftables being
> built with that parsing enabled.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [libnftables PATCH] build: properly handle --without-{xml,json}-parsing
2013-12-23 9:14 [libnftables PATCH] build: properly handle --without-{xml,json}-parsing Douglas Freed
2013-12-23 12:51 ` Pablo Neira Ayuso
@ 2013-12-23 13:53 ` Arturo Borrero Gonzalez
1 sibling, 0 replies; 3+ messages in thread
From: Arturo Borrero Gonzalez @ 2013-12-23 13:53 UTC (permalink / raw)
To: Douglas Freed; +Cc: Netfilter Development Mailing list
On 23 December 2013 10:14, Douglas Freed <dwfreed@mtu.edu> wrote:
> This patch fixes how --without-{xml,json}-parsing (and subsequently
> --with-{xml,json}-parsing=no) is handled. Prior to this,
> --without-{xml,json}-parsing actually resulted in libnftables being
> built with that parsing enabled.
>
> Signed-off-by: Douglas Freed <dwfreed@mtu.edu>
> ---
> configure.ac | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Hi,
I've tested your patch, and seems fine to me.
Thanks.
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-23 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-23 9:14 [libnftables PATCH] build: properly handle --without-{xml,json}-parsing Douglas Freed
2013-12-23 12:51 ` Pablo Neira Ayuso
2013-12-23 13:53 ` Arturo Borrero Gonzalez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.