From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/9] usb: gadget: s3c-hsotg: enable build for other platforms
Date: Mon, 23 Dec 2013 11:57:12 -0500 [thread overview]
Message-ID: <20131223165712.GB9826@beef> (raw)
In-Reply-To: <1831289.ILfyABDFji@amdc1227>
On Mon, Dec 23, 2013 at 05:30:41PM +0100, Tomasz Figa wrote:
> On Monday 23 of December 2013 10:25:57 Felipe Balbi wrote:
> > On Thu, Dec 19, 2013 at 09:23:04AM -0500, Matt Porter wrote:
> > > Remove unused Samsung-specific machine include and Kconfig
> > > dependency on S3C.
> > >
> > > Signed-off-by: Matt Porter <mporter@linaro.org>
> > > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > > ---
> > > drivers/usb/gadget/Kconfig | 7 +++----
> > > drivers/usb/gadget/s3c-hsotg.c | 2 --
> > > 2 files changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > > index a91e642..181e760 100644
> > > --- a/drivers/usb/gadget/Kconfig
> > > +++ b/drivers/usb/gadget/Kconfig
> > > @@ -294,11 +294,10 @@ config USB_PXA27X
> > > gadget drivers to also be dynamically linked.
> > >
> > > config USB_S3C_HSOTG
> > > - tristate "S3C HS/OtG USB Device controller"
> > > - depends on S3C_DEV_USB_HSOTG
> > > + tristate "Designware/S3C HS/OtG USB Device controller"
> >
> > causes build failure in x86. Sorry dropping from my queue.
>
> Maybe depends on ARM would be a good enough stepping stone?
Yes, we could then move from readsl/writesl to ioread_read/io_write_rep
next time around as that fixes the portability issue.
Felipe, since depending on ARM is a trivial fix for this, can you take
an updated version at this point?
-Matt
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Christian Daudt <bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org>,
Paul Zimmerman <paulz-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
Kamil Debski <k.debski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Kyungmin Park
<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Dinh Nguyen <dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Linux USB List
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ARM Kernel List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linaro Patches <patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v8 3/9] usb: gadget: s3c-hsotg: enable build for other platforms
Date: Mon, 23 Dec 2013 11:57:12 -0500 [thread overview]
Message-ID: <20131223165712.GB9826@beef> (raw)
In-Reply-To: <1831289.ILfyABDFji@amdc1227>
On Mon, Dec 23, 2013 at 05:30:41PM +0100, Tomasz Figa wrote:
> On Monday 23 of December 2013 10:25:57 Felipe Balbi wrote:
> > On Thu, Dec 19, 2013 at 09:23:04AM -0500, Matt Porter wrote:
> > > Remove unused Samsung-specific machine include and Kconfig
> > > dependency on S3C.
> > >
> > > Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > Reviewed-by: Markus Mayer <markus.mayer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > Reviewed-by: Tim Kryger <tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > ---
> > > drivers/usb/gadget/Kconfig | 7 +++----
> > > drivers/usb/gadget/s3c-hsotg.c | 2 --
> > > 2 files changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > > index a91e642..181e760 100644
> > > --- a/drivers/usb/gadget/Kconfig
> > > +++ b/drivers/usb/gadget/Kconfig
> > > @@ -294,11 +294,10 @@ config USB_PXA27X
> > > gadget drivers to also be dynamically linked.
> > >
> > > config USB_S3C_HSOTG
> > > - tristate "S3C HS/OtG USB Device controller"
> > > - depends on S3C_DEV_USB_HSOTG
> > > + tristate "Designware/S3C HS/OtG USB Device controller"
> >
> > causes build failure in x86. Sorry dropping from my queue.
>
> Maybe depends on ARM would be a good enough stepping stone?
Yes, we could then move from readsl/writesl to ioread_read/io_write_rep
next time around as that fixes the portability issue.
Felipe, since depending on ARM is a trivial fix for this, can you take
an updated version at this point?
-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@linaro.org>
To: Tomasz Figa <t.figa@samsung.com>
Cc: balbi@ti.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Christian Daudt <bcm@fixthebug.org>,
Paul Zimmerman <paulz@synopsys.com>,
Kamil Debski <k.debski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Dinh Nguyen <dinh.linux@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Linux USB List <linux-usb@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH v8 3/9] usb: gadget: s3c-hsotg: enable build for other platforms
Date: Mon, 23 Dec 2013 11:57:12 -0500 [thread overview]
Message-ID: <20131223165712.GB9826@beef> (raw)
In-Reply-To: <1831289.ILfyABDFji@amdc1227>
On Mon, Dec 23, 2013 at 05:30:41PM +0100, Tomasz Figa wrote:
> On Monday 23 of December 2013 10:25:57 Felipe Balbi wrote:
> > On Thu, Dec 19, 2013 at 09:23:04AM -0500, Matt Porter wrote:
> > > Remove unused Samsung-specific machine include and Kconfig
> > > dependency on S3C.
> > >
> > > Signed-off-by: Matt Porter <mporter@linaro.org>
> > > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > > ---
> > > drivers/usb/gadget/Kconfig | 7 +++----
> > > drivers/usb/gadget/s3c-hsotg.c | 2 --
> > > 2 files changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > > index a91e642..181e760 100644
> > > --- a/drivers/usb/gadget/Kconfig
> > > +++ b/drivers/usb/gadget/Kconfig
> > > @@ -294,11 +294,10 @@ config USB_PXA27X
> > > gadget drivers to also be dynamically linked.
> > >
> > > config USB_S3C_HSOTG
> > > - tristate "S3C HS/OtG USB Device controller"
> > > - depends on S3C_DEV_USB_HSOTG
> > > + tristate "Designware/S3C HS/OtG USB Device controller"
> >
> > causes build failure in x86. Sorry dropping from my queue.
>
> Maybe depends on ARM would be a good enough stepping stone?
Yes, we could then move from readsl/writesl to ioread_read/io_write_rep
next time around as that fixes the portability issue.
Felipe, since depending on ARM is a trivial fix for this, can you take
an updated version at this point?
-Matt
next prev parent reply other threads:[~2013-12-23 16:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 14:23 [PATCH v8 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-23 16:25 ` Felipe Balbi
2013-12-23 16:25 ` Felipe Balbi
2013-12-23 16:25 ` Felipe Balbi
2013-12-23 16:30 ` Tomasz Figa
2013-12-23 16:30 ` Tomasz Figa
2013-12-23 16:30 ` Tomasz Figa
2013-12-23 16:57 ` Matt Porter [this message]
2013-12-23 16:57 ` Matt Porter
2013-12-23 16:57 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-12-19 14:23 ` [PATCH v8 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 " Matt Porter
2013-12-19 14:23 ` [PATCH v8 5/9] usb: gadget: s3c-hsotg: enable generic phy support Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-19 14:23 ` [PATCH v8 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-12-19 14:23 ` Matt Porter
2013-12-23 8:16 ` Christian Daudt
2013-12-23 8:16 ` Christian Daudt
2013-12-23 20:36 ` Felipe Balbi
2013-12-23 20:36 ` Felipe Balbi
2013-12-23 20:36 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223165712.GB9826@beef \
--to=mporter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.