All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	rostedt@goodmis.org, John Kacur <jkacur@redhat.com>
Subject: 3.12.6-rt9 build failure
Date: Tue, 24 Dec 2013 16:15:26 +0100	[thread overview]
Message-ID: <20131224151526.GA19732@opentech.at> (raw)
In-Reply-To: <20131223225017.GA8623@linutronix.de>

Hi !

in 3.12.6-rt9:
 patch timers-do-not-raise-softirq-unconditionally.patch
 fails compile test for: 
  CONFIG_PREEMPT_RT_BASE=y
  # CONFIG_PREEMPT_RT_FULL is not set
 full config with seed 0xE3A03BD0.

<snip>
  CC      kernel/timer.o
kernel/timer.c: In function 'run_local_timers':
kernel/timer.c:1463: error: implicit declaration of function 'spin_do_trylock'
kernel/timer.c:1474: error: implicit declaration of function 'rt_spin_unlock_after_trylock_in_irq'
make[1]: *** [kernel/timer.o] Error 1
make: *** [kernel] Error 2

 ... RT specific API not ifdef'ed, a brute force ifdefification "fix" below

 But what this might actually point to is that testing of patches with RT off 
 (and other configs ?) is being neglected a bit. rt6 also had a problem (seed
 was 0xBE96A834 file:kernel/rtmutex.c:__mutex_lock_check_stamp:1007)

 maybe a set of minimum test-configs should be defined to atleast catch 
 build-failurs. 

thx!
hofrat

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
 kernel/timer.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/kernel/timer.c b/kernel/timer.c
index 46467be..88951cb 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1452,9 +1452,13 @@ static void run_timer_softirq(struct softirq_action *h)
  */
 void run_local_timers(void)
 {
+#ifdef CONFIG_PREEMPT_RT_FULL
 	struct tvec_base *base = __this_cpu_read(tvec_bases);
+#endif
 
 	hrtimer_run_queues();
+
+#ifdef CONFIG_PREEMPT_RT_FULL
 	/*
 	 * We can access this lockless as we are in the timer
 	 * interrupt. If there are no timers queued, nothing to do in
@@ -1472,7 +1476,9 @@ void run_local_timers(void)
 		raise_softirq(TIMER_SOFTIRQ);
 out:
 	rt_spin_unlock_after_trylock_in_irq(&base->lock);

  reply	other threads:[~2013-12-24 15:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23 22:50 [ANNOUNCE] 3.12.6-rt9 Sebastian Andrzej Siewior
2013-12-24 15:15 ` Nicholas Mc Guire [this message]
2013-12-24 15:47 ` Mike Galbraith
2013-12-24 16:39   ` Pavel Vasilyev
2013-12-25  3:24     ` Mike Galbraith
2013-12-25  3:24       ` Mike Galbraith
2014-01-17 17:00   ` Sebastian Andrzej Siewior
2014-01-17 17:00     ` Sebastian Andrzej Siewior
2014-01-18  3:15     ` Mike Galbraith
2014-01-21  2:17       ` Steven Rostedt
2014-01-21  6:39         ` Muli Baron
2014-01-21 15:40           ` Joe Korty
2014-01-22 21:27         ` Joakim Hernberg
2014-01-24 11:19         ` Sebastian Andrzej Siewior
2013-12-27 20:00 ` Nicholas Mc Guire
2013-12-28  3:30   ` Mike Galbraith
2013-12-28  3:48     ` Mike Galbraith
2013-12-28  7:43       ` Nicholas Mc Guire
2013-12-28 13:57         ` Mike Galbraith
2013-12-28  4:33     ` Mike Galbraith
2014-01-11 20:25   ` Joakim Hernberg
2014-01-17 16:10   ` Sebastian Andrzej Siewior
2014-01-19 20:54   ` Fernando Lopez-Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131224151526.GA19732@opentech.at \
    --to=der.herr@hofr.at \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.