From: Joakim Hernberg <jbh@alchemy.lu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mike Galbraith <bitbucket@online.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
John Kacur <jkacur@redhat.com>
Subject: Re: [ANNOUNCE] 3.12.6-rt9
Date: Wed, 22 Jan 2014 22:27:01 +0100 [thread overview]
Message-ID: <20140122222701.4c44b08d@tor.valhalla.alchemy.lu> (raw)
In-Reply-To: <20140120211736.0c97418a@gandalf.local.home>
On Mon, 20 Jan 2014 21:17:36 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> I happen to have a i7 box to test on, and sure enough, the latest
> 3.12-rt locks up on boot and reverting the
> timers-do-not-raise-softirq-unconditionally.patch, it boots fine.
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/kernel/timer.c b/kernel/timer.c
> index 46467be..8212c10 100644
> --- a/kernel/timer.c
> +++ b/kernel/timer.c
> @@ -1464,13 +1464,11 @@ void run_local_timers(void)
> raise_softirq(TIMER_SOFTIRQ);
> return;
> }
> - if (!base->active_timers)
> - goto out;
>
> /* Check whether the next pending timer has expired */
> if (time_before_eq(base->next_timer, jiffies))
> raise_softirq(TIMER_SOFTIRQ);
> -out:
> +
> rt_spin_unlock_after_trylock_in_irq(&base->lock);
>
> }
This fixes the problem on my i7-2600k.
--
Joakim
next prev parent reply other threads:[~2014-01-22 21:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 22:50 [ANNOUNCE] 3.12.6-rt9 Sebastian Andrzej Siewior
2013-12-24 15:15 ` 3.12.6-rt9 build failure Nicholas Mc Guire
2013-12-24 15:47 ` [ANNOUNCE] 3.12.6-rt9 Mike Galbraith
2013-12-24 16:39 ` Pavel Vasilyev
2013-12-25 3:24 ` Mike Galbraith
2013-12-25 3:24 ` Mike Galbraith
2014-01-17 17:00 ` Sebastian Andrzej Siewior
2014-01-17 17:00 ` Sebastian Andrzej Siewior
2014-01-18 3:15 ` Mike Galbraith
2014-01-21 2:17 ` Steven Rostedt
2014-01-21 6:39 ` Muli Baron
2014-01-21 15:40 ` Joe Korty
2014-01-22 21:27 ` Joakim Hernberg [this message]
2014-01-24 11:19 ` Sebastian Andrzej Siewior
2013-12-27 20:00 ` Nicholas Mc Guire
2013-12-28 3:30 ` Mike Galbraith
2013-12-28 3:48 ` Mike Galbraith
2013-12-28 7:43 ` Nicholas Mc Guire
2013-12-28 13:57 ` Mike Galbraith
2013-12-28 4:33 ` Mike Galbraith
2014-01-11 20:25 ` Joakim Hernberg
2014-01-17 16:10 ` Sebastian Andrzej Siewior
2014-01-19 20:54 ` Fernando Lopez-Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122222701.4c44b08d@tor.valhalla.alchemy.lu \
--to=jbh@alchemy.lu \
--cc=bigeasy@linutronix.de \
--cc=bitbucket@online.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.