From: Theodore Ts'o <tytso@mit.edu>
To: Phillip Susi <psusi@ubuntu.com>
Cc: ttytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/4] e2image: perform in-place move
Date: Wed, 25 Dec 2013 23:48:57 -0500 [thread overview]
Message-ID: <20131226044857.GA13533@thunk.org> (raw)
In-Reply-To: <20131225045826.GC13142@thunk.org>
On Tue, Dec 24, 2013 at 11:58:26PM -0500, Theodore Ts'o wrote:
> On Mon, Dec 16, 2013 at 11:33:19AM -0500, Phillip Susi wrote:
> > If given at least one offset and only one file, assume source
> > and dest are the same, and do an in place move.
> >
> > Signed-off-by: Phillip Susi <psusi@ubuntu.com>
>
> Thanks, applied.
Sigh, I've had to revert this change since it is causing test
failures. **Please** run the regression test suite before you submit
patches.
- Ted
Contents of i_e2image.failed:
e2image -r i_e2image/image1024.orig _image.raw
e2image 1.42.8 (20-Jun-2013)
e2image -Q i_e2image/image1024.orig _image.qcow2
e2image 1.42.8 (20-Jun-2013)
e2image -r _image.qcow2 _image.qcow2.raw
e2image 1.42.8 (20-Jun-2013)
e2image -r i_e2image/image2048.orig _image.raw
e2image 1.42.8 (20-Jun-2013)
e2image -Q i_e2image/image2048.orig _image.qcow2
e2image 1.42.8 (20-Jun-2013)
e2image -r _image.qcow2 _image.qcow2.raw
e2image 1.42.8 (20-Jun-2013)
e2image -r i_e2image/image4096.orig _image.raw
e2image 1.42.8 (20-Jun-2013)
e2image -Q i_e2image/image4096.orig _image.qcow2
e2image 1.42.8 (20-Jun-2013)
e2image -r _image.qcow2 _image.qcow2.raw
e2image 1.42.8 (20-Jun-2013)
md5sums:
i_e2image/image1024.orig
d34914e0da07bdae80ab02288118fae2 image1024.orig
bbef4e50d7237546c7d9c521d3df5b68 _image.raw
1d4eb39452bed097dcd2c5bcd57180e6 _image.qcow2
bbef4e50d7237546c7d9c521d3df5b68 _image.qcow2.raw
i_e2image/image2048.orig
aa9f702de181188f2a6d2c5158686c09 image2048.orig
e097e571c809ec5418f060e2a2ec1737 _image.raw
52dba396b0fc338b99defcb086058d80 _image.qcow2
e097e571c809ec5418f060e2a2ec1737 _image.qcow2.raw
i_e2image/image4096.orig
1d3e7f15b2ce9ca07aa23c32951c5176 image4096.orig
ebaddd9f5a62610d789adbbec4ee7f46 _image.raw
a72165eaffb6900889108fbd05002822 _image.qcow2
ebaddd9f5a62610d789adbbec4ee7f46 _image.qcow2.raw
8,10c8,10
< e6f8410d0690ef551bee0c2c0c642d8c _image.raw
< dbbd9aa97c6c946b9122586bbd2a325a _image.qcow2
< e6f8410d0690ef551bee0c2c0c642d8c _image.qcow2.raw
---
> e097e571c809ec5418f060e2a2ec1737 _image.raw
> 52dba396b0fc338b99defcb086058d80 _image.qcow2
> e097e571c809ec5418f060e2a2ec1737 _image.qcow2.raw
13,15c13,15
< 734119dd8f240a33704139f8cdd8127c _image.raw
< 85fdbf5a8451b24b36ab82a02196deb9 _image.qcow2
< 734119dd8f240a33704139f8cdd8127c _image.qcow2.raw
---
> ebaddd9f5a62610d789adbbec4ee7f46 _image.raw
> a72165eaffb6900889108fbd05002822 _image.qcow2
> ebaddd9f5a62610d789adbbec4ee7f46 _image.qcow2.raw
next prev parent reply other threads:[~2013-12-26 4:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 15:56 [PATCH 0/4] Add handy fs move features Phillip Susi
2013-10-08 15:56 ` [PATCH 1/4] e2image: add offset switches Phillip Susi
2013-12-16 4:32 ` Theodore Ts'o
2013-12-16 16:30 ` Phillip Susi
2013-12-16 16:32 ` Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
2013-10-08 15:56 ` [PATCH 2/4] e2image: perform in-place move Phillip Susi
2013-12-16 4:33 ` Theodore Ts'o
2013-12-16 16:30 ` Phillip Susi
2013-12-16 16:33 ` Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
2013-12-26 4:48 ` Theodore Ts'o [this message]
2013-12-26 5:24 ` Theodore Ts'o
2013-10-08 15:56 ` [PATCH 3/4] e2image: add progress indicator Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
2013-10-08 15:56 ` [PATCH 4/4] e2image: handle SIGINT safely Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226044857.GA13533@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=psusi@ubuntu.com \
--cc=ttytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.