From: Phillip Susi <psusi@ubuntu.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/4] e2image: perform in-place move
Date: Mon, 16 Dec 2013 11:30:56 -0500 [thread overview]
Message-ID: <52AF2AC0.2030103@ubuntu.com> (raw)
In-Reply-To: <20131216043338.GD28536@thunk.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/15/2013 11:33 PM, Theodore Ts'o wrote:
> On Tue, Oct 08, 2013 at 11:56:30AM -0400, Phillip Susi wrote:
>> If given at least one offset and only one file, assume source and
>> dest are the same, and do an in place move.
>>
>> Signed-off-by: Phillip Susi <psusi@ubuntu.com>
>
> You **really** only want to allow move_mode if you are in raw
> mode. In particular, the safe move isn't even implemented in the
> other mods (nor does it make any sense), and if the user simply
> forgot to specify -r, it would be a shame if it ended up destroying
> the user's file system. :-(
Good point, also only with -a. Fixed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJSryrAAAoJEI5FoCIzSKrwOicH/25obbcwApT1fMCZx3ZESYyg
q2zOgJafZCZfe4cx6Knn8TDZ+gk66229IslTMi3oXDTXkPXQXdc5oAtcuAs8iKNN
/bIgT+JKrwhvUsP8rL4F4oIfq1gzx9//YgS5awgyKV7653qGSmtXUdp5TZhSD8KU
f8dz66pWz/jnapv072qdqJOIXRndIGTSNWfR7M/GC0DVAKn+vRJVjXYRQ1Woov2m
tkzM5glZIFW5PUVngmckkUHLwxbdVHSQPQJE+Jib44ZOLmqYtcAfxfsrUxjbc/Ur
jWFUZOHBoDlNEmeHafDhudw3dC3yyutW+uTFKrg9dy85g5tobZ9NICZK4XgiJfw=
=/KYA
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-12-16 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 15:56 [PATCH 0/4] Add handy fs move features Phillip Susi
2013-10-08 15:56 ` [PATCH 1/4] e2image: add offset switches Phillip Susi
2013-12-16 4:32 ` Theodore Ts'o
2013-12-16 16:30 ` Phillip Susi
2013-12-16 16:32 ` Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
2013-10-08 15:56 ` [PATCH 2/4] e2image: perform in-place move Phillip Susi
2013-12-16 4:33 ` Theodore Ts'o
2013-12-16 16:30 ` Phillip Susi [this message]
2013-12-16 16:33 ` Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
2013-12-26 4:48 ` Theodore Ts'o
2013-12-26 5:24 ` Theodore Ts'o
2013-10-08 15:56 ` [PATCH 3/4] e2image: add progress indicator Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
2013-10-08 15:56 ` [PATCH 4/4] e2image: handle SIGINT safely Phillip Susi
2013-12-25 4:58 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF2AC0.2030103@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.