From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Simon Guinot <simon.guinot@sequanux.org>
Cc: Jason Cooper <jason@lakedaemon.net>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
stable@vger.kernel.org, linux-ide@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
Jeff Garzik <jgarzik@redhat.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ata: sata_mv: setting PHY speed according to SControl speed
Date: Thu, 26 Dec 2013 08:53:55 +0100 [thread overview]
Message-ID: <20131226085355.2fd1969c@skate> (raw)
In-Reply-To: <20131225224034.GB5531@kw.sim.vm.gnt>
Dear Simon Guinot,
On Wed, 25 Dec 2013 23:40:34 +0100, Simon Guinot wrote:
> > > This should be applied to every -stable kernel supporting Armada
> > > SoCs.
> >
> > Could we get a little more specific here? Please determine which
> > commit introduced the regression and note it with 'Fixes:
> > <commitish> "oneline"'
>
> Well, since the DT support for the sata_mv driver precedes SATA
> support for Armada SoCs, I'd say that the bug has been introduced by:
>
> a6a6de1a "arm: mvebu: SATA support: SoC-level DT data for Armada
> 370/XP"
>
> Let me know if you agree with that. I will update the commit message
> accorgingly.
In some sense, we could say that this is not a regression. According to
what you mean, SATA hotplug has *never* been working on Armada 370/XP.
So technically, it could be seen as a new feature for this platform,
and is therefore not a regression (i.e something that used to work, and
that no longer works). There has been no kernel release for which SATA
hotplug was working for Armada 370/XP.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ata: sata_mv: setting PHY speed according to SControl speed
Date: Thu, 26 Dec 2013 08:53:55 +0100 [thread overview]
Message-ID: <20131226085355.2fd1969c@skate> (raw)
In-Reply-To: <20131225224034.GB5531@kw.sim.vm.gnt>
Dear Simon Guinot,
On Wed, 25 Dec 2013 23:40:34 +0100, Simon Guinot wrote:
> > > This should be applied to every -stable kernel supporting Armada
> > > SoCs.
> >
> > Could we get a little more specific here? Please determine which
> > commit introduced the regression and note it with 'Fixes:
> > <commitish> "oneline"'
>
> Well, since the DT support for the sata_mv driver precedes SATA
> support for Armada SoCs, I'd say that the bug has been introduced by:
>
> a6a6de1a "arm: mvebu: SATA support: SoC-level DT data for Armada
> 370/XP"
>
> Let me know if you agree with that. I will update the commit message
> accorgingly.
In some sense, we could say that this is not a regression. According to
what you mean, SATA hotplug has *never* been working on Armada 370/XP.
So technically, it could be seen as a new feature for this platform,
and is therefore not a regression (i.e something that used to work, and
that no longer works). There has been no kernel release for which SATA
hotplug was working for Armada 370/XP.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-26 7:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 12:07 [PATCH] ata: sata_mv: setting PHY speed according to SControl speed Simon Guinot
2013-12-23 12:07 ` Simon Guinot
2013-12-24 19:46 ` Jason Cooper
2013-12-24 19:46 ` Jason Cooper
2013-12-25 16:41 ` Andrew Lunn
2013-12-25 16:41 ` Andrew Lunn
2013-12-25 22:40 ` Simon Guinot
2013-12-25 22:40 ` Simon Guinot
2013-12-26 7:53 ` Thomas Petazzoni [this message]
2013-12-26 7:53 ` Thomas Petazzoni
2013-12-26 11:54 ` Simon Guinot
2013-12-26 11:54 ` Simon Guinot
2013-12-26 13:34 ` Thomas Petazzoni
2013-12-26 13:34 ` Thomas Petazzoni
2013-12-27 15:49 ` Jason Cooper
2013-12-27 15:49 ` Jason Cooper
2013-12-26 18:01 ` Andrew Lunn
2013-12-26 18:01 ` Andrew Lunn
2013-12-27 17:37 ` Simon Guinot
2013-12-27 17:37 ` Simon Guinot
2013-12-31 12:12 ` Tejun Heo
2013-12-31 12:12 ` Tejun Heo
2013-12-31 17:05 ` Andrew Lunn
2013-12-31 17:05 ` Andrew Lunn
2014-01-08 13:45 ` Lior Amsalem
2014-01-08 13:45 ` Lior Amsalem
2014-01-10 17:44 ` Jason Cooper
2014-01-10 17:44 ` Jason Cooper
2014-01-10 23:55 ` Thomas Petazzoni
2014-01-10 23:55 ` Thomas Petazzoni
2014-01-13 14:36 ` Jason Cooper
2014-01-13 14:36 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226085355.2fd1969c@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgarzik@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=simon.guinot@sequanux.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.