From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Simon Horman <horms@verge.net.au>,
Linux-sh list <linux-sh@vger.kernel.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks
Date: Thu, 26 Dec 2013 22:25:39 +0100 [thread overview]
Message-ID: <20131226212539.GA2561@katana> (raw)
In-Reply-To: <CAMuHMdWPZjeF7+nEjXR3vL4HgSEVEk-uf-qQ68ZnFA=+Y_Q8tQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Thu, Dec 26, 2013 at 10:20:23PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 24, 2013 at 3:48 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Dec 18, 2013 at 10:31:58PM +0100, Wolfram Sang wrote:
> >> From: Wolfram Sang <wsa@sang-engineering.com>
> >>
> >> Tested with RIIC2 on a genmai board. Others untested but hopefully
> >> trivial enough to be added.
> >>
> >> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> >> Acked-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> V2: adapt to established sorting
> >
> > Thanks. This seems safe enough and I will queue it up.
>
> Note that after dropping these lines:
>
> CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]),
> CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]),
> CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]),
> CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]),
>
> i2c stopped working.
??? Why do you want to drop these lines?
If the i2c clocks are not registered, you won't get i2c support? Am I
missing something?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks
Date: Thu, 26 Dec 2013 21:25:39 +0000 [thread overview]
Message-ID: <20131226212539.GA2561@katana> (raw)
In-Reply-To: <CAMuHMdWPZjeF7+nEjXR3vL4HgSEVEk-uf-qQ68ZnFA=+Y_Q8tQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Thu, Dec 26, 2013 at 10:20:23PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 24, 2013 at 3:48 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Dec 18, 2013 at 10:31:58PM +0100, Wolfram Sang wrote:
> >> From: Wolfram Sang <wsa@sang-engineering.com>
> >>
> >> Tested with RIIC2 on a genmai board. Others untested but hopefully
> >> trivial enough to be added.
> >>
> >> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> >> Acked-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> V2: adapt to established sorting
> >
> > Thanks. This seems safe enough and I will queue it up.
>
> Note that after dropping these lines:
>
> CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]),
> CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]),
> CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]),
> CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]),
>
> i2c stopped working.
??? Why do you want to drop these lines?
If the i2c clocks are not registered, you won't get i2c support? Am I
missing something?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks
Date: Thu, 26 Dec 2013 22:25:39 +0100 [thread overview]
Message-ID: <20131226212539.GA2561@katana> (raw)
In-Reply-To: <CAMuHMdWPZjeF7+nEjXR3vL4HgSEVEk-uf-qQ68ZnFA=+Y_Q8tQ@mail.gmail.com>
On Thu, Dec 26, 2013 at 10:20:23PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 24, 2013 at 3:48 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Dec 18, 2013 at 10:31:58PM +0100, Wolfram Sang wrote:
> >> From: Wolfram Sang <wsa@sang-engineering.com>
> >>
> >> Tested with RIIC2 on a genmai board. Others untested but hopefully
> >> trivial enough to be added.
> >>
> >> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> >> Acked-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> V2: adapt to established sorting
> >
> > Thanks. This seems safe enough and I will queue it up.
>
> Note that after dropping these lines:
>
> CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]),
> CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]),
> CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]),
> CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]),
>
> i2c stopped working.
??? Why do you want to drop these lines?
If the i2c clocks are not registered, you won't get i2c support? Am I
missing something?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131226/1883389c/attachment.sig>
next prev parent reply other threads:[~2013-12-26 21:25 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 21:31 [PATCH V2 0/5] arm: shmobile: r7s72100: add native i2c support Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
2013-12-18 21:31 ` [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
[not found] ` <1387402321-21866-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-12-24 2:48 ` Simon Horman
2013-12-24 2:48 ` Simon Horman
2013-12-24 2:48 ` Simon Horman
[not found] ` <20131224024855.GC22401-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-12-26 21:20 ` Geert Uytterhoeven
2013-12-26 21:20 ` Geert Uytterhoeven
2013-12-26 21:20 ` Geert Uytterhoeven
2013-12-26 21:25 ` Wolfram Sang [this message]
2013-12-26 21:25 ` Wolfram Sang
2013-12-26 21:25 ` Wolfram Sang
2013-12-26 21:34 ` Geert Uytterhoeven
2013-12-26 21:34 ` Geert Uytterhoeven
2013-12-26 21:34 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXF6WmS_j4pC1U5jL3SK-ck7N=EA+-45duXdRZP1cOJkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-26 21:51 ` Geert Uytterhoeven
2013-12-26 21:51 ` Geert Uytterhoeven
2013-12-26 21:51 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXP4DAF1_DPtNfwCyP8WHFU03=zgM7i8FW9n6tcJpAHHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-27 2:01 ` Simon Horman
2013-12-27 2:01 ` Simon Horman
2013-12-27 2:01 ` Simon Horman
[not found] ` <1387402321-21866-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-12-18 21:31 ` [PATCH V2 1/5] pinctrl: r7s72100: add riic groups Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
[not found] ` <1387402321-21866-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-12-18 21:49 ` Wolfram Sang
2013-12-18 21:49 ` Wolfram Sang
2013-12-18 21:49 ` Wolfram Sang
2013-12-18 21:31 ` [PATCH V2 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
2013-12-18 21:31 ` Wolfram Sang
[not found] ` <1387402321-21866-4-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-12-27 4:27 ` Wolfram Sang
2013-12-27 4:27 ` Wolfram Sang
2013-12-27 4:27 ` Wolfram Sang
2014-01-06 5:22 ` Simon Horman
2014-01-06 5:22 ` Simon Horman
2014-01-06 5:22 ` Simon Horman
2013-12-18 21:32 ` [PATCH V2 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver Wolfram Sang
2013-12-18 21:32 ` Wolfram Sang
2013-12-18 21:32 ` Wolfram Sang
2013-12-18 21:32 ` [PATCH V2 5/5] i2c: riic: add driver Wolfram Sang
2013-12-18 21:32 ` Wolfram Sang
2013-12-18 21:32 ` Wolfram Sang
[not found] ` <1387402321-21866-6-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-12-19 0:01 ` Laurent Pinchart
2013-12-19 0:01 ` Laurent Pinchart
2013-12-19 0:01 ` Laurent Pinchart
2013-12-19 12:06 ` Wolfram Sang
2013-12-19 12:06 ` Wolfram Sang
2013-12-19 12:06 ` Wolfram Sang
2013-12-19 15:33 ` Laurent Pinchart
2013-12-19 15:33 ` Laurent Pinchart
2013-12-19 15:33 ` Laurent Pinchart
2013-12-20 15:47 ` Wolfram Sang
2013-12-20 15:47 ` Wolfram Sang
2013-12-20 15:47 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226212539.GA2561@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.