From: Matthew Wilcox <willy@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] remap_file_pages needs to check for cache coherency
Date: Fri, 27 Dec 2013 14:20:41 -0500 [thread overview]
Message-ID: <20131227192041.GD4945@linux.intel.com> (raw)
In-Reply-To: <20131227.134814.345379118522548543.davem@davemloft.net>
On Fri, Dec 27, 2013 at 01:48:14PM -0500, David Miller wrote:
> From: Matthew Wilcox <willy@linux.intel.com>
> Date: Fri, 27 Dec 2013 13:00:18 -0500
>
> > It seems to me that while (for example) on SPARC, it's not possible to
> > create a non-coherent mapping with mmap(), after we've done an mmap,
> > we can then use remap_file_pages() to create a mapping that no longer
> > aliases in the D-cache.
> >
> > I have only compile-tested this patch. I don't have any SPARC hardware,
> > and my PA-RISC hardware hasn't been turned on in six years ... I noticed
> > this while wandering around looking at some other stuff.
>
> I suppose this is needed, but only in the case where the mapping is
> shared and writable, right? I don't see you testing those conditions,
> but with them I'd be OK with this change.
VM_SHARED is checked a few lines above; too far to be visible in the
original context diff:
if (!vma || !(vma->vm_flags & VM_SHARED))
goto out;
if (!vma->vm_ops || !vma->vm_ops->remap_pages)
goto out;
if (start < vma->vm_start || start + size > vma->vm_end)
goto out;
+#ifdef __ARCH_FORCE_SHMLBA
+ /* Is the mapping cache-coherent? */
+ if ((pgoff ^ linear_page_index(vma, start)) &
+ ((SHMLBA-1) >> PAGE_SHIFT))
+ goto out;
+#endif
I don't understand why we need to check for writable here. We don't
seem to check VM_WRITE in arch_get_unmapped_area(), so I don't see why
we should be checking it here. Put it another way; if I mmap() a file
with PROT_READ only, should I be able to see stale data after another
thread has written to it?
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] remap_file_pages needs to check for cache coherency
Date: Fri, 27 Dec 2013 14:20:41 -0500 [thread overview]
Message-ID: <20131227192041.GD4945@linux.intel.com> (raw)
In-Reply-To: <20131227.134814.345379118522548543.davem@davemloft.net>
On Fri, Dec 27, 2013 at 01:48:14PM -0500, David Miller wrote:
> From: Matthew Wilcox <willy@linux.intel.com>
> Date: Fri, 27 Dec 2013 13:00:18 -0500
>
> > It seems to me that while (for example) on SPARC, it's not possible to
> > create a non-coherent mapping with mmap(), after we've done an mmap,
> > we can then use remap_file_pages() to create a mapping that no longer
> > aliases in the D-cache.
> >
> > I have only compile-tested this patch. I don't have any SPARC hardware,
> > and my PA-RISC hardware hasn't been turned on in six years ... I noticed
> > this while wandering around looking at some other stuff.
>
> I suppose this is needed, but only in the case where the mapping is
> shared and writable, right? I don't see you testing those conditions,
> but with them I'd be OK with this change.
VM_SHARED is checked a few lines above; too far to be visible in the
original context diff:
if (!vma || !(vma->vm_flags & VM_SHARED))
goto out;
if (!vma->vm_ops || !vma->vm_ops->remap_pages)
goto out;
if (start < vma->vm_start || start + size > vma->vm_end)
goto out;
+#ifdef __ARCH_FORCE_SHMLBA
+ /* Is the mapping cache-coherent? */
+ if ((pgoff ^ linear_page_index(vma, start)) &
+ ((SHMLBA-1) >> PAGE_SHIFT))
+ goto out;
+#endif
I don't understand why we need to check for writable here. We don't
seem to check VM_WRITE in arch_get_unmapped_area(), so I don't see why
we should be checking it here. Put it another way; if I mmap() a file
with PROT_READ only, should I be able to see stale data after another
thread has written to it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] remap_file_pages needs to check for cache coherency
Date: Fri, 27 Dec 2013 19:20:41 +0000 [thread overview]
Message-ID: <20131227192041.GD4945@linux.intel.com> (raw)
In-Reply-To: <20131227.134814.345379118522548543.davem@davemloft.net>
On Fri, Dec 27, 2013 at 01:48:14PM -0500, David Miller wrote:
> From: Matthew Wilcox <willy@linux.intel.com>
> Date: Fri, 27 Dec 2013 13:00:18 -0500
>
> > It seems to me that while (for example) on SPARC, it's not possible to
> > create a non-coherent mapping with mmap(), after we've done an mmap,
> > we can then use remap_file_pages() to create a mapping that no longer
> > aliases in the D-cache.
> >
> > I have only compile-tested this patch. I don't have any SPARC hardware,
> > and my PA-RISC hardware hasn't been turned on in six years ... I noticed
> > this while wandering around looking at some other stuff.
>
> I suppose this is needed, but only in the case where the mapping is
> shared and writable, right? I don't see you testing those conditions,
> but with them I'd be OK with this change.
VM_SHARED is checked a few lines above; too far to be visible in the
original context diff:
if (!vma || !(vma->vm_flags & VM_SHARED))
goto out;
if (!vma->vm_ops || !vma->vm_ops->remap_pages)
goto out;
if (start < vma->vm_start || start + size > vma->vm_end)
goto out;
+#ifdef __ARCH_FORCE_SHMLBA
+ /* Is the mapping cache-coherent? */
+ if ((pgoff ^ linear_page_index(vma, start)) &
+ ((SHMLBA-1) >> PAGE_SHIFT))
+ goto out;
+#endif
I don't understand why we need to check for writable here. We don't
seem to check VM_WRITE in arch_get_unmapped_area(), so I don't see why
we should be checking it here. Put it another way; if I mmap() a file
with PROT_READ only, should I be able to see stale data after another
thread has written to it?
next prev parent reply other threads:[~2013-12-27 19:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 18:00 [PATCH] remap_file_pages needs to check for cache coherency Matthew Wilcox
2013-12-27 18:00 ` Matthew Wilcox
2013-12-27 18:00 ` Matthew Wilcox
2013-12-27 18:48 ` David Miller
2013-12-27 18:48 ` David Miller
2013-12-27 18:48 ` David Miller
2013-12-27 19:20 ` Matthew Wilcox [this message]
2013-12-27 19:20 ` Matthew Wilcox
2013-12-27 19:20 ` Matthew Wilcox
2013-12-27 19:13 ` John David Anglin
2013-12-27 19:13 ` John David Anglin
2013-12-27 19:13 ` John David Anglin
2013-12-27 19:33 ` Matthew Wilcox
2013-12-27 19:33 ` Matthew Wilcox
2013-12-27 19:33 ` Matthew Wilcox
2013-12-27 19:47 ` John David Anglin
2013-12-27 19:47 ` John David Anglin
2013-12-27 19:47 ` John David Anglin
2013-12-27 20:14 ` John David Anglin
2013-12-27 20:14 ` John David Anglin
2013-12-27 20:14 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131227192041.GD4945@linux.intel.com \
--to=willy@linux.intel.com \
--cc=davem@davemloft.net \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.