From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix
Date: Mon, 30 Dec 2013 12:48:54 +0200 [thread overview]
Message-ID: <20131230104854.GA7647@node.dhcp.inet.fi> (raw)
In-Reply-To: <1388184018-11396-1-git-send-email-sasha.levin@oracle.com>
On Fri, Dec 27, 2013 at 05:40:18PM -0500, Sasha Levin wrote:
> I messed up and forgot to commit this fix before sending out the original
> patch.
>
> It fixes build issues in various files using VM_BUG_ON_PAGE.
With the patch applied I see this:
CC kernel/bounds.s
In file included from /home/space/kas/git/public/linux-next/include/linux/page-flags.h:10:0,
from /home/space/kas/git/public/linux-next/kernel/bounds.c:9:
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: a??struct pagea?? declared inside parameter list [enabled by default]
extern void dump_page(struct page *page);
^
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
We need to declare struct page here as well.
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 8bb64900da25..e8cec8bdda05 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
#define LINUX_MM_DEBUG_H 1
#ifdef CONFIG_DEBUG_VM
+struct page;
extern void dump_page(struct page *page);
#define VM_BUG_ON(cond) BUG_ON(cond)
#define VM_BUG_ON_PAGE(cond, page) \
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix
Date: Mon, 30 Dec 2013 12:48:54 +0200 [thread overview]
Message-ID: <20131230104854.GA7647@node.dhcp.inet.fi> (raw)
In-Reply-To: <1388184018-11396-1-git-send-email-sasha.levin@oracle.com>
On Fri, Dec 27, 2013 at 05:40:18PM -0500, Sasha Levin wrote:
> I messed up and forgot to commit this fix before sending out the original
> patch.
>
> It fixes build issues in various files using VM_BUG_ON_PAGE.
With the patch applied I see this:
CC kernel/bounds.s
In file included from /home/space/kas/git/public/linux-next/include/linux/page-flags.h:10:0,
from /home/space/kas/git/public/linux-next/kernel/bounds.c:9:
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: ‘struct page’ declared inside parameter list [enabled by default]
extern void dump_page(struct page *page);
^
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
We need to declare struct page here as well.
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 8bb64900da25..e8cec8bdda05 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
#define LINUX_MM_DEBUG_H 1
#ifdef CONFIG_DEBUG_VM
+struct page;
extern void dump_page(struct page *page);
#define VM_BUG_ON(cond) BUG_ON(cond)
#define VM_BUG_ON_PAGE(cond, page) \
--
Kirill A. Shutemov
next prev parent reply other threads:[~2013-12-30 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 22:40 [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix Sasha Levin
2013-12-27 22:40 ` Sasha Levin
2013-12-30 10:48 ` Kirill A. Shutemov [this message]
2013-12-30 10:48 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230104854.GA7647@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.