* [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
@ 2013-12-30 3:37 Wang YanQing
2013-12-30 5:34 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Wang YanQing @ 2013-12-30 3:37 UTC (permalink / raw)
To: gregkh; +Cc: jslaby, airlied, akpm, kilobyte, linux-kernel
FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"
I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
the same time.
This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
I decide to disable FONT_8x8, this patch will reduce size of kernel.
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
lib/fonts/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/fonts/Kconfig b/lib/fonts/Kconfig
index 34fd931..11d3758 100644
--- a/lib/fonts/Kconfig
+++ b/lib/fonts/Kconfig
@@ -23,7 +23,6 @@ config FONTS
config FONT_8x8
bool "VGA 8x8 font" if FONTS
depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE
- default y if !SPARC && !FONTS
help
This is the "high resolution" font for the VGA frame buffer (the one
provided by the text console 80x50 (and higher) modes).
--
1.8.3.4.8.g69490f3.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
2013-12-30 3:37 Wang YanQing
@ 2013-12-30 5:34 ` Greg KH
2013-12-30 6:48 ` Wang YanQing
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2013-12-30 5:34 UTC (permalink / raw)
To: Wang YanQing, jslaby, airlied, akpm, kilobyte, linux-kernel
On Mon, Dec 30, 2013 at 11:37:45AM +0800, Wang YanQing wrote:
> FONT_8x8 and FONT_8x16 have the same default value line:
> "default y if !SPARC && !FONTS"
>
> I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
> the same time.
>
> This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
> I decide to disable FONT_8x8, this patch will reduce size of kernel.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
> lib/fonts/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
I am not the maintainer of this file, sorry. Also, I don't think it's
correct, if you want, you can always disable this option on your own.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
2013-12-30 5:34 ` Greg KH
@ 2013-12-30 6:48 ` Wang YanQing
2013-12-30 18:21 ` Randy Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Wang YanQing @ 2013-12-30 6:48 UTC (permalink / raw)
To: Greg KH; +Cc: jslaby, airlied, akpm, kilobyte, linux-kernel
On Sun, Dec 29, 2013 at 09:34:30PM -0800, Greg KH wrote:
> On Mon, Dec 30, 2013 at 11:37:45AM +0800, Wang YanQing wrote:
> > FONT_8x8 and FONT_8x16 have the same default value line:
> > "default y if !SPARC && !FONTS"
> >
> > I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
> > the same time.
> >
> > This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
> > I decide to disable FONT_8x8, this patch will reduce size of kernel.
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> > lib/fonts/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
>
> I am not the maintainer of this file, sorry. Also, I don't think it's
> correct, if you want, you can always disable this option on your own.
>
Hi Greg KH.
Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16,
FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not
good default behavior.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
@ 2013-12-30 6:53 Wang YanQing
2013-12-30 8:51 ` Geert Uytterhoeven
2013-12-31 1:19 ` Wang YanQing
0 siblings, 2 replies; 7+ messages in thread
From: Wang YanQing @ 2013-12-30 6:53 UTC (permalink / raw)
To: linux-fbdev
FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"
I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
the same time.
This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
I decide to disable FONT_8x8, this patch will reduce size of kernel.
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
lib/fonts/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/fonts/Kconfig b/lib/fonts/Kconfig
index 34fd931..11d3758 100644
--- a/lib/fonts/Kconfig
+++ b/lib/fonts/Kconfig
@@ -23,7 +23,6 @@ config FONTS
config FONT_8x8
bool "VGA 8x8 font" if FONTS
depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE
- default y if !SPARC && !FONTS
help
This is the "high resolution" font for the VGA frame buffer (the one
provided by the text console 80x50 (and higher) modes).
--
1.8.3.4.8.g69490f3.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
2013-12-30 6:53 [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time Wang YanQing
@ 2013-12-30 8:51 ` Geert Uytterhoeven
2013-12-31 1:19 ` Wang YanQing
1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2013-12-30 8:51 UTC (permalink / raw)
To: linux-fbdev
On Mon, Dec 30, 2013 at 7:53 AM, Wang YanQing <udknight@gmail.com> wrote:
> FONT_8x8 and FONT_8x16 have the same default value line:
> "default y if !SPARC && !FONTS"
>
> I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
> the same time.
>
> This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
> I decide to disable FONT_8x8, this patch will reduce size of kernel.
... at the expense of losing FONT_8x8...
In another email, you wrote:
| Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16,
| FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not
| good default behavior.
Whether FONT_8x8 or FONT_8x16 is used depends on your screen resolution,
cfr. lib/fonts/font.c:get_default_font().
If you don't want to compile in FONT_8x8, then please enable CONFIG_FONTS,
and disable CONFIG_FONT_8x8.
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
> lib/fonts/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/fonts/Kconfig b/lib/fonts/Kconfig
> index 34fd931..11d3758 100644
> --- a/lib/fonts/Kconfig
> +++ b/lib/fonts/Kconfig
> @@ -23,7 +23,6 @@ config FONTS
> config FONT_8x8
> bool "VGA 8x8 font" if FONTS
> depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE
> - default y if !SPARC && !FONTS
> help
> This is the "high resolution" font for the VGA frame buffer (the one
> provided by the text console 80x50 (and higher) modes).
> --
> 1.8.3.4.8.g69490f3.dirty
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
2013-12-30 6:48 ` Wang YanQing
@ 2013-12-30 18:21 ` Randy Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2013-12-30 18:21 UTC (permalink / raw)
To: Wang YanQing, Greg KH, jslaby, airlied, akpm, kilobyte,
linux-kernel
On 12/29/13 22:48, Wang YanQing wrote:
> On Sun, Dec 29, 2013 at 09:34:30PM -0800, Greg KH wrote:
>> On Mon, Dec 30, 2013 at 11:37:45AM +0800, Wang YanQing wrote:
>>> FONT_8x8 and FONT_8x16 have the same default value line:
>>> "default y if !SPARC && !FONTS"
>>>
>>> I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
>>> the same time.
>>>
>>> This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
>>> I decide to disable FONT_8x8, this patch will reduce size of kernel.
>>>
>>> Signed-off-by: Wang YanQing <udknight@gmail.com>
>>> ---
>>> lib/fonts/Kconfig | 1 -
>>> 1 file changed, 1 deletion(-)
>>
>> I am not the maintainer of this file, sorry. Also, I don't think it's
>> correct, if you want, you can always disable this option on your own.
>>
> Hi Greg KH.
>
> Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16,
> FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not
> good default behavior.
If framebuffer console is enabled, then the user can select which compiled-in
font to use by using
fbcon=font:<name>
See Documentation/fb/fbcon.txt for more info.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
2013-12-30 6:53 [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time Wang YanQing
2013-12-30 8:51 ` Geert Uytterhoeven
@ 2013-12-31 1:19 ` Wang YanQing
1 sibling, 0 replies; 7+ messages in thread
From: Wang YanQing @ 2013-12-31 1:19 UTC (permalink / raw)
To: linux-fbdev
On Mon, Dec 30, 2013 at 09:51:38AM +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 30, 2013 at 7:53 AM, Wang YanQing <udknight@gmail.com> wrote:
> > FONT_8x8 and FONT_8x16 have the same default value line:
> > "default y if !SPARC && !FONTS"
> >
> > I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at
> > the same time.
> >
> > This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so
> > I decide to disable FONT_8x8, this patch will reduce size of kernel.
>
> ... at the expense of losing FONT_8x8...
>
> In another email, you wrote:
> | Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16,
> | FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not
> | good default behavior.
>
> Whether FONT_8x8 or FONT_8x16 is used depends on your screen resolution,
> cfr. lib/fonts/font.c:get_default_font().
Thanks for point out get_default_font, I know where I am wrong now :)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-31 1:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 6:53 [PATCH] fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time Wang YanQing
2013-12-30 8:51 ` Geert Uytterhoeven
2013-12-31 1:19 ` Wang YanQing
-- strict thread matches above, loose matches on Subject: below --
2013-12-30 3:37 Wang YanQing
2013-12-30 5:34 ` Greg KH
2013-12-30 6:48 ` Wang YanQing
2013-12-30 18:21 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.