All of lore.kernel.org
 help / color / mirror / Atom feed
From: gsi@denx.de (Gerhard Sittig)
To: linux-arm-kernel@lists.infradead.org
Subject: [ARM] Fix kernel compile error: drivers/crypto/ixp4xx_crypto.c.
Date: Tue, 31 Dec 2013 14:48:20 +0100	[thread overview]
Message-ID: <20131231134820.GS8064@book.gsilab.sittig.org> (raw)
In-Reply-To: <m3d2kduwd7.fsf@t19.piap.pl>

On Tue, Dec 31, 2013 at 11:51 +0100, Krzysztof Ha?asa wrote:
> 
> drivers/crypto/ixp4xx_crypto.c: In function 'ixp_module_init':
> drivers/crypto/ixp4xx_crypto.c:1419:2: error: 'dev' undeclared (first use in this function)
> 
> Now builds. Not tested on real hw.
> 
> Signed-off-by: Krzysztof Ha?asa <khalasa@piap.pl>

I understood that a 'Fixes: <hash> <subject>' line is suggested when
you can clearly identify what broke what you fix.  Is it 27c1789ca6a6
"DMA-API: crypto: remove last references to 'static struct device *dev'"?
Then v3.13-rc1 would have been affected.

> --- a/drivers/crypto/ixp4xx_crypto.c
> +++ b/drivers/crypto/ixp4xx_crypto.c
> @@ -1410,14 +1410,12 @@ static const struct platform_device_info ixp_dev_info __initdata = {
>  static int __init ixp_module_init(void)
>  {
>  	int num = ARRAY_SIZE(ixp4xx_algos);
> -	int i, err ;
> +	int i, err;
>  
>  	pdev = platform_device_register_full(&ixp_dev_info);
>  	if (IS_ERR(pdev))
>  		return PTR_ERR(pdev);
>  
> -	dev = &pdev->dev;
> -
>  	spin_lock_init(&desc_lock);
>  	spin_lock_init(&emerg_lock);


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

WARNING: multiple messages have this Message-ID (diff)
From: Gerhard Sittig <gsi@denx.de>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Christian Hohnstaedt <chohnstaedt@innominate.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [ARM] Fix kernel compile error: drivers/crypto/ixp4xx_crypto.c.
Date: Tue, 31 Dec 2013 14:48:20 +0100	[thread overview]
Message-ID: <20131231134820.GS8064@book.gsilab.sittig.org> (raw)
In-Reply-To: <m3d2kduwd7.fsf@t19.piap.pl>

On Tue, Dec 31, 2013 at 11:51 +0100, Krzysztof Hałasa wrote:
> 
> drivers/crypto/ixp4xx_crypto.c: In function 'ixp_module_init':
> drivers/crypto/ixp4xx_crypto.c:1419:2: error: 'dev' undeclared (first use in this function)
> 
> Now builds. Not tested on real hw.
> 
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>

I understood that a 'Fixes: <hash> <subject>' line is suggested when
you can clearly identify what broke what you fix.  Is it 27c1789ca6a6
"DMA-API: crypto: remove last references to 'static struct device *dev'"?
Then v3.13-rc1 would have been affected.

> --- a/drivers/crypto/ixp4xx_crypto.c
> +++ b/drivers/crypto/ixp4xx_crypto.c
> @@ -1410,14 +1410,12 @@ static const struct platform_device_info ixp_dev_info __initdata = {
>  static int __init ixp_module_init(void)
>  {
>  	int num = ARRAY_SIZE(ixp4xx_algos);
> -	int i, err ;
> +	int i, err;
>  
>  	pdev = platform_device_register_full(&ixp_dev_info);
>  	if (IS_ERR(pdev))
>  		return PTR_ERR(pdev);
>  
> -	dev = &pdev->dev;
> -
>  	spin_lock_init(&desc_lock);
>  	spin_lock_init(&emerg_lock);


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de

  reply	other threads:[~2013-12-31 13:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-31 10:51 [ARM] Fix kernel compile error: drivers/crypto/ixp4xx_crypto.c Krzysztof Hałasa
2013-12-31 10:51 ` Krzysztof Hałasa
2013-12-31 13:48 ` Gerhard Sittig [this message]
2013-12-31 13:48   ` Gerhard Sittig
2013-12-31 18:01   ` Randy Dunlap
2013-12-31 18:01     ` Randy Dunlap
2014-01-01 12:37     ` Gerhard Sittig
2014-01-01 12:37       ` Gerhard Sittig
2014-01-01 12:46       ` Russell King - ARM Linux
2014-01-01 12:46         ` Russell King - ARM Linux
2014-01-02  0:25         ` Jason Cooper
2014-01-02  0:25           ` Jason Cooper
2013-12-31 18:14   ` Russell King - ARM Linux
2013-12-31 18:14     ` Russell King - ARM Linux
2014-01-01 12:18     ` Gerhard Sittig
2014-01-01 12:18       ` Gerhard Sittig
2014-01-02  8:42       ` About Mail-Followup-To and Mutt [Was: Re: [ARM] Fix kernel compile error: drivers/crypto/ixp4xx_crypto.c] Uwe Kleine-König
2014-01-02  8:42         ` Uwe Kleine-König
2014-01-02 10:35         ` Russell King - ARM Linux
2014-01-02 10:35           ` Russell King - ARM Linux
2014-01-02 18:33           ` Borislav Petkov
2014-01-02 18:33             ` Borislav Petkov
2014-01-02 17:51         ` Mark Brown
2014-01-02 17:51           ` Mark Brown
2014-01-01  6:06 ` [ARM] Fix kernel compile error: drivers/crypto/ixp4xx_crypto.c Herbert Xu
2014-01-01  6:06   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131231134820.GS8064@book.gsilab.sittig.org \
    --to=gsi@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.