* [PATCH] xen: Use dev_is_pci() to check whether it is pci device
@ 2013-12-05 11:34 Yijing Wang
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
0 siblings, 2 replies; 6+ messages in thread
From: Yijing Wang @ 2013-12-05 11:34 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel
Cc: xen-devel, linux-kernel, Yijing Wang, Hanjun Guo
Use PCI standard marco dev_is_pci() instead of directly compare
pci_bus_type to check whether it is pci device.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/xen/dbgp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
index f3ccc80..8145a59 100644
--- a/drivers/xen/dbgp.c
+++ b/drivers/xen/dbgp.c
@@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
dbgp.op = op;
#ifdef CONFIG_PCI
- if (ctrlr->bus == &pci_bus_type) {
+ if (dev_is_pci(ctrlr)) {
const struct pci_dev *pdev = to_pci_dev(ctrlr);
dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device
2013-12-05 11:34 [PATCH] xen: Use dev_is_pci() to check whether it is pci device Yijing Wang
@ 2013-12-31 14:51 ` Konrad Rzeszutek Wilk
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-12-31 14:51 UTC (permalink / raw)
To: Yijing Wang, JBeulich
Cc: xen-devel, Boris Ostrovsky, Hanjun Guo, David Vrabel,
linux-kernel
On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
> Use PCI standard marco dev_is_pci() instead of directly compare
> pci_bus_type to check whether it is pci device.
Jan, you OK with this?
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
> drivers/xen/dbgp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
> index f3ccc80..8145a59 100644
> --- a/drivers/xen/dbgp.c
> +++ b/drivers/xen/dbgp.c
> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
> dbgp.op = op;
>
> #ifdef CONFIG_PCI
> - if (ctrlr->bus == &pci_bus_type) {
> + if (dev_is_pci(ctrlr)) {
> const struct pci_dev *pdev = to_pci_dev(ctrlr);
>
> dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device
2013-12-05 11:34 [PATCH] xen: Use dev_is_pci() to check whether it is pci device Yijing Wang
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
@ 2013-12-31 14:51 ` Konrad Rzeszutek Wilk
2014-01-07 12:16 ` Jan Beulich
2014-01-07 12:16 ` Jan Beulich
1 sibling, 2 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-12-31 14:51 UTC (permalink / raw)
To: Yijing Wang, JBeulich
Cc: Boris Ostrovsky, David Vrabel, xen-devel, linux-kernel,
Hanjun Guo
On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
> Use PCI standard marco dev_is_pci() instead of directly compare
> pci_bus_type to check whether it is pci device.
Jan, you OK with this?
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
> drivers/xen/dbgp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
> index f3ccc80..8145a59 100644
> --- a/drivers/xen/dbgp.c
> +++ b/drivers/xen/dbgp.c
> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
> dbgp.op = op;
>
> #ifdef CONFIG_PCI
> - if (ctrlr->bus == &pci_bus_type) {
> + if (dev_is_pci(ctrlr)) {
> const struct pci_dev *pdev = to_pci_dev(ctrlr);
>
> dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
@ 2014-01-07 12:16 ` Jan Beulich
2014-01-07 12:16 ` Jan Beulich
1 sibling, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2014-01-07 12:16 UTC (permalink / raw)
To: Yijing Wang, Konrad Rzeszutek Wilk
Cc: xen-devel, Boris Ostrovsky, David Vrabel, linux-kernel,
Hanjun Guo
>>> On 31.12.13 at 15:51, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
>> Use PCI standard marco dev_is_pci() instead of directly compare
>> pci_bus_type to check whether it is pci device.
>
> Jan, you OK with this?
Yes, sure - I simply wasn't aware of that wrapper.
Jan
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>> drivers/xen/dbgp.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
>> index f3ccc80..8145a59 100644
>> --- a/drivers/xen/dbgp.c
>> +++ b/drivers/xen/dbgp.c
>> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
>> dbgp.op = op;
>>
>> #ifdef CONFIG_PCI
>> - if (ctrlr->bus == &pci_bus_type) {
>> + if (dev_is_pci(ctrlr)) {
>> const struct pci_dev *pdev = to_pci_dev(ctrlr);
>>
>> dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
>> --
>> 1.7.1
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
2014-01-07 12:16 ` Jan Beulich
@ 2014-01-07 12:16 ` Jan Beulich
1 sibling, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2014-01-07 12:16 UTC (permalink / raw)
To: Yijing Wang, Konrad Rzeszutek Wilk
Cc: David Vrabel, Hanjun Guo, xen-devel, Boris Ostrovsky,
linux-kernel
>>> On 31.12.13 at 15:51, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
>> Use PCI standard marco dev_is_pci() instead of directly compare
>> pci_bus_type to check whether it is pci device.
>
> Jan, you OK with this?
Yes, sure - I simply wasn't aware of that wrapper.
Jan
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>> drivers/xen/dbgp.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
>> index f3ccc80..8145a59 100644
>> --- a/drivers/xen/dbgp.c
>> +++ b/drivers/xen/dbgp.c
>> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
>> dbgp.op = op;
>>
>> #ifdef CONFIG_PCI
>> - if (ctrlr->bus == &pci_bus_type) {
>> + if (dev_is_pci(ctrlr)) {
>> const struct pci_dev *pdev = to_pci_dev(ctrlr);
>>
>> dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
>> --
>> 1.7.1
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen: Use dev_is_pci() to check whether it is pci device
@ 2013-12-05 11:34 Yijing Wang
0 siblings, 0 replies; 6+ messages in thread
From: Yijing Wang @ 2013-12-05 11:34 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel
Cc: Yijing Wang, xen-devel, linux-kernel, Hanjun Guo
Use PCI standard marco dev_is_pci() instead of directly compare
pci_bus_type to check whether it is pci device.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/xen/dbgp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
index f3ccc80..8145a59 100644
--- a/drivers/xen/dbgp.c
+++ b/drivers/xen/dbgp.c
@@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
dbgp.op = op;
#ifdef CONFIG_PCI
- if (ctrlr->bus == &pci_bus_type) {
+ if (dev_is_pci(ctrlr)) {
const struct pci_dev *pdev = to_pci_dev(ctrlr);
dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-07 12:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-05 11:34 [PATCH] xen: Use dev_is_pci() to check whether it is pci device Yijing Wang
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
2013-12-31 14:51 ` Konrad Rzeszutek Wilk
2014-01-07 12:16 ` Jan Beulich
2014-01-07 12:16 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2013-12-05 11:34 Yijing Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.