From: Baruch Siach <baruch@tkos.co.il>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e4defrag: fix build when posix_fadvise is missing
Date: Wed, 1 Jan 2014 19:31:46 +0200 [thread overview]
Message-ID: <20140101173146.GM4470@tarshish> (raw)
In-Reply-To: <20140101172205.GC17519@thunk.org>
Hi Ted,
On Wed, Jan 01, 2014 at 12:22:05PM -0500, Theodore Ts'o wrote:
> On Wed, Jan 01, 2014 at 12:28:23PM +0200, Baruch Siach wrote:
> > uClibc declares posix_fadvise() even when the architecture does not provide
> > one. The static posix_fadvise() signature is not compatible with POSIX. Rename
> > the internal implementation to fix this.
>
> If the architecture doesn't provide posix_fadvise(), does that imply
> that __NR_fadvise64_64 also doesn't exist?
>
> Or do you mean that for some reason, uClibc is not providing
> posix_fadvise on all architectures, even though the kernel supports it?
>
> That seems wierd.
The xtensa architecture has __NR_fadvise64_64 but not __NR_fadvise64. Should I
clarify this in the commit log?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-01-01 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 10:28 [PATCH] e4defrag: fix build when posix_fadvise is missing Baruch Siach
2014-01-01 17:22 ` Theodore Ts'o
2014-01-01 17:31 ` Baruch Siach [this message]
2014-01-01 17:37 ` Theodore Ts'o
2014-01-01 19:08 ` Baruch Siach
2014-01-01 20:46 ` Theodore Ts'o
2014-01-02 6:49 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140101173146.GM4470@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.