From: Theodore Ts'o <tytso@mit.edu>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e4defrag: fix build when posix_fadvise is missing
Date: Wed, 1 Jan 2014 12:37:44 -0500 [thread overview]
Message-ID: <20140101173744.GD17519@thunk.org> (raw)
In-Reply-To: <20140101173146.GM4470@tarshish>
On Wed, Jan 01, 2014 at 07:31:46PM +0200, Baruch Siach wrote:
> > Or do you mean that for some reason, uClibc is not providing
> > posix_fadvise on all architectures, even though the kernel supports it?
> >
> > That seems wierd.
>
> The xtensa architecture has __NR_fadvise64_64 but not __NR_fadvise64. Should I
> clarify this in the commit log?
Is uClibc providing a posix_fadvise64()? Maybe the better fix would be
to try to use posix_fadvise64 if it is exists, with posix_fadvise()
and the locally defined posix_fadvise() as fallbacks.
If not, why is uClibc not providing any userspace access to
posix_fadvise, if the kernel suppots it, and it's insisting on
providing a function delcaration for it?
- Ted
next prev parent reply other threads:[~2014-01-01 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 10:28 [PATCH] e4defrag: fix build when posix_fadvise is missing Baruch Siach
2014-01-01 17:22 ` Theodore Ts'o
2014-01-01 17:31 ` Baruch Siach
2014-01-01 17:37 ` Theodore Ts'o [this message]
2014-01-01 19:08 ` Baruch Siach
2014-01-01 20:46 ` Theodore Ts'o
2014-01-02 6:49 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140101173744.GD17519@thunk.org \
--to=tytso@mit.edu \
--cc=baruch@tkos.co.il \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.