From: Mel Gorman <mgorman@suse.de>
To: SeongJae Park <sj38.park@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: page_alloc: use enum instead of number for migratetype
Date: Thu, 2 Jan 2014 15:57:26 +0000 [thread overview]
Message-ID: <20140102155726.GA865@suse.de> (raw)
In-Reply-To: <1388661922-10957-1-git-send-email-sj38.park@gmail.com>
On Thu, Jan 02, 2014 at 08:25:22PM +0900, SeongJae Park wrote:
> Using enum instead of number for migratetype everywhere would be better
> for reading and understanding.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
This implicitly makes assumptions about the value of MIGRATE_UNMOVABLE
and does not appear to actually fix or improve anything.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: SeongJae Park <sj38.park@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: page_alloc: use enum instead of number for migratetype
Date: Thu, 2 Jan 2014 15:57:26 +0000 [thread overview]
Message-ID: <20140102155726.GA865@suse.de> (raw)
In-Reply-To: <1388661922-10957-1-git-send-email-sj38.park@gmail.com>
On Thu, Jan 02, 2014 at 08:25:22PM +0900, SeongJae Park wrote:
> Using enum instead of number for migratetype everywhere would be better
> for reading and understanding.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
This implicitly makes assumptions about the value of MIGRATE_UNMOVABLE
and does not appear to actually fix or improve anything.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2014-01-02 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 11:25 [PATCH] mm: page_alloc: use enum instead of number for migratetype SeongJae Park
2014-01-02 11:25 ` SeongJae Park
2014-01-02 15:57 ` Mel Gorman [this message]
2014-01-02 15:57 ` Mel Gorman
2014-01-03 3:21 ` SeongJae Park
2014-01-03 3:21 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102155726.GA865@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.