82546EB Copper issue

82546EB Copper issue

[Ognjen Joldzic]

Hi,

Recently I came across a 82546EB Dual-port Gigabit Ethernet (Copper) NIC
and tried to include it in our current DPDK setup. However, the card
doesn't seem to be supported (I was unable to bind the igb_uio driver).
There was a post in mailing list earlier this year stating that this
particular NIC is not supported as of r1.2.3.
Is the situation any different with the 1.5.0 release (or are there any
plans to support this model)?

Thanks,
Ognjen

Re: 82546EB Copper issue

[Thomas Monjalon]

Hello,

19/11/2013 23:44, Ognjen Joldzic :
> Recently I came across a 82546EB Dual-port Gigabit Ethernet (Copper) NIC
> and tried to include it in our current DPDK setup. However, the card
> doesn't seem to be supported (I was unable to bind the igb_uio driver).
> There was a post in mailing list earlier this year stating that this
> particular NIC is not supported as of r1.2.3.
> Is the situation any different with the 1.5.0 release (or are there any
> plans to support this model)?

The page http://dpdk.org/doc/nics says that 8254x should be supported.
But looking in details:
% grep 'RTE_PCI_DEV_ID_DECL.*8254' lib/librte_eal/common/include/rte_pci_dev_ids.h
RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82540EM)
RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82545EM_COPPER)
RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82545EM_FIBER)

It means that only 82540 and 82545 are supported.
I don't know if there is a big difference with 82546 controller
and I'm not aware of any plan to support it.
So feel free to try and patch it.

-- 
Thomas

Re: 82546EB Copper issue

[Ognjen Joldzic]

Hi.
Actually, the support for 82546EB Copper NIC is already there. All it takes
to make it work is one line in rte_pci_dev_ids.h:

RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82546EB_COPPER)

Not much of a patch, I guess :)


On Wed, Nov 20, 2013 at 8:57 AM, Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>wrote:

> Hello,
>
> 19/11/2013 23:44, Ognjen Joldzic :
> > Recently I came across a 82546EB Dual-port Gigabit Ethernet (Copper) NIC
> > and tried to include it in our current DPDK setup. However, the card
> > doesn't seem to be supported (I was unable to bind the igb_uio driver).
> > There was a post in mailing list earlier this year stating that this
> > particular NIC is not supported as of r1.2.3.
> > Is the situation any different with the 1.5.0 release (or are there any
> > plans to support this model)?
>
> The page http://dpdk.org/doc/nics says that 8254x should be supported.
> But looking in details:
> % grep 'RTE_PCI_DEV_ID_DECL.*8254'
> lib/librte_eal/common/include/rte_pci_dev_ids.h
> RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82540EM)
> RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82545EM_COPPER)
> RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82545EM_FIBER)
>
> It means that only 82540 and 82545 are supported.
> I don't know if there is a big difference with 82546 controller
> and I'm not aware of any plan to support it.
> So feel free to try and patch it.
>
> --
> Thomas
>

Re: 82546EB Copper issue

[Thomas Monjalon]

22/11/2013 08:30, Ognjen Joldzic :
> Actually, the support for 82546EB Copper NIC is already there. All it takes
> to make it work is one line in rte_pci_dev_ids.h:
> 
> RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82546EB_COPPER)
> 
> Not much of a patch, I guess :)

Please, I would prefer a real patch signed by you.

Thank you
-- 
Thomas

[PATCH] pci: support 82546EB

[Thomas Monjalon]

Intel 82546EB Gigabit ethernet controller is reported to be working
with copper.

Tested-by: Ognjen Joldzic <ognjen.joldzic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_eal/common/include/rte_pci_dev_ids.h |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h
index 226cb51..015066c 100644
--- a/lib/librte_eal/common/include/rte_pci_dev_ids.h
+++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h
@@ -244,6 +244,9 @@ RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82545EM_FIBER)
  * Tested (supported) on real HW.
  */
 
+RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82546EB_COPPER)
+RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82546EB_FIBER)
+RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82546EB_QUAD_COPPER)
 RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82571EB_COPPER)
 RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82571EB_FIBER)
 RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82571EB_SERDES)
-- 
1.7.10.4

Re: [PATCH] pci: support 82546EB

[Thomas Monjalon]

20/12/2013 13:52, Thomas Monjalon :
> Intel 82546EB Gigabit ethernet controller is reported to be working
> with copper.
> 
> Tested-by: Ognjen Joldzic <ognjen.joldzic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

pushed in 1.5.1r2

-- 
Thomas