Re: [PATCH v7 4/4] arm64: Add APM X-Gene SoC SATA host controller DTS entries

[Arnd Bergmann <arnd@arndb.de>]

On Friday 03 January 2014, Loc Ho wrote:
> +                       sata23clk: sata23clk@1f22c000 {
> +                               compatible = "apm,xgene-device-clock";
> +                               #clock-cells = <1>;
> +                               clocks = <&socplldiv2 0>;
> +                               clock-names = "sata23clk";

> +                       };
> +
> +                       sata45clk: sata45clk@1f23c000 {
> +                               compatible = "apm,xgene-device-clock";
> +                               #clock-cells = <1>;
> +                               clocks = <&socplldiv2 0>;
> +                               clock-names = "sata45clk";

Something is wrong here: You have two devices with the same "compatible"
string but using different "clock-names" strings. The binding document
lists this as an optional property with the description  "shall be
the name of the device clock. If missing, use the device name", which
doesn't seem to make any sense.

Please fix the binding and the existing users of this, and don't introduce
any more broken instances. Since each device clock is documented to
have only one parent anyway, please just make it an anonymous clock.

	Arnd