From: Marek Vasut <marex@denx.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-arm-kernel@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>,
Fabio Estevam <fabio.estevam@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/5] crypto: Fully restore ahash request before completing
Date: Sun, 5 Jan 2014 16:33:21 +0100 [thread overview]
Message-ID: <201401051633.21894.marex@denx.de> (raw)
In-Reply-To: <20140105130529.GA26358@gondor.apana.org.au>
On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote:
> On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote:
> > When finishing the ahash request, the ahash_op_unaligned_done() will
> > call complete() on the request. Yet, this will not call the correct
> > complete callback. The correct complete callback was previously stored
> > in the requests' private data, as seen in ahash_op_unaligned(). This
> > patch restores the correct complete callback and .data field of the
> > request before calling complete() on it.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: linux-crypto@vger.kernel.org
>
> All patches applied. Thanks!
Uh, I think this was not intended to happen! We still discuss this patch will
need rework, do we not?
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] crypto: Fully restore ahash request before completing
Date: Sun, 5 Jan 2014 16:33:21 +0100 [thread overview]
Message-ID: <201401051633.21894.marex@denx.de> (raw)
In-Reply-To: <20140105130529.GA26358@gondor.apana.org.au>
On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote:
> On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote:
> > When finishing the ahash request, the ahash_op_unaligned_done() will
> > call complete() on the request. Yet, this will not call the correct
> > complete callback. The correct complete callback was previously stored
> > in the requests' private data, as seen in ahash_op_unaligned(). This
> > patch restores the correct complete callback and .data field of the
> > request before calling complete() on it.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: linux-crypto at vger.kernel.org
>
> All patches applied. Thanks!
Uh, I think this was not intended to happen! We still discuss this patch will
need rework, do we not?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-01-05 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 19:26 [PATCH 1/5] crypto: Fully restore ahash request before completing Marek Vasut
2013-12-10 19:26 ` Marek Vasut
2013-12-10 19:26 ` [PATCH V2 2/5] crypto: mxs: Remove the old DCP driver Marek Vasut
2013-12-10 19:26 ` Marek Vasut
2013-12-10 19:26 ` [PATCH V3 3/5] crypto: mxs: Add Freescale MXS " Marek Vasut
2013-12-10 19:26 ` Marek Vasut
2013-12-10 19:26 ` [PATCH 4/5] ARM: mxs: dts: Enable DCP for MXS Marek Vasut
2013-12-10 19:26 ` Marek Vasut
2013-12-10 19:26 ` [PATCH V2 5/5] crypto: Sort drivers/crypto/Makefile Marek Vasut
2013-12-10 19:26 ` Marek Vasut
2013-12-20 12:04 ` [PATCH 1/5] crypto: Fully restore ahash request before completing Herbert Xu
2013-12-20 12:04 ` Herbert Xu
2013-12-27 0:21 ` Marek Vasut
2013-12-27 0:21 ` Marek Vasut
2013-12-30 9:01 ` Herbert Xu
2013-12-30 9:01 ` Herbert Xu
2014-01-03 15:10 ` Tom Lendacky
2014-01-03 15:10 ` Tom Lendacky
2014-01-03 22:33 ` Herbert Xu
2014-01-03 22:33 ` Herbert Xu
2014-01-04 7:20 ` Marek Vasut
2014-01-04 7:20 ` Marek Vasut
2014-01-05 13:05 ` Herbert Xu
2014-01-05 13:05 ` Herbert Xu
2014-01-05 15:33 ` Marek Vasut [this message]
2014-01-05 15:33 ` Marek Vasut
2014-01-05 23:29 ` Herbert Xu
2014-01-05 23:29 ` Herbert Xu
2014-01-14 17:34 ` Marek Vasut
2014-01-14 17:34 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2013-12-01 21:20 Marek Vasut
2013-12-01 21:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401051633.21894.marex@denx.de \
--to=marex@denx.de \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.