From: Arnd Bergmann <arnd@arndb.de>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>, Chris Ball <cjb@laptop.org>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/4] mmc: tmio: bus_shift become tmio_mmc_data member
Date: Tue, 7 Jan 2014 14:40:28 +0100 [thread overview]
Message-ID: <201401071440.28355.arnd@arndb.de> (raw)
In-Reply-To: <87fvqr8ogb.wl%kuninori.morimoto.gx@renesas.com>
On Wednesday 20 November 2013, Kuninori Morimoto wrote:
> const struct mfd_cell *cell = mfd_get_cell(pdev);
> struct tmio_mmc_data *pdata;
> struct tmio_mmc_host *host;
> + struct resource *res;
> int ret = -EINVAL, irq;
>
> if (pdev->num_resources != 2)
> @@ -84,6 +85,13 @@ static int tmio_mmc_probe(struct platform_device *pdev)
> goto out;
> }
>
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res)
> + return -EINVAL;
> +
> + /* SD control register space size is 0x200, 0x400 for bus_shift=1 */
> + pdata->bus_shift = resource_size(res_ctl) >> 10;
> +
> ret = tmio_mmc_host_probe(&host, pdev, pdata);
> if (ret)
> goto cell_disable;
Unfortunately, this has introduced a build error, since you use
an incorrect variable name (res_ctl vs. res) in the last line that
was added.
Please add a fix on top.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>, Chris Ball <cjb@laptop.org>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/4] mmc: tmio: bus_shift become tmio_mmc_data member
Date: Tue, 07 Jan 2014 13:40:28 +0000 [thread overview]
Message-ID: <201401071440.28355.arnd@arndb.de> (raw)
In-Reply-To: <87fvqr8ogb.wl%kuninori.morimoto.gx@renesas.com>
On Wednesday 20 November 2013, Kuninori Morimoto wrote:
> const struct mfd_cell *cell = mfd_get_cell(pdev);
> struct tmio_mmc_data *pdata;
> struct tmio_mmc_host *host;
> + struct resource *res;
> int ret = -EINVAL, irq;
>
> if (pdev->num_resources != 2)
> @@ -84,6 +85,13 @@ static int tmio_mmc_probe(struct platform_device *pdev)
> goto out;
> }
>
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res)
> + return -EINVAL;
> +
> + /* SD control register space size is 0x200, 0x400 for bus_shift=1 */
> + pdata->bus_shift = resource_size(res_ctl) >> 10;
> +
> ret = tmio_mmc_host_probe(&host, pdev, pdata);
> if (ret)
> goto cell_disable;
Unfortunately, this has introduced a build error, since you use
an incorrect variable name (res_ctl vs. res) in the last line that
was added.
Please add a fix on top.
Arnd
next prev parent reply other threads:[~2014-01-07 13:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 8:30 [PATCH 0/4] mmc: tmio/SDHI fixup patches Kuninori Morimoto
2013-11-20 8:30 ` Kuninori Morimoto
2013-11-20 8:30 ` [PATCH 1/4] mmc: tmio: use -EPROBE_DEFER if driver can't find regulator Kuninori Morimoto
2013-11-20 8:30 ` Kuninori Morimoto
2013-11-20 8:30 ` [PATCH 2/4] mmc: tmio: bus_shift become tmio_mmc_data member Kuninori Morimoto
2013-11-20 8:30 ` Kuninori Morimoto
2014-01-07 13:40 ` Arnd Bergmann [this message]
2014-01-07 13:40 ` Arnd Bergmann
2014-01-08 1:33 ` [PATCH] mmc: tmio: fixup compile error Kuninori Morimoto
2014-01-08 1:33 ` Kuninori Morimoto
2014-01-08 4:47 ` Simon Horman
2014-01-08 4:47 ` Simon Horman
2014-01-12 16:22 ` Chris Ball
2013-11-20 8:31 ` [PATCH 3/4] mmc: tmio: add new TMIO_MMC_HAVE_HIGH_REG flags Kuninori Morimoto
2013-11-20 8:31 ` Kuninori Morimoto
2013-11-20 8:31 ` [PATCH 4/4] mmc: SDHI: add SoC specific workaround via HW version Kuninori Morimoto
2013-11-20 8:31 ` Kuninori Morimoto
2013-11-29 2:29 ` [PATCH 0/4] mmc: tmio/SDHI fixup patches Kuninori Morimoto
2013-11-29 2:29 ` Kuninori Morimoto
2013-12-10 2:56 ` Kuninori Morimoto
2013-12-10 2:56 ` Kuninori Morimoto
2013-12-12 1:45 ` Chris Ball
2013-12-12 1:45 ` Chris Ball
2013-12-12 8:26 ` Kuninori Morimoto
2013-12-12 8:26 ` Kuninori Morimoto
2013-12-13 0:11 ` Simon Horman
2013-12-13 0:11 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401071440.28355.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.