From: Arnd Bergmann <arnd@arndb.de>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs
Date: Wed, 8 Jan 2014 16:28:20 +0100 [thread overview]
Message-ID: <201401081628.21299.arnd@arndb.de> (raw)
In-Reply-To: <52CD6E1E.5040409@free-electrons.com>
On Wednesday 08 January 2014, Gregory CLEMENT wrote:
> On 08/01/2014 16:21, Wolfram Sang wrote:
> >> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> >> index 8be7e42aa4de..f424c0f89946 100644
> >> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> >> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> >> @@ -692,6 +692,10 @@ static const struct of_device_id mv64xxx_i2c_of_match_table[] = {
> >> { .compatible = "allwinner,sun4i-i2c", .data = &mv64xxx_i2c_regs_sun4i},
> >> { .compatible = "marvell,mv64xxx-i2c", .data = &mv64xxx_i2c_regs_mv64xxx},
> >> { .compatible = "marvell,mv78230-i2c", .data = &mv64xxx_i2c_regs_mv64xxx},
> >> + {
> >> + .compatible = "marvell,mv78230-a0-i2c",
> >> + .data = &mv64xxx_i2c_regs_mv64xxx
> >> + },
> >
> > I think a oneliner entry like the entries above is easier to read, but
> > that is very minor...
>
> By using one line we would break the 80 character rule,
> hat why I did in this way.
>
It's more a guideline than a strict rule. I agree that one line would
be better here, but it's not important.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs
Date: Wed, 8 Jan 2014 16:28:20 +0100 [thread overview]
Message-ID: <201401081628.21299.arnd@arndb.de> (raw)
In-Reply-To: <52CD6E1E.5040409@free-electrons.com>
On Wednesday 08 January 2014, Gregory CLEMENT wrote:
> On 08/01/2014 16:21, Wolfram Sang wrote:
> >> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> >> index 8be7e42aa4de..f424c0f89946 100644
> >> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> >> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> >> @@ -692,6 +692,10 @@ static const struct of_device_id mv64xxx_i2c_of_match_table[] = {
> >> { .compatible = "allwinner,sun4i-i2c", .data = &mv64xxx_i2c_regs_sun4i},
> >> { .compatible = "marvell,mv64xxx-i2c", .data = &mv64xxx_i2c_regs_mv64xxx},
> >> { .compatible = "marvell,mv78230-i2c", .data = &mv64xxx_i2c_regs_mv64xxx},
> >> + {
> >> + .compatible = "marvell,mv78230-a0-i2c",
> >> + .data = &mv64xxx_i2c_regs_mv64xxx
> >> + },
> >
> > I think a oneliner entry like the entries above is easier to read, but
> > that is very minor...
>
> By using one line we would break the 80 character rule,
> hat why I did in this way.
>
It's more a guideline than a strict rule. I agree that one line would
be better here, but it's not important.
Arnd
next prev parent reply other threads:[~2014-01-08 15:28 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 15:06 [PATCH v5 0/4] Fix i2c bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-08 15:06 ` Gregory CLEMENT
2014-01-08 15:06 ` [PATCH v5 3/4] i2c: mv64xxx: Fix " Gregory CLEMENT
2014-01-08 15:06 ` Gregory CLEMENT
2014-01-08 15:21 ` Wolfram Sang
2014-01-08 15:21 ` Wolfram Sang
2014-01-08 15:26 ` Gregory CLEMENT
2014-01-08 15:26 ` Gregory CLEMENT
2014-01-08 15:28 ` Arnd Bergmann [this message]
2014-01-08 15:28 ` Arnd Bergmann
2014-01-08 15:28 ` Wolfram Sang
2014-01-08 15:28 ` Wolfram Sang
2014-01-08 15:06 ` [PATCH v5 4/4] i2c: mv64xxx: Document the newly introduced Armada XP A0 compatible Gregory CLEMENT
2014-01-08 15:06 ` Gregory CLEMENT
[not found] ` <1389193589-18485-5-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-01-10 21:55 ` Jason Cooper
2014-01-10 21:55 ` Jason Cooper
[not found] ` <20140110215526.GB19878-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-01-10 23:04 ` Gregory CLEMENT
2014-01-10 23:04 ` Gregory CLEMENT
[not found] ` <1389193589-18485-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-01-08 15:06 ` [PATCH v5 1/4] ARM: mvebu: Add support to get the ID and the revision of a SoC Gregory CLEMENT
2014-01-08 15:06 ` Gregory CLEMENT
2014-01-08 15:06 ` [PATCH v5 2/4] ARM: mvebu: Add quirk for i2c for the OpenBlocks AX3-4 board Gregory CLEMENT
2014-01-08 15:06 ` Gregory CLEMENT
[not found] ` <1389193589-18485-3-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-01-08 15:22 ` Wolfram Sang
2014-01-08 15:22 ` Wolfram Sang
2014-01-08 15:28 ` Gregory CLEMENT
2014-01-08 15:28 ` Gregory CLEMENT
2014-01-10 18:22 ` Jason Cooper
2014-01-10 18:22 ` Jason Cooper
2014-01-10 19:05 ` Jason Gunthorpe
2014-01-10 19:05 ` Jason Gunthorpe
2014-01-10 19:45 ` Jason Cooper
2014-01-10 19:45 ` Jason Cooper
2014-01-10 20:08 ` Jason Cooper
2014-01-10 20:08 ` Jason Cooper
2014-01-10 20:12 ` Gregory CLEMENT
2014-01-10 20:12 ` Gregory CLEMENT
[not found] ` <52D05439.7040905-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-01-10 21:14 ` Jason Cooper
2014-01-10 21:14 ` Jason Cooper
2014-01-10 21:21 ` Gregory CLEMENT
2014-01-10 21:21 ` Gregory CLEMENT
2014-01-10 21:37 ` Jason Cooper
2014-01-10 21:37 ` Jason Cooper
[not found] ` <20140110213752.GA19878-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-01-10 21:52 ` Gregory CLEMENT
2014-01-10 21:52 ` Gregory CLEMENT
2014-01-13 15:02 ` Gregory CLEMENT
2014-01-13 15:02 ` Gregory CLEMENT
[not found] ` <20140110194550.GT19878-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-01-10 20:09 ` Gregory CLEMENT
2014-01-10 20:09 ` Gregory CLEMENT
2014-01-10 21:11 ` Jason Cooper
2014-01-10 21:11 ` Jason Cooper
2014-01-10 21:06 ` Jason Gunthorpe
2014-01-10 21:06 ` Jason Gunthorpe
2014-01-10 21:19 ` Jason Cooper
2014-01-10 21:19 ` Jason Cooper
2014-01-08 15:13 ` [PATCH v5 0/4] Fix i2c bus hang on A0 version of the Armada XP SoCs Arnd Bergmann
2014-01-08 15:13 ` Arnd Bergmann
2014-01-08 16:46 ` Gregory CLEMENT
2014-01-08 16:46 ` Gregory CLEMENT
2014-01-14 2:14 ` Jason Cooper
2014-01-14 2:14 ` Jason Cooper
2014-01-14 8:46 ` Gregory CLEMENT
2014-01-14 8:46 ` Gregory CLEMENT
[not found] ` <52D4F966.6060200-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-01-20 11:20 ` Gregory CLEMENT
2014-01-20 11:20 ` Gregory CLEMENT
2014-01-20 14:44 ` Jason Cooper
2014-01-20 14:44 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401081628.21299.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.