From: Tony Lindgren <tony@atomide.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy
Date: Wed, 8 Jan 2014 09:53:15 -0800 [thread overview]
Message-ID: <20140108175314.GC31686@atomide.com> (raw)
In-Reply-To: <1386601737-8735-5-git-send-email-heikki.krogerus@linux.intel.com>
* Heikki Krogerus <heikki.krogerus@linux.intel.com> [131209 07:10]:
> Provide a complete association for the phy and it's user
> (musb) with the new phy_lookup_table.
This seems safe to queue via the USB list:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index b0d54da..972430b 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -91,18 +91,13 @@ void __init omap_pmic_late_init(void)
> }
>
> #if defined(CONFIG_ARCH_OMAP3)
> -struct phy_consumer consumers[] = {
> - PHY_CONSUMER("musb-hdrc.0", "usb"),
> -};
> -
> -struct phy_init_data init_data = {
> - .consumers = consumers,
> - .num_consumers = ARRAY_SIZE(consumers),
> +static struct phy_lookup_table twl4030_usb_lookup = {
> + .dev_id = "musb-hdrc.0",
> + .table = PHY_LOOKUP("phy-twl4030_usb.0", NULL),
> };
>
> static struct twl4030_usb_data omap3_usb_pdata = {
> .usb_mode = T2_USB_MODE_ULPI,
> - .init_data = &init_data,
> };
>
> static int omap3_batt_table[] = {
> @@ -225,8 +220,10 @@ void __init omap3_pmic_get_config(struct twl4030_platform_data *pmic_data,
> }
>
> /* Common platform data configurations */
> - if (pdata_flags & TWL_COMMON_PDATA_USB && !pmic_data->usb)
> + if (pdata_flags & TWL_COMMON_PDATA_USB && !pmic_data->usb) {
> + phy_add_lookup_table(&twl4030_usb_lookup);
> pmic_data->usb = &omap3_usb_pdata;
> + }
>
> if (pdata_flags & TWL_COMMON_PDATA_BCI && !pmic_data->bci)
> pmic_data->bci = &omap3_bci_pdata;
> --
> 1.8.5.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy
Date: Wed, 8 Jan 2014 09:53:15 -0800 [thread overview]
Message-ID: <20140108175314.GC31686@atomide.com> (raw)
In-Reply-To: <1386601737-8735-5-git-send-email-heikki.krogerus@linux.intel.com>
* Heikki Krogerus <heikki.krogerus@linux.intel.com> [131209 07:10]:
> Provide a complete association for the phy and it's user
> (musb) with the new phy_lookup_table.
This seems safe to queue via the USB list:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index b0d54da..972430b 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -91,18 +91,13 @@ void __init omap_pmic_late_init(void)
> }
>
> #if defined(CONFIG_ARCH_OMAP3)
> -struct phy_consumer consumers[] = {
> - PHY_CONSUMER("musb-hdrc.0", "usb"),
> -};
> -
> -struct phy_init_data init_data = {
> - .consumers = consumers,
> - .num_consumers = ARRAY_SIZE(consumers),
> +static struct phy_lookup_table twl4030_usb_lookup = {
> + .dev_id = "musb-hdrc.0",
> + .table = PHY_LOOKUP("phy-twl4030_usb.0", NULL),
> };
>
> static struct twl4030_usb_data omap3_usb_pdata = {
> .usb_mode = T2_USB_MODE_ULPI,
> - .init_data = &init_data,
> };
>
> static int omap3_batt_table[] = {
> @@ -225,8 +220,10 @@ void __init omap3_pmic_get_config(struct twl4030_platform_data *pmic_data,
> }
>
> /* Common platform data configurations */
> - if (pdata_flags & TWL_COMMON_PDATA_USB && !pmic_data->usb)
> + if (pdata_flags & TWL_COMMON_PDATA_USB && !pmic_data->usb) {
> + phy_add_lookup_table(&twl4030_usb_lookup);
> pmic_data->usb = &omap3_usb_pdata;
> + }
>
> if (pdata_flags & TWL_COMMON_PDATA_BCI && !pmic_data->bci)
> pmic_data->bci = &omap3_bci_pdata;
> --
> 1.8.5.1
>
next prev parent reply other threads:[~2014-01-08 17:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 15:08 [PATCH 0/5] phy: remove the need for the phys to know about their users Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
2013-12-09 15:08 ` [PATCH 1/5] phy: unify the phy name parameters Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
2013-12-09 15:08 ` [PATCH 2/5] phy: add support for indexed lookup Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
2013-12-16 11:02 ` Kishon Vijay Abraham I
2013-12-16 11:02 ` Kishon Vijay Abraham I
2013-12-16 11:02 ` Kishon Vijay Abraham I
2013-12-16 14:32 ` Heikki Krogerus
2013-12-16 14:32 ` Heikki Krogerus
2014-01-07 13:40 ` Kishon Vijay Abraham I
2014-01-07 13:40 ` Kishon Vijay Abraham I
2014-01-07 13:40 ` Kishon Vijay Abraham I
2014-01-14 14:23 ` Heikki Krogerus
2014-01-14 14:23 ` Heikki Krogerus
2014-01-15 14:11 ` Kishon Vijay Abraham I
2014-01-15 14:11 ` Kishon Vijay Abraham I
2014-01-15 14:11 ` Kishon Vijay Abraham I
2013-12-09 15:08 ` [PATCH 3/5] phy: improved lookup method Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
2013-12-09 15:08 ` [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
2013-12-16 11:04 ` Kishon Vijay Abraham I
2013-12-16 11:04 ` Kishon Vijay Abraham I
2013-12-16 11:04 ` Kishon Vijay Abraham I
2013-12-16 14:43 ` Heikki Krogerus
2013-12-16 14:43 ` Heikki Krogerus
2014-01-07 13:01 ` Kishon Vijay Abraham I
2014-01-07 13:01 ` Kishon Vijay Abraham I
2014-01-07 13:01 ` Kishon Vijay Abraham I
2014-01-14 14:38 ` Heikki Krogerus
2014-01-14 14:38 ` Heikki Krogerus
2014-01-15 14:11 ` Kishon Vijay Abraham I
2014-01-15 14:11 ` Kishon Vijay Abraham I
2014-01-15 14:11 ` Kishon Vijay Abraham I
2014-01-16 11:58 ` Heikki Krogerus
2014-01-16 11:58 ` Heikki Krogerus
2014-01-08 17:53 ` Tony Lindgren [this message]
2014-01-08 17:53 ` Tony Lindgren
2013-12-09 15:08 ` [PATCH] phy: remove the old lookup method Heikki Krogerus
2013-12-09 15:08 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108175314.GC31686@atomide.com \
--to=tony@atomide.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.