From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
linux-doc@vger.kernel.org, dev@linux-sunxi.org,
linux-kernel@vger.kernel.org,
Boris BREZILLON <b.brezillon@overkiz.com>,
linux-mtd@lists.infradead.org, Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC PATCH 6/9] mtd: nand: add sunxi NFC dt bindings doc
Date: Wed, 8 Jan 2014 22:28:55 +0100 [thread overview]
Message-ID: <201401082228.55807.arnd@arndb.de> (raw)
In-Reply-To: <1389190924-26226-7-git-send-email-b.brezillon@overkiz.com>
On Wednesday 08 January 2014, Boris BREZILLON wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt
> @@ -0,0 +1,71 @@
> +Allwinner NAND Flash Controller (NFC)
> +
> +Required properties:
> +- compatible : "allwinner,sun4i-nfc".
> +- reg : shall contain registers location and length for data and reg.
> +- interrupts : shall define the NFC interrupt.
> +- #address-cells: shall be set to 1. Encode the nand CS.
> +- #size-cells : shall be set to 0.
> +- clocks : shall reference NFC clocks.
> +- clock-names : NFC internal clock names. Shall contain :
> + * "ahb_clk" : AHB gating clock
> + * "sclk" : NFC clock
> +
One small request: Can we try to avoid the "NFC" name here? I think it's
too overloaded and people may confuse it with near-field communication,
which I'm sure will be supported in sunxi based devices at some point.
It doesn't hurt to also mention that the function block is called
nfc, but I think references to it are better named "nand", which is
less confusing.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 6/9] mtd: nand: add sunxi NFC dt bindings doc
Date: Wed, 8 Jan 2014 22:28:55 +0100 [thread overview]
Message-ID: <201401082228.55807.arnd@arndb.de> (raw)
In-Reply-To: <1389190924-26226-7-git-send-email-b.brezillon@overkiz.com>
On Wednesday 08 January 2014, Boris BREZILLON wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt
> @@ -0,0 +1,71 @@
> +Allwinner NAND Flash Controller (NFC)
> +
> +Required properties:
> +- compatible : "allwinner,sun4i-nfc".
> +- reg : shall contain registers location and length for data and reg.
> +- interrupts : shall define the NFC interrupt.
> +- #address-cells: shall be set to 1. Encode the nand CS.
> +- #size-cells : shall be set to 0.
> +- clocks : shall reference NFC clocks.
> +- clock-names : NFC internal clock names. Shall contain :
> + * "ahb_clk" : AHB gating clock
> + * "sclk" : NFC clock
> +
One small request: Can we try to avoid the "NFC" name here? I think it's
too overloaded and people may confuse it with near-field communication,
which I'm sure will be supported in sunxi based devices at some point.
It doesn't hurt to also mention that the function block is called
nfc, but I think references to it are better named "nand", which is
less confusing.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Boris BREZILLON <b.brezillon@overkiz.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
dev@linux-sunxi.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH 6/9] mtd: nand: add sunxi NFC dt bindings doc
Date: Wed, 8 Jan 2014 22:28:55 +0100 [thread overview]
Message-ID: <201401082228.55807.arnd@arndb.de> (raw)
In-Reply-To: <1389190924-26226-7-git-send-email-b.brezillon@overkiz.com>
On Wednesday 08 January 2014, Boris BREZILLON wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt
> @@ -0,0 +1,71 @@
> +Allwinner NAND Flash Controller (NFC)
> +
> +Required properties:
> +- compatible : "allwinner,sun4i-nfc".
> +- reg : shall contain registers location and length for data and reg.
> +- interrupts : shall define the NFC interrupt.
> +- #address-cells: shall be set to 1. Encode the nand CS.
> +- #size-cells : shall be set to 0.
> +- clocks : shall reference NFC clocks.
> +- clock-names : NFC internal clock names. Shall contain :
> + * "ahb_clk" : AHB gating clock
> + * "sclk" : NFC clock
> +
One small request: Can we try to avoid the "NFC" name here? I think it's
too overloaded and people may confuse it with near-field communication,
which I'm sure will be supported in sunxi based devices at some point.
It doesn't hurt to also mention that the function block is called
nfc, but I think references to it are better named "nand", which is
less confusing.
Arnd
next prev parent reply other threads:[~2014-01-08 21:28 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 14:21 [RFC PATCH 0/9] mtd: nand: add sunxi NAND Flash Controller support Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
[not found] ` < 1389190924-26226-4-git-send-email-b.brezillon@overkiz.com>
2014-01-08 14:21 ` [RFC PATCH 1/9] mtd: nand: retrieve ECC requirements from Hynix READ ID byte 4 Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-23 1:49 ` Brian Norris
2014-01-23 1:49 ` Brian Norris
2014-01-23 1:49 ` Brian Norris
2014-01-29 10:29 ` boris brezillon
2014-01-29 10:29 ` boris brezillon
2014-01-29 10:29 ` boris brezillon
2014-01-29 10:29 ` boris brezillon
2014-02-05 13:53 ` Boris BREZILLON
2014-02-05 13:53 ` Boris BREZILLON
2014-02-05 13:53 ` Boris BREZILLON
2014-02-05 13:53 ` Boris BREZILLON
2014-01-08 14:21 ` [RFC PATCH 2/9] mtd: nand: define struct nand_timings Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:21 ` [RFC PATCH 3/9] of: mtd: add NAND timings retrieval support Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 16:30 ` Rob Herring
2014-01-08 16:30 ` Rob Herring
2014-01-08 16:30 ` Rob Herring
2014-01-08 16:36 ` boris brezillon
2014-01-08 16:36 ` boris brezillon
2014-01-08 16:36 ` boris brezillon
2014-01-08 18:34 ` Jason Gunthorpe
2014-01-08 18:34 ` Jason Gunthorpe
2014-01-08 18:34 ` Jason Gunthorpe
2014-01-08 19:00 ` boris brezillon
2014-01-08 19:00 ` boris brezillon
2014-01-08 19:00 ` boris brezillon
2014-01-08 19:00 ` boris brezillon
2014-01-08 19:13 ` Jason Gunthorpe
2014-01-08 19:13 ` Jason Gunthorpe
2014-01-08 19:13 ` Jason Gunthorpe
2014-01-08 19:13 ` Jason Gunthorpe
2014-01-09 8:36 ` boris brezillon
2014-01-09 8:36 ` boris brezillon
2014-01-09 8:36 ` boris brezillon
2014-01-09 8:36 ` boris brezillon
2014-01-09 17:35 ` Jason Gunthorpe
2014-01-09 17:35 ` Jason Gunthorpe
2014-01-09 17:35 ` Jason Gunthorpe
2014-01-15 15:09 ` boris brezillon
2014-01-15 15:09 ` boris brezillon
2014-01-15 15:09 ` boris brezillon
2014-01-15 17:03 ` boris brezillon
2014-01-15 17:03 ` boris brezillon
2014-01-15 17:03 ` boris brezillon
2014-01-21 22:57 ` Jason Gunthorpe
2014-01-21 22:57 ` Jason Gunthorpe
2014-01-21 22:57 ` Jason Gunthorpe
2014-02-04 17:02 ` Grant Likely
2014-02-04 17:02 ` Grant Likely
2014-01-08 14:21 ` [RFC PATCH 4/9] of: mtd: add NAND timings bindings documentation Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:21 ` Boris BREZILLON
2014-01-08 14:22 ` [RFC PATCH 5/9] mtd: nand: add sunxi NFC support Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 19:21 ` boris brezillon
2014-01-08 19:21 ` boris brezillon
2014-01-08 19:21 ` boris brezillon
2014-01-08 14:22 ` [RFC PATCH 6/9] mtd: nand: add sunxi NFC dt bindings doc Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 21:28 ` Arnd Bergmann [this message]
2014-01-08 21:28 ` Arnd Bergmann
2014-01-08 21:28 ` Arnd Bergmann
2014-01-09 8:31 ` boris brezillon
2014-01-09 8:31 ` boris brezillon
2014-01-09 8:31 ` boris brezillon
2014-01-09 10:00 ` Arnd Bergmann
2014-01-09 10:00 ` Arnd Bergmann
2014-01-09 10:00 ` Arnd Bergmann
2014-01-08 14:22 ` [RFC PATCH 7/9] ARM: dt/sunxi: add NFC node to Allwinner A20 SoC Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 14:22 ` [RFC PATCH 8/9] ARM: dt/sunxi: add NFC pinctrl pin definitions Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 14:22 ` Boris BREZILLON
2014-01-08 15:28 ` [RFC PATCH 9/9] ARM: sunxi/dt: enable NAND on cubietruck board Boris BREZILLON
2014-01-08 15:28 ` Boris BREZILLON
2014-01-08 15:28 ` Boris BREZILLON
2014-01-08 15:28 ` Boris BREZILLON
2014-01-08 15:30 ` boris brezillon
2014-01-08 15:30 ` boris brezillon
2014-01-08 15:30 ` boris brezillon
2014-01-11 13:38 ` [RFC PATCH 0/9] mtd: nand: add sunxi NAND Flash Controller support boris brezillon
2014-01-11 13:38 ` boris brezillon
2014-01-11 13:38 ` boris brezillon
2014-01-11 13:38 ` boris brezillon
[not found] ` <1389449230.19197.2.camel@localhost>
[not found] ` <52D1541F.4040400@overkiz.com>
[not found] ` <1389456075.20989.11.camel@localhost>
[not found] ` <1389474709.22660.4.camel@localhost>
2014-01-13 9:02 ` [linux-sunxi] " boris brezillon
2014-01-13 9:02 ` boris brezillon
2014-01-13 9:48 ` Henrik Nordström
2014-01-13 9:48 ` Henrik Nordström
[not found] ` <6de6ead1-e437-410b-91c0-74afb37dbf39@googlegroups.com>
2014-01-21 18:13 ` Henrik Nordström
2014-01-21 18:13 ` Henrik Nordström
2014-01-21 20:55 ` Henrik Nordström
2014-01-21 20:55 ` Henrik Nordström
2014-01-29 15:11 ` Michal Suchanek
2014-01-29 15:11 ` Michal Suchanek
2014-01-29 15:43 ` boris brezillon dev
2014-01-29 15:43 ` boris brezillon dev
2014-01-29 16:08 ` Michal Suchanek
2014-01-29 16:08 ` Michal Suchanek
2014-01-29 16:55 ` boris brezillon dev
2014-01-29 16:55 ` boris brezillon dev
2014-01-23 15:22 ` Rob Herring
2014-01-23 15:22 ` Rob Herring
2014-01-23 15:22 ` Rob Herring
2014-01-29 10:20 ` boris brezillon
2014-01-29 10:20 ` boris brezillon
2014-01-29 10:20 ` boris brezillon
2014-01-29 10:20 ` boris brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401082228.55807.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=b.brezillon@overkiz.com \
--cc=dev@linux-sunxi.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=maxime.ripard@free-electrons.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.