From: Mark Brown <broonie@kernel.org>
To: Leon Romanovsky <leon@leon.nu>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/8] ASoC: alc5632: Use params_width() rather than memory format
Date: Thu, 9 Jan 2014 10:33:16 +0000 [thread overview]
Message-ID: <20140109103316.GD31886@sirena.org.uk> (raw)
In-Reply-To: <CALq1K=Kss-NUYB-mmhOjCbxSjhaRO62GpnY95rFMzruo35i=fw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 327 bytes --]
On Thu, Jan 09, 2014 at 06:55:17AM +0200, Leon Romanovsky wrote:
> On Wed, Jan 8, 2014 at 9:51 PM, Mark Brown <broonie@kernel.org> wrote:
> > + switch (params_width(params)) {
> > + case 16:
> May be the better way will be to use define here and not hard coded value?
No, it really is actually a number of bits.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-01-09 10:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 19:51 [PATCH 1/8] ASoC: alc5623: Use params_width() rather than memory format Mark Brown
2014-01-08 19:51 ` [PATCH 2/8] ASoC: alc5632: " Mark Brown
2014-01-09 4:55 ` Leon Romanovsky
2014-01-09 10:16 ` Lars-Peter Clausen
2014-01-09 10:33 ` Mark Brown [this message]
2014-01-10 13:44 ` Leon Romanovsky
2014-01-10 13:51 ` Takashi Iwai
2014-01-08 19:51 ` [PATCH 3/8] ASoC: cs42l51: " Mark Brown
2014-01-08 19:51 ` [PATCH 4/8] ASoC: da7210: " Mark Brown
2014-01-08 19:52 ` [PATCH 5/8] ASoC: da7213: " Mark Brown
2014-01-08 19:52 ` [PATCH 6/8] ASoC: da732x: " Mark Brown
2014-01-08 19:52 ` [PATCH 7/8] ASoC: da9055: " Mark Brown
2014-01-08 19:52 ` [PATCH 8/8] ASoC: isabelle: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109103316.GD31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=leon@leon.nu \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.