Re: [PATCH 2/8] ASoC: alc5632: Use params_width() rather than memory format

[Lars-Peter Clausen <lars@metafoo.de>]

On 01/09/2014 05:55 AM, Leon Romanovsky wrote:
> Hi Mark,
> 
> On Wed, Jan 8, 2014 at 9:51 PM, Mark Brown <broonie@kernel.org> wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Signed-off-by: Mark Brown <broonie@linaro.org>
>> ---
>>  sound/soc/codecs/alc5632.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
>> index 19e9f222d09c..fb001c56cf8d 100644
>> --- a/sound/soc/codecs/alc5632.c
>> +++ b/sound/soc/codecs/alc5632.c
>> @@ -869,14 +869,14 @@ static int alc5632_pcm_hw_params(struct snd_pcm_substream *substream,
>>         iface &= ~ALC5632_DAI_I2S_DL_MASK;
>>
>>         /* bit size */
>> -       switch (params_format(params)) {
>> -       case SNDRV_PCM_FORMAT_S16_LE:
>> +       switch (params_width(params)) {
>> +       case 16:
> May be the better way will be to use define here and not hard coded value?

like #define SIXTEEN 16? ;)