* [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
@ 2014-01-09 9:41 ` Nicolin Chen
0 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2014-01-09 9:41 UTC (permalink / raw)
To: broonie, timur; +Cc: tiwai, alsa-devel, linuxppc-dev, lgirdwood
For those platforms using DAI master mode like I2S, it's better to pre-set
a default slot number so that there's no need for these common cases to set
the slot number from its machine driver any more.
Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
---
sound/soc/fsl/fsl_ssi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 94dedcb..57ab45b 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
if (ssi_private->imx_ac97)
fsl_ssi_setup_ac97(ssi_private);
+ /* Set a default slot number so that there is no need for those common
+ * cases like I2S mode to call the extra set_tdm_slot() any more.
+ */
+ if (!ssi_private->imx_ac97) {
+ write_ssi_mask(&ssi->stccr, CCSR_SSI_SxCCR_DC_MASK,
+ CCSR_SSI_SxCCR_DC(2));
+ write_ssi_mask(&ssi->srccr, CCSR_SSI_SxCCR_DC_MASK,
+ CCSR_SSI_SxCCR_DC(2));
+ }
+
return 0;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
@ 2014-01-09 9:41 ` Nicolin Chen
0 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2014-01-09 9:41 UTC (permalink / raw)
To: broonie, timur; +Cc: tiwai, alsa-devel, linuxppc-dev, lgirdwood, perex
For those platforms using DAI master mode like I2S, it's better to pre-set
a default slot number so that there's no need for these common cases to set
the slot number from its machine driver any more.
Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
---
sound/soc/fsl/fsl_ssi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 94dedcb..57ab45b 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
if (ssi_private->imx_ac97)
fsl_ssi_setup_ac97(ssi_private);
+ /* Set a default slot number so that there is no need for those common
+ * cases like I2S mode to call the extra set_tdm_slot() any more.
+ */
+ if (!ssi_private->imx_ac97) {
+ write_ssi_mask(&ssi->stccr, CCSR_SSI_SxCCR_DC_MASK,
+ CCSR_SSI_SxCCR_DC(2));
+ write_ssi_mask(&ssi->srccr, CCSR_SSI_SxCCR_DC_MASK,
+ CCSR_SSI_SxCCR_DC(2));
+ }
+
return 0;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
2014-01-09 9:41 ` Nicolin Chen
@ 2014-01-09 10:24 ` Fabio Estevam
-1 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-09 10:24 UTC (permalink / raw)
To: Nicolin Chen
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Timur Tabi,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org
On Thu, Jan 9, 2014 at 7:41 AM, Nicolin Chen <Guangyu.Chen@freescale.com> wrote:
> For those platforms using DAI master mode like I2S, it's better to pre-set
> a default slot number so that there's no need for these common cases to set
> the slot number from its machine driver any more.
>
> Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
> ---
> sound/soc/fsl/fsl_ssi.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 94dedcb..57ab45b 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
> if (ssi_private->imx_ac97)
> fsl_ssi_setup_ac97(ssi_private);
>
> + /* Set a default slot number so that there is no need for those common
> + * cases like I2S mode to call the extra set_tdm_slot() any more.
> + */
Incorrect style for multi-line comment.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
@ 2014-01-09 10:24 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-09 10:24 UTC (permalink / raw)
To: Nicolin Chen
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Timur Tabi,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org
On Thu, Jan 9, 2014 at 7:41 AM, Nicolin Chen <Guangyu.Chen@freescale.com> wrote:
> For those platforms using DAI master mode like I2S, it's better to pre-set
> a default slot number so that there's no need for these common cases to set
> the slot number from its machine driver any more.
>
> Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
> ---
> sound/soc/fsl/fsl_ssi.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 94dedcb..57ab45b 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
> if (ssi_private->imx_ac97)
> fsl_ssi_setup_ac97(ssi_private);
>
> + /* Set a default slot number so that there is no need for those common
> + * cases like I2S mode to call the extra set_tdm_slot() any more.
> + */
Incorrect style for multi-line comment.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
2014-01-09 10:24 ` [alsa-devel] " Fabio Estevam
@ 2014-01-09 10:34 ` Nicolin Chen
-1 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2014-01-09 10:34 UTC (permalink / raw)
To: Fabio Estevam
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Timur Tabi,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org
Hi Fabio,
On Thu, Jan 09, 2014 at 08:24:24AM -0200, Fabio Estevam wrote:
> On Thu, Jan 9, 2014 at 7:41 AM, Nicolin Chen <Guangyu.Chen@freescale.com> wrote:
> > For those platforms using DAI master mode like I2S, it's better to pre-set
> > a default slot number so that there's no need for these common cases to set
> > the slot number from its machine driver any more.
> >
> > Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
> > ---
> > sound/soc/fsl/fsl_ssi.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> > index 94dedcb..57ab45b 100644
> > --- a/sound/soc/fsl/fsl_ssi.c
> > +++ b/sound/soc/fsl/fsl_ssi.c
> > @@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
> > if (ssi_private->imx_ac97)
> > fsl_ssi_setup_ac97(ssi_private);
> >
> > + /* Set a default slot number so that there is no need for those common
> > + * cases like I2S mode to call the extra set_tdm_slot() any more.
> > + */
>
> Incorrect style for multi-line comment.
Is this for the initial line? The CodingStyle contains two types of multi-line
comment, one of which drops the initial line just like mine, even though it's
saying 'For files in net/ and drivers/net/ the preferred style', so I thought
it shouldn't be quite bother.
I don't mind to add it up though.
Thank you,
Nicolin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
@ 2014-01-09 10:34 ` Nicolin Chen
0 siblings, 0 replies; 8+ messages in thread
From: Nicolin Chen @ 2014-01-09 10:34 UTC (permalink / raw)
To: Fabio Estevam
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Timur Tabi,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org
Hi Fabio,
On Thu, Jan 09, 2014 at 08:24:24AM -0200, Fabio Estevam wrote:
> On Thu, Jan 9, 2014 at 7:41 AM, Nicolin Chen <Guangyu.Chen@freescale.com> wrote:
> > For those platforms using DAI master mode like I2S, it's better to pre-set
> > a default slot number so that there's no need for these common cases to set
> > the slot number from its machine driver any more.
> >
> > Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
> > ---
> > sound/soc/fsl/fsl_ssi.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> > index 94dedcb..57ab45b 100644
> > --- a/sound/soc/fsl/fsl_ssi.c
> > +++ b/sound/soc/fsl/fsl_ssi.c
> > @@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
> > if (ssi_private->imx_ac97)
> > fsl_ssi_setup_ac97(ssi_private);
> >
> > + /* Set a default slot number so that there is no need for those common
> > + * cases like I2S mode to call the extra set_tdm_slot() any more.
> > + */
>
> Incorrect style for multi-line comment.
Is this for the initial line? The CodingStyle contains two types of multi-line
comment, one of which drops the initial line just like mine, even though it's
saying 'For files in net/ and drivers/net/ the preferred style', so I thought
it shouldn't be quite bother.
I don't mind to add it up though.
Thank you,
Nicolin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
2014-01-09 10:34 ` [alsa-devel] " Nicolin Chen
@ 2014-01-09 10:40 ` Fabio Estevam
-1 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-09 10:40 UTC (permalink / raw)
To: Nicolin Chen
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Timur Tabi,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org
On Thu, Jan 9, 2014 at 8:34 AM, Nicolin Chen <Guangyu.Chen@freescale.com> wrote:
> Is this for the initial line? The CodingStyle contains two types of multi-line
Yes, correct.
> comment, one of which drops the initial line just like mine, even though it's
> saying 'For files in net/ and drivers/net/ the preferred style', so I thought
> it shouldn't be quite bother.
Yes, net and drivers/net are different and checkpatch reports it accordingly.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
@ 2014-01-09 10:40 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2014-01-09 10:40 UTC (permalink / raw)
To: Nicolin Chen
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Timur Tabi,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org
On Thu, Jan 9, 2014 at 8:34 AM, Nicolin Chen <Guangyu.Chen@freescale.com> wrote:
> Is this for the initial line? The CodingStyle contains two types of multi-line
Yes, correct.
> comment, one of which drops the initial line just like mine, even though it's
> saying 'For files in net/ and drivers/net/ the preferred style', so I thought
> it shouldn't be quite bother.
Yes, net and drivers/net are different and checkpatch reports it accordingly.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-01-09 10:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-09 9:41 [PATCH] ASoC: fsl_ssi: Set default slot number for common cases Nicolin Chen
2014-01-09 9:41 ` Nicolin Chen
2014-01-09 10:24 ` Fabio Estevam
2014-01-09 10:24 ` [alsa-devel] " Fabio Estevam
2014-01-09 10:34 ` Nicolin Chen
2014-01-09 10:34 ` [alsa-devel] " Nicolin Chen
2014-01-09 10:40 ` Fabio Estevam
2014-01-09 10:40 ` [alsa-devel] " Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.