* [PATCH] Staging: rts5139: Fixed style issues
@ 2014-01-06 14:05 Morgan Creekmore
2014-01-09 18:44 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Morgan Creekmore @ 2014-01-06 14:05 UTC (permalink / raw)
To: gamingrobot; +Cc: gregkh, devel, linux-kernel
Fixed style issues for lines over 80 chars
Signed-off-by: Morgan Creekmore <gamingrobot@gmail.com>
---
drivers/staging/rts5139/rts51x_card.c | 10 +++++-----
drivers/staging/rts5139/rts51x_card.h | 8 ++++----
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x_card.c b/drivers/staging/rts5139/rts51x_card.c
index 509d83e..03456d9 100644
--- a/drivers/staging/rts5139/rts51x_card.c
+++ b/drivers/staging/rts5139/rts51x_card.c
@@ -373,7 +373,7 @@ void rts51x_release_cards(struct rts51x_chip *chip)
static inline u8 double_depth(u8 depth)
{
- return ((depth > 1) ? (depth - 1) : depth);
+ return (depth > 1) ? (depth - 1) : depth;
}
int rts51x_switch_ssc_clock(struct rts51x_chip *chip, int clk)
@@ -653,8 +653,8 @@ int rts51x_switch_normal_clock(struct rts51x_chip *chip, int clk)
return STATUS_SUCCESS;
}
-int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip, u32 sec_addr,
- u16 sec_cnt)
+int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip,
+ u32 sec_addr, u16 sec_cnt)
{
int retval;
unsigned int lun = SCSI_LUN(srb);
@@ -770,8 +770,8 @@ void rts51x_eject_card(struct rts51x_chip *chip, unsigned int lun)
XD_INT | MS_INT | SD_INT);
}
-void rts51x_trans_dma_enable(enum dma_data_direction dir, struct rts51x_chip *chip,
- u32 byte_cnt, u8 pack_size)
+void rts51x_trans_dma_enable(enum dma_data_direction dir,
+ struct rts51x_chip *chip, u32 byte_cnt, u8 pack_size)
{
if (pack_size > DMA_1024)
pack_size = DMA_512;
diff --git a/drivers/staging/rts5139/rts51x_card.h b/drivers/staging/rts5139/rts51x_card.h
index e62b25c..df8816e 100644
--- a/drivers/staging/rts5139/rts51x_card.h
+++ b/drivers/staging/rts5139/rts51x_card.h
@@ -743,13 +743,13 @@ void rts51x_init_cards(struct rts51x_chip *chip);
void rts51x_release_cards(struct rts51x_chip *chip);
int rts51x_switch_ssc_clock(struct rts51x_chip *chip, int clk);
int rts51x_switch_normal_clock(struct rts51x_chip *chip, int clk);
-int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip, u32 sec_addr,
- u16 sec_cnt);
+int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip,
+ u32 sec_addr, u16 sec_cnt);
u8 rts51x_get_lun_card(struct rts51x_chip *chip, unsigned int lun);
int rts51x_select_card(struct rts51x_chip *chip, int card);
void rts51x_eject_card(struct rts51x_chip *chip, unsigned int lun);
-void rts51x_trans_dma_enable(enum dma_data_direction dir, struct rts51x_chip *chip,
- u32 byte_cnt, u8 pack_size);
+void rts51x_trans_dma_enable(enum dma_data_direction dir,
+ struct rts51x_chip *chip, u32 byte_cnt, u8 pack_size);
int rts51x_enable_card_clock(struct rts51x_chip *chip, u8 card);
int rts51x_card_power_on(struct rts51x_chip *chip, u8 card);
int rts51x_toggle_gpio(struct rts51x_chip *chip, u8 gpio);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: rts5139: Fixed style issues
2014-01-06 14:05 [PATCH] Staging: rts5139: Fixed style issues Morgan Creekmore
@ 2014-01-09 18:44 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-01-09 18:44 UTC (permalink / raw)
To: Morgan Creekmore; +Cc: devel, linux-kernel
On Mon, Jan 06, 2014 at 07:05:09AM -0700, Morgan Creekmore wrote:
> Fixed style issues for lines over 80 chars
>
> Signed-off-by: Morgan Creekmore <gamingrobot@gmail.com>
> ---
> drivers/staging/rts5139/rts51x_card.c | 10 +++++-----
> drivers/staging/rts5139/rts51x_card.h | 8 ++++----
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rts5139/rts51x_card.c b/drivers/staging/rts5139/rts51x_card.c
> index 509d83e..03456d9 100644
> --- a/drivers/staging/rts5139/rts51x_card.c
> +++ b/drivers/staging/rts5139/rts51x_card.c
> @@ -373,7 +373,7 @@ void rts51x_release_cards(struct rts51x_chip *chip)
>
> static inline u8 double_depth(u8 depth)
> {
> - return ((depth > 1) ? (depth - 1) : depth);
> + return (depth > 1) ? (depth - 1) : depth;
This fix isn't what you said you were doing in the above changelog
description :(
Please be correct in your changelogs.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-09 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-06 14:05 [PATCH] Staging: rts5139: Fixed style issues Morgan Creekmore
2014-01-09 18:44 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.