From: Will Deacon <will.deacon@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: mark.rutland@arm.com,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ashwin Chaugule <ashwinc@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Neil Leeder <nleeder@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs
Date: Fri, 10 Jan 2014 11:01:14 +0000 [thread overview]
Message-ID: <20140110110114.GC10455@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <52CEFF18.2070501@codeaurora.org>
On Thu, Jan 09, 2014 at 07:57:12PM +0000, Stephen Boyd wrote:
> (Adding DT reviewers)
>
> On 01/09/14 03:04, Will Deacon wrote:
> > On Wed, Jan 08, 2014 at 10:59:40PM +0000, Stephen Boyd wrote:
> >
> >> +static int krait_pmu_init(struct arm_pmu *cpu_pmu)
> >> +{
> >> + u32 id = read_cpuid_id() & 0xffffff00;
> >> +
> >> + armv7pmu_init(cpu_pmu);
> >> + cpu_pmu->name = "ARMv7 Krait";
> >> + /* Some early versions of Krait don't support PC write events */
> >> + if (id == 0x511f0400 || id == 0x510f0600)
> >> + cpu_pmu->map_event = krait_map_event_no_branch;
> > Hmm, I'd really rather this information came via the DT. In fact, you could
> > just drop the branch event from your main map_event_function and keep things
> > simple. It depends how badly you want to advertise it in perf list :)
> >
>
> Not every version of Krait is missing support for this event, so I'd
> like to keep it so things like perf stat show branch counts. How about I
> add a bool property to the pmu node indicating that this PMU is missing
> support for the PC write events? Something like "no-pc-write"?
Perhaps, although I think it should be qualcomm-specific, so something like
"qcom,krait-no-pc-write"? Again, I'd be glad to hear something from a DT
reviewer on this.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs
Date: Fri, 10 Jan 2014 11:01:14 +0000 [thread overview]
Message-ID: <20140110110114.GC10455@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <52CEFF18.2070501@codeaurora.org>
On Thu, Jan 09, 2014 at 07:57:12PM +0000, Stephen Boyd wrote:
> (Adding DT reviewers)
>
> On 01/09/14 03:04, Will Deacon wrote:
> > On Wed, Jan 08, 2014 at 10:59:40PM +0000, Stephen Boyd wrote:
> >
> >> +static int krait_pmu_init(struct arm_pmu *cpu_pmu)
> >> +{
> >> + u32 id = read_cpuid_id() & 0xffffff00;
> >> +
> >> + armv7pmu_init(cpu_pmu);
> >> + cpu_pmu->name = "ARMv7 Krait";
> >> + /* Some early versions of Krait don't support PC write events */
> >> + if (id == 0x511f0400 || id == 0x510f0600)
> >> + cpu_pmu->map_event = krait_map_event_no_branch;
> > Hmm, I'd really rather this information came via the DT. In fact, you could
> > just drop the branch event from your main map_event_function and keep things
> > simple. It depends how badly you want to advertise it in perf list :)
> >
>
> Not every version of Krait is missing support for this event, so I'd
> like to keep it so things like perf stat show branch counts. How about I
> add a bool property to the pmu node indicating that this PMU is missing
> support for the PC write events? Something like "no-pc-write"?
Perhaps, although I think it should be qualcomm-specific, so something like
"qcom,krait-no-pc-write"? Again, I'd be glad to hear something from a DT
reviewer on this.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Neil Leeder <nleeder@codeaurora.org>,
Ashwin Chaugule <ashwinc@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
mark.rutland@arm.com
Subject: Re: [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs
Date: Fri, 10 Jan 2014 11:01:14 +0000 [thread overview]
Message-ID: <20140110110114.GC10455@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <52CEFF18.2070501@codeaurora.org>
On Thu, Jan 09, 2014 at 07:57:12PM +0000, Stephen Boyd wrote:
> (Adding DT reviewers)
>
> On 01/09/14 03:04, Will Deacon wrote:
> > On Wed, Jan 08, 2014 at 10:59:40PM +0000, Stephen Boyd wrote:
> >
> >> +static int krait_pmu_init(struct arm_pmu *cpu_pmu)
> >> +{
> >> + u32 id = read_cpuid_id() & 0xffffff00;
> >> +
> >> + armv7pmu_init(cpu_pmu);
> >> + cpu_pmu->name = "ARMv7 Krait";
> >> + /* Some early versions of Krait don't support PC write events */
> >> + if (id == 0x511f0400 || id == 0x510f0600)
> >> + cpu_pmu->map_event = krait_map_event_no_branch;
> > Hmm, I'd really rather this information came via the DT. In fact, you could
> > just drop the branch event from your main map_event_function and keep things
> > simple. It depends how badly you want to advertise it in perf list :)
> >
>
> Not every version of Krait is missing support for this event, so I'd
> like to keep it so things like perf stat show branch counts. How about I
> add a bool property to the pmu node indicating that this PMU is missing
> support for the PC write events? Something like "no-pc-write"?
Perhaps, although I think it should be qualcomm-specific, so something like
"qcom,krait-no-pc-write"? Again, I'd be glad to hear something from a DT
reviewer on this.
Will
next prev parent reply other threads:[~2014-01-10 11:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 22:59 [PATCH 0/7] Support Krait CPU PMUs Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-08 22:59 ` [PATCH 1/7] ARM: perf_event: Silence sparse warning Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-09 10:45 ` Will Deacon
2014-01-09 10:45 ` Will Deacon
2014-01-09 23:59 ` Stephen Boyd
2014-01-09 23:59 ` Stephen Boyd
2014-01-09 23:59 ` Stephen Boyd
2014-01-08 22:59 ` [PATCH 2/7] ARM: perf_event: Support percpu irqs for the CPU PMU Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-09 10:49 ` Will Deacon
2014-01-09 10:49 ` Will Deacon
2014-01-09 19:17 ` Stephen Boyd
2014-01-09 19:17 ` Stephen Boyd
2014-01-10 10:58 ` Will Deacon
2014-01-10 10:58 ` Will Deacon
2014-01-10 10:58 ` Will Deacon
2014-01-10 19:36 ` Stephen Boyd
2014-01-10 19:36 ` Stephen Boyd
2014-01-13 11:52 ` Will Deacon
2014-01-13 11:52 ` Will Deacon
2014-01-14 20:57 ` Stephen Boyd
2014-01-14 20:57 ` Stephen Boyd
2014-01-15 10:33 ` Will Deacon
2014-01-15 10:33 ` Will Deacon
2014-01-08 22:59 ` [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-09 11:04 ` Will Deacon
2014-01-09 11:04 ` Will Deacon
2014-01-09 11:04 ` Will Deacon
2014-01-09 19:57 ` Stephen Boyd
2014-01-09 19:57 ` Stephen Boyd
2014-01-10 11:01 ` Will Deacon [this message]
2014-01-10 11:01 ` Will Deacon
2014-01-10 11:01 ` Will Deacon
2014-01-10 18:57 ` Stephen Boyd
2014-01-10 18:57 ` Stephen Boyd
2014-01-08 22:59 ` [PATCH 4/7] ARM: perf_event: Add hook for event index clearing Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-08 22:59 ` [PATCH 5/7] ARM: perf_event: Fully support Krait CPU PMU events Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
[not found] ` <1389221984-10973-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-08 22:59 ` [PATCH 6/7] devicetree: bindings: Document Krait performance monitor units (PMU) Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
2014-01-09 18:14 ` Will Deacon
2014-01-09 18:14 ` Will Deacon
2014-01-09 19:57 ` Stephen Boyd
2014-01-09 19:57 ` Stephen Boyd
2014-01-08 22:59 ` [PATCH 7/7] ARM: dts: msm: Add krait-pmu to platforms with Krait CPUs Stephen Boyd
2014-01-08 22:59 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110110114.GC10455@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=ashwinc@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nleeder@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.