From: Ingo Molnar <mingo@kernel.org>
To: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
paul.gortmaker@windriver.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cleanups] x86: Delete non-required instances of include <linux/init.h>
Date: Sun, 12 Jan 2014 13:03:05 +0100 [thread overview]
Message-ID: <20140112120305.GA13076@gmail.com> (raw)
In-Reply-To: <tip-663b55b9b39fa9c848cca273ca4e12bf29b32c71@git.kernel.org>
* tip-bot for Paul Gortmaker <tipbot@zytor.com> wrote:
> Commit-ID: 663b55b9b39fa9c848cca273ca4e12bf29b32c71
> Gitweb: http://git.kernel.org/tip/663b55b9b39fa9c848cca273ca4e12bf29b32c71
> Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> AuthorDate: Mon, 6 Jan 2014 19:20:26 -0500
> Committer: H. Peter Anvin <hpa@zytor.com>
> CommitDate: Mon, 6 Jan 2014 21:25:18 -0800
>
> x86: Delete non-required instances of include <linux/init.h>
>
> None of these files are actually using any __init type directives
> and hence don't need to include <linux/init.h>. Most are just a
> left over from __devinit and __cpuinit removal, or simply due to
> code getting copied from one driver to the next.
>
> [ hpa: undid incorrect removal from arch/x86/kernel/head_32.S ]
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Link: http://lkml.kernel.org/r/1389054026-12947-1-git-send-email-paul.gortmaker@windriver.com
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
FYI, this patch breaks the UML build:
/home/mingo/tip/arch/x86/um/vdso/vdso.S: Assembler messages:
/home/mingo/tip/arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
/home/mingo/tip/arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'
Thanks,
Ingo
next prev parent reply other threads:[~2014-01-12 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 0:20 [PATCH] x86: delete non-required instances of include <linux/init.h> Paul Gortmaker
2014-01-07 5:15 ` [tip:x86/cleanups] x86: Delete " tip-bot for Paul Gortmaker
2014-01-07 5:22 ` [PATCH] x86: delete " H. Peter Anvin
2014-01-07 14:26 ` Paul Gortmaker
2014-01-07 5:27 ` [tip:x86/cleanups] x86: Delete " tip-bot for Paul Gortmaker
2014-01-12 12:03 ` Ingo Molnar [this message]
2014-01-12 14:22 ` Richard Weinberger
2014-01-12 14:52 ` [uml-devel] [PATCH] um, x86: Fix vDSO build Richard Weinberger
2014-01-12 17:02 ` H. Peter Anvin
2014-01-12 17:17 ` Richard Weinberger
2014-01-12 18:58 ` Geert Uytterhoeven
2014-01-12 19:01 ` Richard Weinberger
2014-01-13 12:50 ` Fengguang Wu
2014-01-13 20:01 ` H. Peter Anvin
2014-01-12 17:10 ` [tip:x86/cleanups] " tip-bot for Richard Weinberger
2014-01-12 17:18 ` [uml-devel] [PATCH] " Paul Gortmaker
2014-01-12 17:45 ` [tip:x86/cleanups] " tip-bot for Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112120305.GA13076@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.