From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-tip-commits@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, user-mode-linux-devel@lists.sourceforge.net,
hpa@zytor.com
Subject: Re: [uml-devel] [PATCH] um, x86: Fix vDSO build
Date: Sun, 12 Jan 2014 12:18:01 -0500 [thread overview]
Message-ID: <20140112171801.GA10322@windriver.com> (raw)
In-Reply-To: <1389538341-31383-1-git-send-email-richard@nod.at>
[[PATCH] um, x86: Fix vDSO build] On 12/01/2014 (Sun 15:52) Richard Weinberger wrote:
> Commit "x86: Delete non-required instances of include <linux/init.h>"
> broke the UML build.
>
> arch/x86/um/vdso/vdso.S: Assembler messages:
> arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
> arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'
>
> UML's vDSO needs linux/init.h.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Thanks Richard & Ingo. I did these cleanups last fall but never got
around to submitting them until now; I think the false positives for
removal crept in when I manually started the process, before realizing
the scale of it needed automatic selection/application and verification.
And without me doing uml testing, I never got a chance to see the
breakage and undo it. I'll definitely add uml to my regular testing.
I see hpa has already put this on x86/cleanups, but for the record:
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thanks again and sorry for the inconvenience.
P.
--
> ---
> arch/x86/um/vdso/vdso.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> index 4b4bd4c..1cb468a 100644
> --- a/arch/x86/um/vdso/vdso.S
> +++ b/arch/x86/um/vdso/vdso.S
> @@ -1,3 +1,4 @@
> +#include <linux/init.h>
>
> __INITDATA
>
> --
> 1.8.1.4
>
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2014-01-12 17:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 0:20 [PATCH] x86: delete non-required instances of include <linux/init.h> Paul Gortmaker
2014-01-07 5:15 ` [tip:x86/cleanups] x86: Delete " tip-bot for Paul Gortmaker
2014-01-07 5:22 ` [PATCH] x86: delete " H. Peter Anvin
2014-01-07 14:26 ` Paul Gortmaker
2014-01-07 5:27 ` [tip:x86/cleanups] x86: Delete " tip-bot for Paul Gortmaker
2014-01-12 12:03 ` Ingo Molnar
2014-01-12 14:22 ` Richard Weinberger
2014-01-12 14:52 ` [uml-devel] [PATCH] um, x86: Fix vDSO build Richard Weinberger
2014-01-12 17:02 ` H. Peter Anvin
2014-01-12 17:17 ` Richard Weinberger
2014-01-12 18:58 ` Geert Uytterhoeven
2014-01-12 19:01 ` Richard Weinberger
2014-01-13 12:50 ` Fengguang Wu
2014-01-13 20:01 ` H. Peter Anvin
2014-01-12 17:10 ` [tip:x86/cleanups] " tip-bot for Richard Weinberger
2014-01-12 17:18 ` Paul Gortmaker [this message]
2014-01-12 17:45 ` tip-bot for Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112171801.GA10322@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=hpa@zytor.com \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.