From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-pm@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>, Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tomasz Figa <t.figa@samsung.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>, Pavel Machek <pavel@ucw.cz>,
Kumar Gala <galak@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain
Date: Sun, 12 Jan 2014 19:20:40 +0000 [thread overview]
Message-ID: <20140112192040.GU29039@sirena.org.uk> (raw)
In-Reply-To: <1389469372-17199-2-git-send-email-tomasz.figa@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote:
> static struct s3c64xx_pm_domain s3c64xx_pm_irom = {
> - .name = "IROM",
> .ena = S3C64XX_NORMALCFG_IROM_ON,
> .pd = {
> + .name = "domain_irom",
This is nitpicking a bit but are you sure this is actually a
beautification of the name? It's mainly the domain_ bit, mostly since
I'd expect that if it's not obvious that this is a power domain the core
logging would be changed rather than tweaking the name of every power
domain user.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain
Date: Sun, 12 Jan 2014 19:20:40 +0000 [thread overview]
Message-ID: <20140112192040.GU29039@sirena.org.uk> (raw)
In-Reply-To: <1389469372-17199-2-git-send-email-tomasz.figa@gmail.com>
On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote:
> static struct s3c64xx_pm_domain s3c64xx_pm_irom = {
> - .name = "IROM",
> .ena = S3C64XX_NORMALCFG_IROM_ON,
> .pd = {
> + .name = "domain_irom",
This is nitpicking a bit but are you sure this is actually a
beautification of the name? It's mainly the domain_ bit, mostly since
I'd expect that if it's not obvious that this is a power domain the core
logging would be changed rather than tweaking the name of every power
domain user.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140112/f96ea494/attachment.sig>
next prev parent reply other threads:[~2014-01-12 19:21 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 19:42 [PATCH RFC 00/10] Generic Device Tree based power domain look-up Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-12 11:47 ` Pavel Machek
2014-01-12 11:47 ` Pavel Machek
2014-01-12 11:47 ` Pavel Machek
2014-01-12 12:16 ` Tomasz Figa
2014-01-12 12:16 ` Tomasz Figa
2014-01-12 18:53 ` Pavel Machek
2014-01-12 18:53 ` Pavel Machek
2014-01-12 19:03 ` Tomasz Figa
2014-01-12 19:03 ` Tomasz Figa
2014-01-12 19:24 ` Mark Brown
2014-01-12 19:24 ` Mark Brown
2014-01-12 19:20 ` Mark Brown [this message]
2014-01-12 19:20 ` Mark Brown
2014-01-12 19:25 ` Tomasz Figa
2014-01-12 19:25 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 02/10] ARM: s3c64xx: pm: Add always_on field to s3c64xx_pm_domain struct Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 03/10] ARM: s3c64xx: pm: Add pwr_stat bit for domain G Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 04/10] base: power: Add generic OF-based power domain look-up Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-14 15:42 ` Kevin Hilman
2014-01-14 15:42 ` Kevin Hilman
[not found] ` <87r48a8t99.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-20 16:24 ` Tomasz Figa
2014-01-20 16:24 ` Tomasz Figa
2014-01-20 16:24 ` Tomasz Figa
2014-01-23 0:32 ` Stephen Boyd
2014-01-23 0:32 ` Stephen Boyd
2014-01-16 16:34 ` Lorenzo Pieralisi
2014-01-16 16:34 ` Lorenzo Pieralisi
2014-01-20 17:32 ` Tomasz Figa
2014-01-20 17:32 ` Tomasz Figa
2014-01-22 11:00 ` Lorenzo Pieralisi
2014-01-22 11:00 ` Lorenzo Pieralisi
2014-01-23 0:18 ` Stephen Boyd
2014-01-23 0:18 ` Stephen Boyd
[not found] ` <20140123001802.GF13785-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-23 0:31 ` Tomasz Figa
2014-01-23 0:31 ` Tomasz Figa
2014-01-23 0:31 ` Tomasz Figa
2014-02-24 12:11 ` Ulf Hansson
2014-02-24 12:11 ` Ulf Hansson
2014-02-19 16:53 ` Philipp Zabel
2014-02-19 16:53 ` Philipp Zabel
2014-02-23 17:07 ` Tomasz Figa
2014-02-23 17:07 ` Tomasz Figa
2014-02-24 10:56 ` Philipp Zabel
2014-02-24 10:56 ` Philipp Zabel
2014-01-11 19:42 ` [PATCH RFC 05/10] ARM: exynos: Move to generic power domain bindings Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 06/10] ARM: s3c64xx: pm: Add device tree based power domain instantiation Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-12 19:29 ` Mark Brown
2014-01-12 19:29 ` Mark Brown
[not found] ` <20140112192910.GW29039-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-12 19:34 ` Tomasz Figa
2014-01-12 19:34 ` Tomasz Figa
2014-01-12 19:34 ` Tomasz Figa
2014-01-13 11:09 ` Mark Brown
2014-01-13 11:09 ` Mark Brown
2014-01-13 12:13 ` Tomasz Figa
2014-01-13 12:13 ` Tomasz Figa
2014-01-13 12:17 ` Mark Brown
2014-01-13 12:17 ` Mark Brown
2014-01-11 19:42 ` [PATCH RFC 07/10] ARM: s3c64xx: dt: Enable SoC-level power management Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 08/10] ARM: dts: s3c64xx: Add nodes for power domains Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 09/10] ARM: dts: s3c64xx: Add node for display controller Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:42 ` [PATCH RFC 10/10] ARM: dts: s3c6410-mini6410: Add support for LCD screen Tomasz Figa
2014-01-11 19:42 ` Tomasz Figa
2014-01-11 19:52 ` [PATCH RFC 00/10] Generic Device Tree based power domain look-up Tomasz Figa
2014-01-11 19:52 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112192040.GU29039@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.