From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Revert "ARM: dts: imx: use dual-fifo sdma script for ssi"
Date: Mon, 13 Jan 2014 14:50:21 +0530 [thread overview]
Message-ID: <20140113092021.GD25466@intel.com> (raw)
In-Reply-To: <20140110024359.GB6844@S2101-09.ap.freescale.net>
On Fri, Jan 10, 2014 at 10:44:03AM +0800, Shawn Guo wrote:
> On Wed, Jan 08, 2014 at 04:45:55PM +0800, Nicolin Chen wrote:
> > This reverts commit b1d27c79c8377df1880447375deffa3bb82c7bd3.
> >
> > Previously we switched the SSI scriprt to dual-fifo mode to reduce playback
> > underrun issue, which is only included by SDMA firmware version 2. However,
> > there are quite a lot people still using version 1 or default firmware in
> > the ROM code of SoC while these two kinds of firmwares do not support the
> > dual-fifo script and the audio function on their platform would be broken.
> >
> > Thus this patch provisionally reverts the dual-fifo script to the original
> > single fifo script to meet all kinds of users' requirements, including the
> > version 1/2 or inner ROM firmware.
> >
> > Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
>
> If Vinod's tree can be rebased, the patch can just be dropped.
Nope dont want Linus's ire due to rebaseing tree so late in cyle!
--
~Vinod
> Otherwise,
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
--
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Nicolin Chen <Guangyu.Chen@freescale.com>,
dan.j.williams@intel.com, kernel@pengutronix.de,
fabio.estevam@freescale.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] Revert "ARM: dts: imx: use dual-fifo sdma script for ssi"
Date: Mon, 13 Jan 2014 14:50:21 +0530 [thread overview]
Message-ID: <20140113092021.GD25466@intel.com> (raw)
In-Reply-To: <20140110024359.GB6844@S2101-09.ap.freescale.net>
On Fri, Jan 10, 2014 at 10:44:03AM +0800, Shawn Guo wrote:
> On Wed, Jan 08, 2014 at 04:45:55PM +0800, Nicolin Chen wrote:
> > This reverts commit b1d27c79c8377df1880447375deffa3bb82c7bd3.
> >
> > Previously we switched the SSI scriprt to dual-fifo mode to reduce playback
> > underrun issue, which is only included by SDMA firmware version 2. However,
> > there are quite a lot people still using version 1 or default firmware in
> > the ROM code of SoC while these two kinds of firmwares do not support the
> > dual-fifo script and the audio function on their platform would be broken.
> >
> > Thus this patch provisionally reverts the dual-fifo script to the original
> > single fifo script to meet all kinds of users' requirements, including the
> > version 1/2 or inner ROM firmware.
> >
> > Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
>
> If Vinod's tree can be rebased, the patch can just be dropped.
Nope dont want Linus's ire due to rebaseing tree so late in cyle!
--
~Vinod
> Otherwise,
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
--
next prev parent reply other threads:[~2014-01-13 9:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 8:45 [PATCH 0/2] Fix SSI audio function regression when using ROM firmware Nicolin Chen
2014-01-08 8:45 ` Nicolin Chen
2014-01-08 8:45 ` Nicolin Chen
2014-01-08 8:45 ` [PATCH 1/2] Revert "ARM: dts: imx: use dual-fifo sdma script for ssi" Nicolin Chen
2014-01-08 8:45 ` Nicolin Chen
2014-01-08 8:45 ` Nicolin Chen
2014-01-08 12:03 ` Fabio Estevam
2014-01-08 12:03 ` Fabio Estevam
2014-01-10 2:44 ` Shawn Guo
2014-01-10 2:44 ` Shawn Guo
2014-01-10 2:44 ` Shawn Guo
2014-01-13 9:20 ` Vinod Koul [this message]
2014-01-13 9:20 ` Vinod Koul
2014-01-08 8:45 ` [PATCH 2/2] dma: imx-sdma: Assign a default script number for ROM firmware cases Nicolin Chen
2014-01-08 8:45 ` Nicolin Chen
2014-01-08 8:45 ` Nicolin Chen
2014-01-08 12:03 ` Fabio Estevam
2014-01-08 12:03 ` Fabio Estevam
2014-01-08 12:03 ` Fabio Estevam
2014-01-13 9:22 ` [PATCH 0/2] Fix SSI audio function regression when using ROM firmware Vinod Koul
2014-01-13 9:22 ` Vinod Koul
2014-01-13 9:22 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113092021.GD25466@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.