Re: [PATCH] libxl: disallow PCI device assignment for HVM guest when PoD is enabled

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Jan 13, 2014 at 11:11:20AM +0000, Ian Campbell wrote:
> On Mon, 2014-01-13 at 10:54 +0000, Wei Liu wrote:
> > Any more comments on code logic and / or the location of the new
> > snippet? Should I send a new version with code comment fixed?
> > [...] 
> > > +    /* If target_memkb is smaller than max_memkb, the subsequent call
> > > +     * to libxc when building HVM domain will enable PoD mode.
> > > +     */
> > > +    pod_enabled = (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM) &&
> > > +        (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
> 
> I suppose this corresponds to exactly when PoD would be enabled?
> 

Yes. In libxc if maxmem > target_mem then pod_mode is set. See
tools/libxc/xc_hvm_build_x86.c:setup_guest.

> I'm happy with the patch, and it would be better to go ahead now than to
> wait for George (with his PoD hat in place) to confirm/deny, so please
> resend with the improved comment.

Will do.

Wei.

> 
> Ian.
>