From: Wolfram Sang <wsa@the-dreams.de>
To: Chris Ball <chris@printf.net>
Cc: linux-mmc@vger.kernel.org, Jaehoon Chung <jh80.chung@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
H Hartley Sweeten <hartleys@visionengravers.com>
Subject: Re: [PATCH] mmc: core: sd: implement proper support for sd3.0 au sizes
Date: Mon, 13 Jan 2014 19:46:45 +0100 [thread overview]
Message-ID: <20140113184645.GA17979@katana> (raw)
In-Reply-To: <861u0bdahb.fsf@void.printf.net>
[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]
On Mon, Jan 13, 2014 at 06:04:32PM +0000, Chris Ball wrote:
> Hi Wolfram,
>
> On Mon, Jan 13 2014, Wolfram Sang wrote:
> > On Tue, Nov 26, 2013 at 02:16:25AM +0100, Wolfram Sang wrote:
> >> This reverts and updates commit 77776fd0a4cc541b9a528eacc1d31ca47eb1ae7a
> >> ("mmc: sd: fix the maximum au_size for SD3.0"). The au_size for SD3.0
> >> cannot be achieved by a simple bit shift, so this needs to be
> >> implemented differently. Also, don't print the warning in case of 0
> >> since 'not defined' is different from 'invalid'.
> >
> > Ping! Chris are you there? This got reviewed and acked, and I'd even
> > think this could be suitable for stable.
>
> Sorry about that! I agree, pushed to mmc-next for 3.14 with stable@ tag.
Thanks. As buildbot reports, this will probably need another patch for
blackfin :/ Sorry about that!
From: Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH] mmc: core: add #include to support size defintions
Fixes an error found by buildbot on blackfin after adding the fix for
sd3.0 au sizes:
>> drivers/mmc/core/sd.c:49:5: error: 'SZ_16K' undeclared here (not in a function)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/mmc/core/sd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 6f42050..585d44d 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -11,6 +11,7 @@
*/
#include <linux/err.h>
+#include <linux/sizes.h>
#include <linux/slab.h>
#include <linux/stat.h>
#include <linux/pm_runtime.h>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-13 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 1:16 [PATCH] mmc: core: sd: implement proper support for sd3.0 au sizes Wolfram Sang
2013-11-26 5:14 ` Jaehoon Chung
2013-11-26 17:06 ` Wolfram Sang
2013-11-26 16:26 ` Hartley Sweeten
2013-12-18 12:30 ` Wolfram Sang
2014-01-13 12:41 ` Wolfram Sang
2014-01-13 18:04 ` Chris Ball
2014-01-13 18:46 ` Wolfram Sang [this message]
2014-01-13 19:14 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113184645.GA17979@katana \
--to=wsa@the-dreams.de \
--cc=chris@printf.net \
--cc=hartleys@visionengravers.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.