From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pol Eyschen <poleyschen@gmail.com>
Cc: devel@driverdev.osuosl.org, jack@suse.cz,
sachin.kamat@linaro.org, linux-kernel@vger.kernel.org,
ufimtseva@gmail.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c
Date: Tue, 14 Jan 2014 01:38:04 +0300 [thread overview]
Message-ID: <20140113223804.GI7444@mwanda> (raw)
In-Reply-To: <CF9619EF-B1AE-4F7D-B080-E5D4B5625474@gmail.com>
On Mon, Jan 13, 2014 at 11:31:29PM +0100, Pol Eyschen wrote:
> >
> I took the original comments that were there, and just formatted them
> to be in order with the coding style, I didn't add or remove
> anything. This is my first patch so I didn't want to mess too much
> with what was there before, even if the comments sometimes seemed
> superfluous to me.
No problem, everyone's first patch is rejected. Just fix it up in line
with the review comments and resend.
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-13 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 19:41 [PATCH] Staging: ced1401: fix coding style in ced_ioc.c Pol Eyschen
2014-01-13 21:35 ` Mark Einon
2014-01-13 21:44 ` Dan Carpenter
2014-01-13 22:31 ` Pol Eyschen
2014-01-13 22:38 ` Dan Carpenter [this message]
2014-01-13 22:41 ` Greg KH
2014-01-13 23:56 ` Greg KH
2014-01-14 2:19 ` Joe Perches
2014-01-14 5:09 ` [PATCH] staging: ced1401: Fix dev_<level> messages Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113223804.GI7444@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=poleyschen@gmail.com \
--cc=sachin.kamat@linaro.org \
--cc=ufimtseva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.