From: Greg KH <gregkh@linuxfoundation.org>
To: Pol Eyschen <poleyschen@gmail.com>
Cc: sachin.kamat@linaro.org, jack@suse.cz, ufimtseva@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Pol Eyschen <poleyschen@hotmail.com>
Subject: Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c
Date: Mon, 13 Jan 2014 15:56:50 -0800 [thread overview]
Message-ID: <20140113235650.GA23380@kroah.com> (raw)
In-Reply-To: <1389642100-3601-1-git-send-email-poleyschen@gmail.com>
On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote:
> From: Pol Eyschen <poleyschen@hotmail.com>
>
> All comments fixed to match the kernel coding style.
>
> Signed-off-by: Pol Eyschen <poleyschen@gmail.com>
> ---
> drivers/staging/ced1401/ced_ioc.c | 382 ++++++++++++++++++++++++-------------
> 1 file changed, 249 insertions(+), 133 deletions(-)
>
> diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c
> index 62efd74..e5172cb 100644
> --- a/drivers/staging/ced1401/ced_ioc.c
> +++ b/drivers/staging/ced1401/ced_ioc.c
> @@ -41,7 +41,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
> {
> dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
> pdx->sCurrentState);
> - if (pdx->sCurrentState == U14ERR_TIME) /* Do nothing if hardware in trouble */
> + if (pdx->sCurrentState == U14ERR_TIME)
> + /* Do nothing if hardware in trouble */
> return;
Please wrap stuff like this in { } to not confuse people.
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-13 23:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 19:41 [PATCH] Staging: ced1401: fix coding style in ced_ioc.c Pol Eyschen
2014-01-13 21:35 ` Mark Einon
2014-01-13 21:44 ` Dan Carpenter
2014-01-13 22:31 ` Pol Eyschen
2014-01-13 22:38 ` Dan Carpenter
2014-01-13 22:41 ` Greg KH
2014-01-13 23:56 ` Greg KH [this message]
2014-01-14 2:19 ` Joe Perches
2014-01-14 5:09 ` [PATCH] staging: ced1401: Fix dev_<level> messages Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113235650.GA23380@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=poleyschen@gmail.com \
--cc=poleyschen@hotmail.com \
--cc=sachin.kamat@linaro.org \
--cc=ufimtseva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.